Repository navigation
chore(sdui-parser): retire the objectui lockstep gate and its vendored record - #26221
Merged
Merged
Conversation
…d record One parser is kept (`@objectstack/sdui-parser`), so the gate that held two copies byte-equal has nothing left to compare once the renderer's copy goes. Removes `scripts/check-sdui-lockstep.mjs`, `packages/sdui-parser/objectui-lockstep.json`, the `check:sdui-lockstep` / `gen:sdui-lockstep` scripts, the lint.yml step, the NOT_DRIVER_MANAGED row and the measurement-triage row, and drops the prose that pointed at the gate. Claude-Session: https://claude.ai/code/session_01Xe3LjBvLrRVA6dmFUEGskm Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift Check
What this run could not see
Coarse fallback — 3 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
os-zhuang
approved these changes
Oct 26, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tesla · project thread
Part of #25712 (item 3 = 2g, PR 3 of 3: retire the sdui-parser lockstep; lands FIRST by PM ruling; Tier H:
.github/workflows/lint.yml).Part of #25677.
Clause-②: no
Metadata-protocol: none
维护者速读(草稿)
scripts/check-sdui-lockstep.mjs(1634 行)、它的记录packages/sdui-parser/objectui-lockstep.json、check:sdui-lockstep/gen:sdui-lockstep两个脚本、lint.yml里的那一步,以及 merge driver 台账和测量分诊表里指向它的两行。其余只改了指向它的注释。@objectstack/sdui-parser一份(6418729849)。只剩一份时这个门禁就没有可比的对象了。.objectui-sha,门禁直接拿ui/packages/sdui-parser/src做对照。2g PR 1 合并两份实现时会单边改到它比对的区域,PR 2 删掉 ui 那份后它会直接拒绝。先退役它,PR 1 和 PR 2 就不会因为它变红。lint.yml)。席位核对
(left for the dispatch seat)
Why
Ruling 6418729849 on #25712 (2g decision card 6418466647, letter E + B) keeps
@objectstack/sdui-parseras the one parser, deletesui/packages/sdui-parser, and retirescheck-sdui-lockstep.mjswith its record. The PM ordered this PR first: with.objectui-shagone, the gate's oracle isui/packages/sdui-parser/srcread in place (oracleFor, "pin absent,ui/copy"), and it REFUSES a tree with neither the pin nor that copy. So:@objectstack/sdui-parser) reds the gate if it edits the parse region, the diagnostic-code set orvalidate.ts's containment branch on one side only;claude/project-thread-6qe56u) and removes the second copy's role; 2g PR 2 then deletes it.What changes
scripts/check-sdui-lockstep.mjs,packages/sdui-parser/objectui-lockstep.json(not in the package'sfiles, so nothing published changes).package.json:check:sdui-lockstepandgen:sdui-lockstepremoved..github/workflows/lint.yml: the stepsdui-parser-stays-in-lockstep-with-objectuiand its comment block removed. No other step or aggregator names that id.scripts/regen-artifacts.mjs: theNOT_DRIVER_MANAGEDrow forobjectui-lockstep.jsonremoved (the file no longer exists).ROOT_OWNERkeeps four other rows.scripts/pm/measurement-claim-triage.mjs: the row whosefileis the deleted gate removed.scripts/check-sdui-manifest.mjs(3 places),scripts/gen-sdui-manifest-node.mjs,scripts/pm/os-regen-merge.sh.Left on purpose
packages/sdui-parser/src/parse.ts:49,src/validate.ts:53(theLOCKSTEP:docblock),src/__tests__/html-tier-manifest.test.ts:12,src/__tests__/inert-quick-add.test.ts:19, and the invariant text ofscripts/adr-anchors/packages__sdui-parser__src__parse.ts.json: 2g PR 1 rewrites these files (andvalidate.ts'sacceptsChildrendocblock ships in the.d.ts), so editing them here would put a published-package change and a changeset into a no-publish PR and collide with PR 1.ui/packages/sdui-parser/src/parse.ts:52: deleted with the package in 2g PR 2.scripts/regen-artifacts.mjs:85,scripts/check-regen-pending.mjs:143, the self-test literal inscripts/check-pnpm-flag-spellings.mjs:884,.gitattributes:127,docs/audits/*, and CHANGELOGs (release-owned).Verification
All readings at head
ce348aef(base365fe5ec).node scripts/pm/dispatch-gates.mjs --commands→ 97 families; all 97 run, all exit 0 (four dist-reading gates and the teardown self-test after a fullpnpm buildand the pinned-sha fetch).--ranreconciliation: 97 derived, 97 run, 0 NOT-MEASURED, 0 UNRUN. List:/mnt/project-files/d1-merge/out/2g-b/pr3-gates-ran-ce348aef.list.GITHUB_ACTIONS=true GITHUB_EVENT_NAME=push node scripts/pm/check-dispatch-gates.mjs→✓ dispatch-gates self-test: 2182 cases pass(fast 1917 in 478 s, slow 265 in 1312 s), exit 0.node scripts/pm/check-governed-merges.mjs --branch claude/project-thread-hrsgde→ GOVERNED (1 of 9 paths:.github/workflows/lint.yml), 1768 changed lines (+10 / −1758), under the 3000 human-merge line. Tier H.pnpm lintand the fullTest Corematrix.Changeset
None: the diff publishes nothing from any released package (
objectui-lockstep.jsonis outside@objectstack/sdui-parser'sfiles).skip-changeset.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xe3LjBvLrRVA6dmFUEGskm