Skip to content

fix(fields): lookup subtitle no longer repeats the referenced object's name field - #26062

Merged
objectstack-fleet[bot] merged 7 commits into
mainfrom
claude/issue-25860-lookup-subtitle-name-field
Oct 26, 2026
Merged

objectstack-fleet[bot] merged 7 commits into
mainfrom
claude/issue-25860-lookup-subtitle-name-field

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #25860

Clause-②: no
Metadata-protocol: none

What

The lookup quick-picker shows each candidate as a title over a subtitle (the preview line) of the referenced object's other columns. A lookup that declares no displayField titles the option through the referenced object's own name field (recordToOption calls getRecordDisplayName: declared nameField, else a titleFormat template, else the derived title field). But previewColumns in ui/packages/fields/src/widgets/LookupField.tsx seeded its seen set with displayField only, and without a declared one that is the widget's 'name' guess. So on an object whose name field is anything other than name (title, customer_name, every AI-built object), the subtitle's first and widest slot repeated the title. The phone number, the field that tells two records apart, was pushed into truncation.

previewColumns now also adds the referenced object's resolved name field to seen (resolveNameField(refObjectSchema) from @object-ui/core) when the lookup declares no displayField. It follows the same ladder the title follows:

  • A declared displayField titles the option, so it alone is skipped and the object's name field stays in the subtitle (unchanged).
  • An object with no declared name field but a titleFormat is titled by the template, not by a field, so nothing more is skipped (declaredNameField decides this).
  • An explicitly authored descriptionField still leads the subtitle (unchanged).

The memo's deps gain declaredDisplayField and refObjectSchema. The import line gains declaredNameField and resolveNameField. Nothing else in the component changed.

scripts/sdui-manifest.record.json is re-recorded (node scripts/gen-sdui-manifest-node.mjs, under the verify lock), because the registry source digest covers ui/packages/fields/src. sdui.manifest.json itself is byte-unchanged (sha256 1f6e1ccb925a…, 106 components). The branch merged origin/main before this PR to pick up main's own re-record of that file. The merge took main's copy and the next commit (dcee0130) re-recorded it on the merged tree, so the digest describes the tree this PR lands.

Tests

New ui/packages/fields/src/widgets/LookupField.subtitleNameField-25860.test.tsx (5 cases). It opens the real dropdown against a stub data source and reads each option's title and its previewed fields (data-lookup-preview) in order:

  • The object declares nameField: 'title': the subtitle is phone, source, and title is no longer first.
  • No nameField is declared (the title field is derived as title): the same result.
  • An authored descriptionField: 'source' still leads: source, phone.
  • Control: a declared displayField: 'code' titles the option, and title stays in the subtitle.
  • Control: a titleFormat-only object keeps the derived title in the subtitle.

Ablation, run once and not kept. The fix was committed first. node scripts/ablation-replace.mjs replaced if (nameField) seen.add(nameField); with a comment (anchor count 1 to 0, blob 04c7cbb215e3 to b6be553ded33). The result was Tests 3 failed | 2 passed (5): the three behaviour cases went red and both controls stayed green. The restore was verified (blob equal to HEAD 04c7cbb215e3, git diff HEAD empty). No build or dist is involved: the test imports ./LookupField from source, and the ui vitest config points @object-ui/core at packages/core/src.

All runs below went through scripts/pm/os-verify-lock.sh. The @object-ui/fields^... closure was built first.

  • cd ui && pnpm exec vitest run --maxWorkers=2 packages/fields/: Test Files 278 passed | 1 skipped (279), Tests 4295 passed | 7 skipped (4302), VERDICT command-exit 0. This ran on the pre-merge head a200f71d. The merge brought no change under ui/packages/fields, ui/packages/core or ui/packages/types.
  • After the merge, at dcee0130: the new test plus labelOrder-10343, optionDescription and previewBadges-13123 gave Test Files 4 passed (4), Tests 21 passed (21), VERDICT command-exit 0.
  • pnpm --filter @object-ui/fields type-check (tsc --noEmit && tsc -p tsconfig.test.json): exit 0. tsconfig.test.json includes src/**/*.test.tsx, so it checks the new test too.

Gates: at dcee0130, node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 46 commands. All 46 exit 0, including node scripts/check-sdui-manifest.mjs, pnpm check:nul-bytes and pnpm check:type-check-coverage. The --ran reconciliation reports 46 derived, 46 run, 0 NOT-MEASURED (a derived zero, with every exit code recorded). CI runs the rest of the families.

Acceptance notes

  • effectiveDescriptionField still falls back to the first picker column that is not displayField, so for an undeclared lookup it can be the name field. It is only used for the option's description, which feeds the popover's text match and is not rendered as the subtitle. It is outside this card's file surface, so it is left as is. No user-visible effect was measured.
  • getRecordDisplayName decides per record. If the declared name field is blank on one record, that record's title falls through to the template or the derived field. The subtitle skips the name field for every row, and a blank value would not render anyway (previewOf drops empty cells).

Generated by Claude Code

… the title reads

The quick-picker's preview line skipped only the widget's 'name' guess, so
an object whose name field is anything else repeated the option's title as
the subtitle's first item. previewColumns now also skips the resolved name
field when the lookup declares no displayField, unless a titleFormat
template titles the record.

Claude-Session: https://claude.ai/code/session_01SMps7wq7rBTk53e8KTSEup
Co-authored-by: Claude <noreply@anthropic.com>
…okup-subtitle-name-field

# Conflicts:
#	scripts/sdui-manifest.record.json
@github-actions github-actions Bot added size/m documentation Improvements or additions to documentation tooling labels Oct 26, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对

ACCEPT · domain:ui seat 2 · session_01SMps7wq7rBTk53e8KTSEup · 2026-10-26T10:42Z · head dcee0130

  1. 形态: draft → main, assignee os-steve, mergeable. The body's first line is Fixes #25860, which is right because the whole card lands here. Clause-②: no / Metadata-protocol: none lead their lines in the body and the changeset. no is correct: declaredNameField / resolveNameField are existing @object-ui/core exports, and LookupField exports nothing new.
  2. 前提实测: the seat read the diff at this head. previewColumns still seeds seen with displayField. When no displayField is declared and the ref schema is known, it also adds resolveNameField(refObjectSchema). The one exception is an object titled by titleFormat with no declared name field. This mirrors recordToOption → getRecordDisplayName's ladder. The memo deps gain declaredDisplayField and refObjectSchema. A declared displayField and an authored descriptionField behave as before, and the two control cases in the new test pin both.
  3. 门禁 check-runs: at this head, 12 success, 7 skipped, 39 in progress, 0 failure at the time of reading. Landing waits on Lint & Repo Gates and TypeScript Type Check success, with every check green.
  4. 接受的偏差: none. The diff is exactly the claimed surface: LookupField.tsx (the previewColumns memo and its imports), the new LookupField.subtitleNameField-25860.test.tsx, the re-recorded scripts/sdui-manifest.record.json, and the root .changeset/ patch for @object-ui/fields. fields/src/index.tsx is untouched.
  5. 范围外去向: the dev noted one item and did not file it: effectiveDescriptionField can fall back to the name field for an undeclared lookup, but it feeds only the popover's description text match, not the rendered subtitle. No user-visible effect was measured. The seat accepts no carrier for it.
  6. 落地条款: no governed path, +160/−3. Once the checks are green at this head, the seat lands it via relay pr_ready + automerge_enable. If the PR only needs a merge of main or a manifest re-record, this ACCEPT carries over.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 26, 2026 10:55
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 26, 2026 10:55
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 26, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 26, 2026
os-zhuang pushed a commit that referenced this pull request Oct 26, 2026
… different packages stop conflicting (#26120)

<!-- claude-projects-attribution: {"github_login":"os-elon-musk"} -->
_Requested by **Elon** · [project
thread](https://claude.ai/code/project/chan_01WedDzV26nniwxv7jC88B9D?thread=cmsg_01WedDzV26nniwxv7jC88B9DPXV532seCFDcrkAJybGzsf)_

Fixes #26051

Clause-②: no
Metadata-protocol: none

Part of the p1 merge-queue backlog work (#26074). Dispatched by seat
`domain:devx#1` (#6023), claim 6415558140, card-thread session
`session_01SMJGPXxFBpbgAgXdnsXKVS`.

## What changes

`scripts/sdui-manifest.record.json` carried ONE
`inTree.registrySourcesSha256` over the `src/` of all 27 ui registry
packages, so any two ui PRs that touched any registry package conflicted
on that line. Now:

- **One record per registry package**, one file each, one line each:
`scripts/sdui-manifest.sources/PACKAGE.json` =
`{"package","sources","sha256","manifestSha256"}` (the package's own
`src/` digest, its file count, and the sha256 of the artefact it was
verified against). 27 files.
- **The shared record** (`scripts/sdui-manifest.record.json`, same path)
keeps only what describes the artefact: `sha256`, `components`,
`generatedAt`, and `inTree` = `modulesRoot`, `objectuiWorkspaceVersion`,
`registryRecords` (the directory). The retired `registryPackages` /
`registrySources` / `registrySourcesSha256` are refused if they
reappear.
- **The reached package set** is the set of record files: a reached
package with no record (new package, new dependency edge into the
registry, deleted record) is RED; a record the registry no longer
reaches (removed package, dropped edge) is RED.
- `sdui.manifest.json` is byte-identical (sha256 `1f6e1ccb925a…`, 106
components).

`lint.yml`'s command line (`node scripts/check-sdui-manifest.mjs
--self-test && node scripts/check-sdui-manifest.mjs`) is unchanged and
keeps working. No `.github/**` or `ui/.github/**` edit.

## Measured first (Ask 1): own `src/` per package, not
dependency-inclusive

Tree: objectstack `0a6948210c` (base), 27 reached packages, 922 non-test
sources.

**Detection is the same as one digest over the set.** Any edit under any
reached package's `src/` moves exactly that package's digest, so a
single PR's edit is caught exactly as before; a dependency's edit is
caught through the dependency's own record. Dependency-inclusive digests
add no single-PR detection. They would only add conflicts, and at this
cost (records a `src/` edit would touch):

| package edited | own `src/` (this PR) | dependency-inclusive |
|:--|:-:|:-:|
| `types` | 1 | 25 |
| `core` | 1 | 21 |
| `data-objectstack`, `i18n` | 1 | 19 |
| `react`, `react-runtime`, `sdui-parser` | 1 | 18 |
| `components` | 1 | 17 |
| `fields` | 1 | 14 |
| `plugin-detail` | 1 | 10 |
| `plugin-form`, `plugin-grid` | 1 | 2 |
| the other 11 plugins | 1 | 1 |

**Merge experiment, real tree, `git merge-tree --write-tree` (no merge
driver routes these paths; `git check-attr merge` = unspecified, so this
is GitHub's answer):** each branch appends a comment to one `src/` file
and runs the generator.

| pair | before (single digest, on `0a6948210c`) | after (this PR, on
`a8114011`) |
|:--|:--|:--|
| `plugin-grid/src/FormulaBar.tsx` × `plugin-form/src/DrawerForm.tsx` |
exit 1, CONFLICT in `scripts/sdui-manifest.record.json` | exit 0, clean;
the merged tree passes `check-sdui-manifest` (exit 0) |
| `plugin-grid/src/FormulaBar.tsx` × `plugin-grid/src/ObjectGrid.tsx` |
(conflicts) | exit 1, CONFLICT in
`scripts/sdui-manifest.sources/plugin-grid.json` only, by design |

**The open ui PRs today** (registry packages each changes, non-test
`src/` only; none changes `sdui.manifest.json`): #25987 i18n,
plugin-grid, plugin-list · #25998 plugin-detail · #26040 components,
i18n · #26045 i18n · #26027 plugin-dashboard · #26030 plugin-grid ·
#26033 core, plugin-form, plugin-grid · #26042 plugin-form · #26044 i18n
· #26048 i18n, plugin-map · #26050 fields, plugin-grid · #26062 fields.
Under the single digest all 12 conflict pairwise (12 serial landings).
Under this layout they conflict only within a shared package; the
largest group is `i18n` (5 PRs), so they can land in 5 rounds, e.g.
{#25987, #25998, #26027, #26042, #26062} → {#26040, #26030} → {#26045,
#26033} → {#26044, #26050} → {#26048}, assuming no source-level
conflicts between them.

## The check (Ask 2)

`checkTreeWithoutPin` compares each reached package's digest with its
own record and names every stale package (`ui/packages/plugin-grid: now
38 file(s) sha256 …, recorded …`), every unrecorded package, every
record the registry no longer reaches, every record verified against
another artefact, and every malformed record, then prints the one
command: `node scripts/gen-sdui-manifest-node.mjs`. The pin mode
(`.objectui-sha` present) is untouched.

**Why `manifestSha256` is in every package record, and why one line:** a
PR that changes the artefact re-records every package against the new
sha256, so it still conflicts with every in-flight registry PR, which
must regenerate on the merged tree (that is today's behaviour, kept for
the case where it matters). Two PRs on the same package touch the same
line and conflict. One line per file guarantees git cannot merge a
digest from one side with an artefact sha256 from the other; a record
that is not in the producer's one-line form is RED.

**What this does not force, stated rather than implied:** two PRs on
different packages that each leave the artefact unchanged, where only
their combination would change it, land without any run seeing the
combination. Under the single digest their textual conflict forced that
run. Here the next regeneration of any registry package sees the
combination. Dependency-inclusive digests would close this only along
import edges (not between siblings that interact through
`ComponentRegistry`), at the fan-out above. No stale or missing registry
source passes: every source edit still reds until regenerated, and every
package added to or removed from the reached set still reds.

## Self-test (Ask 3)

29 rows (was 22), roster and floor updated. New or changed in-tree rows:
a staged edit to one package is RED naming that package and NOT naming
`plugin-form` or `core`; a new package the registry reaches; a new
workspace edge (now names `ui/packages/unrelated`); a removed package
(names `scripts/sdui-manifest.sources/types.json`); a deleted package
record; a record verified against another artefact; a record out of its
one-line form; a record from the single-digest layout; and the producer
re-recording only the moved package (it back-dates the shared record
first, so a producer that stamps today's date reds the row).

Ablations, one at a time through `scripts/ablation-replace.mjs`, each
restored with `git diff HEAD` empty:

| guard removed | self-test |
|:--|:--|
| the other-artefact comparison (gate) | exit 1, row "a package record
verified against another artefact is RED" expected RED got GREEN |
| the one-line form comparison (gate) | exit 1, row "a package record
out of its one-line form is RED" |
| the unreached-record list (gate) | exit 1, row "a removed registry
package is RED naming its record" |
| the `generatedAt` carry (producer) | exit 1, row "the producer
re-records only the package whose sources moved": the second run changed
the shared record too |
| the per-package record write (producer) | exit 1, the two producer
rows |

## The generator (Ask 4)

It re-records only the packages whose line changed and leaves the others
byte-identical; it removes a record the registry no longer reaches; it
prints which packages it re-recorded. The shared record moves only with
the artefact: `generatedAt` and the provenance version are carried while
the artefact's sha256 is unchanged (the same rule the pin-keyed fields
already follow), so a regeneration on another day no longer moves a
shared line.

**It still builds, and why:** the build plus the enumeration is the only
oracle that says whether `sdui.manifest.json` moved. A record written
without it would stamp a current digest on a manifest no run checked,
which is the narrowing this card forbids. The 8 minutes is a cold turbo
cache, not the build of one package. Measured on `0a6948210c`, one
container, no remote cache (`TURBO_TOKEN` unset):

| run | wall | turbo |
|:--|:-:|:--|
| cold | 8m49s | 0 of 63 cached, 8m43s |
| nothing moved | 6s | 63 of 63 cached |
| one edit under `plugin-grid/src` | 33s | 61 of 63 cached, 27s |
| one edit under `core/src` | 2m50s | 41 of 63 cached, 2m44s |

## Readers moved (Ask 5)

- `docs/releases-maintenance.md`: the regenerate section describes the
per-package records, the re-record rule and which PRs still conflict.
- `scripts/check-changeset-no-major.mjs`: the "measured out" comment,
the real-build assertion (neither record is shipped) and the
records-only control now cover `scripts/sdui-manifest.sources/`. Its
`--self-test` passes (456 assertions).
- `scripts/ui-import/README.md` is not edited: line 140 records what the
cutover's step 4 wrote at the time, and that file still exists at that
path.
- `git grep -n "sdui-manifest.record"` outside CHANGELOGs: only the two
scripts, the docs page, `check-changeset-no-major.mjs` and that
historical README line. `git grep registrySourcesSha256`: only the
retired-field list and its self-test row.

## After this lands: what an in-flight ui PR does (once)

A ui PR whose branch re-recorded the old single digest conflicts once on
`scripts/sdui-manifest.record.json`:

```sh
git merge origin/main                                   # conflict in scripts/sdui-manifest.record.json
git checkout --theirs scripts/sdui-manifest.record.json  # take main's layout
node scripts/gen-sdui-manifest-node.mjs                  # re-records only this PR's package(s)
git add scripts/sdui-manifest.record.json scripts/sdui-manifest.sources sdui.manifest.json
git commit
```

After that, PRs on different registry packages no longer conflict with
each other on the record.

## Gates

Local, on `a8114011` (derived with `node scripts/pm/dispatch-gates.mjs
--commands`): 39 of the 40 derived families exit 0, including `node
scripts/check-sdui-manifest.mjs --self-test` (29 cases) and `node
scripts/check-sdui-manifest.mjs`, `node
scripts/check-changeset-no-major.mjs --self-test` and `--base
origin/main`, `pnpm check:nul-bytes`, `pnpm check:watch-hint-literal`,
`pnpm check:required-contexts`, `pnpm check:doc-authoring` and `pnpm
--filter @objectstack/lint run check:doc-formula-expressions` (after the
lint closure build). `pnpm check:pm-dispatch-gates` was still running
when this PR opened; its reading goes into the report comment on #26051,
and CI runs it in Lint & Repo Gates.

CI on the PR's check-runs: pending at the time of writing; the seat
reads them.

Changeset: none, `skip-changeset`. The diff touches only root `scripts/`
(private), `docs/` and the records; `sdui.manifest.json` is
byte-identical and neither record is copied into
`packages/console/dist/` (the `check-changeset-no-major` real-build
assertion above).

Not Tier H: no governed path (`git diff --name-only` has no `.github/`,
`.claude/`, `docs/adr/`, `skills/`, `AGENTS.md`, `CLAUDE.md`).

## Acceptance notes

- `i18n` is the hot package: 5 of the 12 open ui PRs touch its `src/`,
so they still serialize on `scripts/sdui-manifest.sources/i18n.json`.
Whether locale data belongs in the digest at all is a narrowing question
(it would let a source change pass unregenerated), not something this PR
decides.
- The cold-cache cost of a regeneration (8m43s here) is a
fresh-container property; card threads run with no turbo remote cache.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01SMJGPXxFBpbgAgXdnsXKVS)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
…okup-subtitle-name-field

# Conflicts:
#	scripts/sdui-manifest.record.json
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit dfaad4d Oct 26, 2026
61 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-25860-lookup-subtitle-name-field branch October 26, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/m tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lookup picker: the subtitle repeats the record name when the referenced object's name field is not name — every AI-built lookup

2 participants