fix(components): a refused submit focuses the first invalid field instead of toasting the field list over the dialog title by objectstack-fleet[bot] · Pull Request #26040 · objectstack-ai/objectstack

objectstack-fleet · 2026-10-26T10:03:05Z

Requested by Steve · project thread

Clause-②: no
Metadata-protocol: none

What changes

The "banner" over the record dialog's title is the sonner error toast that announceFieldErrors in ui/packages/components/src/renderers/form/form.tsx raised on every refused submit, naming the fields (truncated after three). Route (c) from the claim:

No field-list toast. announceFieldErrors no longer toasts. It scrolls to the first invalid field in form order and focuses it, activating that field's tab first when the tab is a background one (unchanged mechanism). The message under each input is the whole report.
A field with no drawn input. announceFieldErrors now returns the rejected names that have no drawn wrapper in the DOM (a field on a predicate-hidden tab or section). The toast used to be the only thing that said those out loud. On the server path, any such name sends the failure down the existing form-level path (banner + its toast twin with the server's sentence), the same path a rejection naming an unknown field already takes. The hidden tab is never activated. The client path cannot produce such a name (react-hook-form validates only mounted controls).
Earlier outcomes retire on a client refusal. The refusal toast used to supersede the previous outcome under the form's outcome id (a server refusal's toast, or the objectui#8070 clear-on-hide notice). With no toast, the client-invalid handler now clears submitError and dismisses the outcome id itself, as an attempt that passes validation already does.
scripts/sdui-manifest.record.json re-recorded (node scripts/gen-sdui-manifest-node.mjs); sdui.manifest.json itself is unchanged.
Changeset: .changeset/25874-form-refusal-no-field-toast.md (@object-ui/components, @object-ui/i18n patch).

ConsoleToaster placement is untouched: no toast is raised in the case the card describes.

Tests

Changed / added pins (all in ui/packages/components/src/renderers/form/__tests__/):

form-invalid-scroll: an empty required field is scrolled to and focused, its message is under the input, and no error toast is raised.
form-server-field-errors: a fully attributed server rejection raises no toast; a later client refusal retires the previous refusal's banner and toast.
fieldtab-visiblewhen-6237: a server rejection of a field on a hidden tab shows the server's sentence at form level (one toast, the banner), and the hidden tab is not activated.
visiblewhen-clear-notice-8070: a later attempt retires the clear-on-hide notice whether it is refused (dismiss, no error toast) or accepted.
form-invalid-toast-joiner: the per-locale joiner pin moved to the faulted-visibleWhen refusal, the form's remaining field-name list that reads validation.formInvalidJoiner.

Runs (head cb3fe1a0, after merging origin/main at 39a78b15; the form suite was re-run on the merged tree with the same result):

vitest run packages/components/src/renderers/form/__tests__/ (from ui/): Test Files 78 passed (78), Tests 545 passed, 17 skipped.
Reverse verification: form.tsx restored to the base 3518664c with the new tests in place: 5 failed / 33 passed over the 5 changed files (the 5 new or changed assertions above; the joiner file stays green, as predicted, since the base already joins the visibleWhen refusal per locale). Restored to HEAD, git diff HEAD empty, blob hash equal.
pnpm --filter @object-ui/components type-check: exit 0.
node scripts/check-sdui-manifest.mjs: exit 0.

Gates: the derived local set (node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack) derived 46 families at this head; all 46 ran locally, each exit 0; --ran reconciliation: "46 run, 0 NOT-MEASURED (a DERIVED zero)". Every other family is left to this PR's CI check-runs.

Acceptance notes

validation.formInvalid is removed from the form's default map and all ten locale packs; nothing else read it. validation.formInvalidJoiner stays.

Generated by Claude Code

🤖 Generated with Claude Code

https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2

…tead of toasting the field list The invalid-submit toast repeated what each field already says under its input, truncated its own list after three names, and was drawn over the record dialog's title row. Drop it; keep reveal + focus on the first invalid field (activating its tab first). A server rejection naming a field with no drawn input (a predicate-hidden tab or section) now falls through to the form-level banner, which the toast used to cover. Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

…anner and toast Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

…-eprqgc # Conflicts: # scripts/sdui-manifest.record.json

Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

…and bring two comments in line Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

objectstack-fleet · 2026-10-26T10:52:02Z

席位核对 · ACCEPT · seat `domain:ui#1` · 2026-10-26T10:51Z

Head 024bef861932 (read from the PR object), after one seat REWORK.

Shape. Draft on main; Fixes #25874; Clause-②: no, Metadata-protocol: none; changeset .changeset/25874-form-refusal-no-field-toast.md in the root .changeset/ (patch, components + i18n).
Checks pinned to the head. Every suite on 024bef86 is green, including Lint & Repo Gates, TypeScript Type Check, Test Core, Lint UI, Type Check UI, Build & E2E UI and Check Changeset. The one red in the timeline (the SDUI manifest step) was on the intermediate head 32a5792b, before the re-record.
Governed surface. check-governed-merges.mjs --pr 26040: 0 of 8 paths governed at the first head. The rework adds the locale packs, none of them governed.
Fix, route (c) as ruled. announceFieldErrors no longer toasts. It reveals and focuses the first invalid field in declared order, and activates that field's background tab first. A server-rejected field with no drawn input (a predicate-hidden tab or section) falls through to the existing form-level banner, so its message is still said. A client refusal now retires the previous outcome (banner, toast, clear-on-hide notice) explicitly, because no refusal toast supersedes it any more. Both deviations are declared in the os-dev-report.
Seat REWORK, done. validation.formInvalid was dead once the toast went. It is removed from the default map and all ten packs; formInvalidJoiner stays for its three readers. The stale notice comment is updated. check-i18n-dead-keys exits 0. PR body bullets corrected by the seat to match.
sdui record. components and i18n are in the registry closure, so the PR re-records registrySourcesSha256. It lands in the manifest-hash serial queue.

Landing: held for the serial queue (#25984 → #25987 → #25998 → #26045 → this). When its turn comes, the card thread merges origin/main and regenerates, and the seat arms auto-merge on that head.

… different packages stop conflicting (#26120)  _Requested by **Elon** · [project thread](https://claude.ai/code/project/chan_01WedDzV26nniwxv7jC88B9D?thread=cmsg_01WedDzV26nniwxv7jC88B9DPXV532seCFDcrkAJybGzsf)_ Fixes #26051 Clause-②: no Metadata-protocol: none Part of the p1 merge-queue backlog work (#26074). Dispatched by seat `domain:devx#1` (#6023), claim 6415558140, card-thread session `session_01SMJGPXxFBpbgAgXdnsXKVS`. ## What changes `scripts/sdui-manifest.record.json` carried ONE `inTree.registrySourcesSha256` over the `src/` of all 27 ui registry packages, so any two ui PRs that touched any registry package conflicted on that line. Now: - **One record per registry package**, one file each, one line each: `scripts/sdui-manifest.sources/PACKAGE.json` = `{"package","sources","sha256","manifestSha256"}` (the package's own `src/` digest, its file count, and the sha256 of the artefact it was verified against). 27 files. - **The shared record** (`scripts/sdui-manifest.record.json`, same path) keeps only what describes the artefact: `sha256`, `components`, `generatedAt`, and `inTree` = `modulesRoot`, `objectuiWorkspaceVersion`, `registryRecords` (the directory). The retired `registryPackages` / `registrySources` / `registrySourcesSha256` are refused if they reappear. - **The reached package set** is the set of record files: a reached package with no record (new package, new dependency edge into the registry, deleted record) is RED; a record the registry no longer reaches (removed package, dropped edge) is RED. - `sdui.manifest.json` is byte-identical (sha256 `1f6e1ccb925a…`, 106 components). `lint.yml`'s command line (`node scripts/check-sdui-manifest.mjs --self-test && node scripts/check-sdui-manifest.mjs`) is unchanged and keeps working. No `.github/**` or `ui/.github/**` edit. ## Measured first (Ask 1): own `src/` per package, not dependency-inclusive Tree: objectstack `0a6948210c` (base), 27 reached packages, 922 non-test sources. **Detection is the same as one digest over the set.** Any edit under any reached package's `src/` moves exactly that package's digest, so a single PR's edit is caught exactly as before; a dependency's edit is caught through the dependency's own record. Dependency-inclusive digests add no single-PR detection. They would only add conflicts, and at this cost (records a `src/` edit would touch): | package edited | own `src/` (this PR) | dependency-inclusive | |:--|:-:|:-:| | `types` | 1 | 25 | | `core` | 1 | 21 | | `data-objectstack`, `i18n` | 1 | 19 | | `react`, `react-runtime`, `sdui-parser` | 1 | 18 | | `components` | 1 | 17 | | `fields` | 1 | 14 | | `plugin-detail` | 1 | 10 | | `plugin-form`, `plugin-grid` | 1 | 2 | | the other 11 plugins | 1 | 1 | **Merge experiment, real tree, `git merge-tree --write-tree` (no merge driver routes these paths; `git check-attr merge` = unspecified, so this is GitHub's answer):** each branch appends a comment to one `src/` file and runs the generator. | pair | before (single digest, on `0a6948210c`) | after (this PR, on `a8114011`) | |:--|:--|:--| | `plugin-grid/src/FormulaBar.tsx` × `plugin-form/src/DrawerForm.tsx` | exit 1, CONFLICT in `scripts/sdui-manifest.record.json` | exit 0, clean; the merged tree passes `check-sdui-manifest` (exit 0) | | `plugin-grid/src/FormulaBar.tsx` × `plugin-grid/src/ObjectGrid.tsx` | (conflicts) | exit 1, CONFLICT in `scripts/sdui-manifest.sources/plugin-grid.json` only, by design | **The open ui PRs today** (registry packages each changes, non-test `src/` only; none changes `sdui.manifest.json`): #25987 i18n, plugin-grid, plugin-list · #25998 plugin-detail · #26040 components, i18n · #26045 i18n · #26027 plugin-dashboard · #26030 plugin-grid · #26033 core, plugin-form, plugin-grid · #26042 plugin-form · #26044 i18n · #26048 i18n, plugin-map · #26050 fields, plugin-grid · #26062 fields. Under the single digest all 12 conflict pairwise (12 serial landings). Under this layout they conflict only within a shared package; the largest group is `i18n` (5 PRs), so they can land in 5 rounds, e.g. {#25987, #25998, #26027, #26042, #26062} → {#26040, #26030} → {#26045, #26033} → {#26044, #26050} → {#26048}, assuming no source-level conflicts between them. ## The check (Ask 2) `checkTreeWithoutPin` compares each reached package's digest with its own record and names every stale package (`ui/packages/plugin-grid: now 38 file(s) sha256 …, recorded …`), every unrecorded package, every record the registry no longer reaches, every record verified against another artefact, and every malformed record, then prints the one command: `node scripts/gen-sdui-manifest-node.mjs`. The pin mode (`.objectui-sha` present) is untouched. **Why `manifestSha256` is in every package record, and why one line:** a PR that changes the artefact re-records every package against the new sha256, so it still conflicts with every in-flight registry PR, which must regenerate on the merged tree (that is today's behaviour, kept for the case where it matters). Two PRs on the same package touch the same line and conflict. One line per file guarantees git cannot merge a digest from one side with an artefact sha256 from the other; a record that is not in the producer's one-line form is RED. **What this does not force, stated rather than implied:** two PRs on different packages that each leave the artefact unchanged, where only their combination would change it, land without any run seeing the combination. Under the single digest their textual conflict forced that run. Here the next regeneration of any registry package sees the combination. Dependency-inclusive digests would close this only along import edges (not between siblings that interact through `ComponentRegistry`), at the fan-out above. No stale or missing registry source passes: every source edit still reds until regenerated, and every package added to or removed from the reached set still reds. ## Self-test (Ask 3) 29 rows (was 22), roster and floor updated. New or changed in-tree rows: a staged edit to one package is RED naming that package and NOT naming `plugin-form` or `core`; a new package the registry reaches; a new workspace edge (now names `ui/packages/unrelated`); a removed package (names `scripts/sdui-manifest.sources/types.json`); a deleted package record; a record verified against another artefact; a record out of its one-line form; a record from the single-digest layout; and the producer re-recording only the moved package (it back-dates the shared record first, so a producer that stamps today's date reds the row). Ablations, one at a time through `scripts/ablation-replace.mjs`, each restored with `git diff HEAD` empty: | guard removed | self-test | |:--|:--| | the other-artefact comparison (gate) | exit 1, row "a package record verified against another artefact is RED" expected RED got GREEN | | the one-line form comparison (gate) | exit 1, row "a package record out of its one-line form is RED" | | the unreached-record list (gate) | exit 1, row "a removed registry package is RED naming its record" | | the `generatedAt` carry (producer) | exit 1, row "the producer re-records only the package whose sources moved": the second run changed the shared record too | | the per-package record write (producer) | exit 1, the two producer rows | ## The generator (Ask 4) It re-records only the packages whose line changed and leaves the others byte-identical; it removes a record the registry no longer reaches; it prints which packages it re-recorded. The shared record moves only with the artefact: `generatedAt` and the provenance version are carried while the artefact's sha256 is unchanged (the same rule the pin-keyed fields already follow), so a regeneration on another day no longer moves a shared line. **It still builds, and why:** the build plus the enumeration is the only oracle that says whether `sdui.manifest.json` moved. A record written without it would stamp a current digest on a manifest no run checked, which is the narrowing this card forbids. The 8 minutes is a cold turbo cache, not the build of one package. Measured on `0a6948210c`, one container, no remote cache (`TURBO_TOKEN` unset): | run | wall | turbo | |:--|:-:|:--| | cold | 8m49s | 0 of 63 cached, 8m43s | | nothing moved | 6s | 63 of 63 cached | | one edit under `plugin-grid/src` | 33s | 61 of 63 cached, 27s | | one edit under `core/src` | 2m50s | 41 of 63 cached, 2m44s | ## Readers moved (Ask 5) - `docs/releases-maintenance.md`: the regenerate section describes the per-package records, the re-record rule and which PRs still conflict. - `scripts/check-changeset-no-major.mjs`: the "measured out" comment, the real-build assertion (neither record is shipped) and the records-only control now cover `scripts/sdui-manifest.sources/`. Its `--self-test` passes (456 assertions). - `scripts/ui-import/README.md` is not edited: line 140 records what the cutover's step 4 wrote at the time, and that file still exists at that path. - `git grep -n "sdui-manifest.record"` outside CHANGELOGs: only the two scripts, the docs page, `check-changeset-no-major.mjs` and that historical README line. `git grep registrySourcesSha256`: only the retired-field list and its self-test row. ## After this lands: what an in-flight ui PR does (once) A ui PR whose branch re-recorded the old single digest conflicts once on `scripts/sdui-manifest.record.json`: ```sh git merge origin/main # conflict in scripts/sdui-manifest.record.json git checkout --theirs scripts/sdui-manifest.record.json # take main's layout node scripts/gen-sdui-manifest-node.mjs # re-records only this PR's package(s) git add scripts/sdui-manifest.record.json scripts/sdui-manifest.sources sdui.manifest.json git commit ``` After that, PRs on different registry packages no longer conflict with each other on the record. ## Gates Local, on `a8114011` (derived with `node scripts/pm/dispatch-gates.mjs --commands`): 39 of the 40 derived families exit 0, including `node scripts/check-sdui-manifest.mjs --self-test` (29 cases) and `node scripts/check-sdui-manifest.mjs`, `node scripts/check-changeset-no-major.mjs --self-test` and `--base origin/main`, `pnpm check:nul-bytes`, `pnpm check:watch-hint-literal`, `pnpm check:required-contexts`, `pnpm check:doc-authoring` and `pnpm --filter @objectstack/lint run check:doc-formula-expressions` (after the lint closure build). `pnpm check:pm-dispatch-gates` was still running when this PR opened; its reading goes into the report comment on #26051, and CI runs it in Lint & Repo Gates. CI on the PR's check-runs: pending at the time of writing; the seat reads them. Changeset: none, `skip-changeset`. The diff touches only root `scripts/` (private), `docs/` and the records; `sdui.manifest.json` is byte-identical and neither record is copied into `packages/console/dist/` (the `check-changeset-no-major` real-build assertion above). Not Tier H: no governed path (`git diff --name-only` has no `.github/`, `.claude/`, `docs/adr/`, `skills/`, `AGENTS.md`, `CLAUDE.md`). ## Acceptance notes - `i18n` is the hot package: 5 of the 12 open ui PRs touch its `src/`, so they still serialize on `scripts/sdui-manifest.sources/i18n.json`. Whether locale data belongs in the digest at all is a narrowing question (it would let a source change pass unregenerated), not something this PR decides. - The cold-cache cost of a regeneration (8m43s here) is a fresh-container property; card threads run with no turbo remote cache. --- _Generated by [Claude Code](https://claude.ai/code/session_01SMJGPXxFBpbgAgXdnsXKVS)_ --------- Co-authored-by: Claude <noreply@anthropic.com>

os-steve · 2026-10-26T16:47:28Z

Seat domain:ui#1: closing as superseded. This change landed folded into the i18n batch #26158 (merged 2026-10-26T16:46:30Z as 326a559), which carries this branch's commits verbatim.

Generated by Claude Code

claude added 5 commits October 26, 2026 09:10

fix(components): a client-side refusal retires the previous outcome b…

ab645af

…anner and toast Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

chore: changeset and sdui manifest record for the form refusal change

60aa2b4

Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into claude/project-thread…

451d710

…-eprqgc # Conflicts: # scripts/sdui-manifest.record.json

chore: re-record the sdui manifest hash after merging main

cb3fe1a

Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

objectstack-fleet Bot assigned os-steve Oct 26, 2026

github-actions Bot added size/m documentation Improvements or additions to documentation tooling labels Oct 26, 2026

objectstack-fleet Bot mentioned this pull request Oct 26, 2026

devx(sdui): split scripts/sdui-manifest.record.json into one record per ui registry package, so ui PRs that touch different packages stop conflicting in the merge queue #26051

Closed

claude added 2 commits October 26, 2026 10:21

fix(components,i18n): drop the now-unread validation.formInvalid key …

32a5792

…and bring two comments in line Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

chore: re-record the sdui manifest hash

024bef8

Claude-Session: https://claude.ai/code/session_01CzUs1oNtFWhWUXT7rmoGy2 Co-authored-by: Claude <noreply@anthropic.com>

os-steve closed this Oct 26, 2026

os-steve mentioned this pull request Oct 26, 2026

record create / edit dialog: a failed submit shows a summary banner ("请检查表单中标记的字段:名、姓、公司...") over the dialog title and the same messages under each field — one of the two, placed clear of the title #25874

Closed

Navigation Menu

Repository navigation

fix(components): a refused submit focuses the first invalid field instead of toasting the field list over the dialog title - #26040

fix(components): a refused submit focuses the first invalid field instead of toasting the field list over the dialog title#26040
objectstack-fleet[bot] wants to merge 7 commits into
mainfrom
claude/project-thread-eprqgc

objectstack-fleet Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

objectstack-fleet Bot commented Oct 26, 2026

Uh oh!

os-steve commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

objectstack-fleet Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes

Tests

Acceptance notes

Uh oh!

objectstack-fleet Bot commented Oct 26, 2026

席位核对 · ACCEPT · seat domain:ui#1 · 2026-10-26T10:51Z

Uh oh!

os-steve commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

objectstack-fleet Bot commented Oct 26, 2026 •

edited

Loading

席位核对 · ACCEPT · seat `domain:ui#1` · 2026-10-26T10:51Z