Repository navigation
test(formula): pin the refused direction of the hole placement scan's tag-open and script escape corrections (#25351) - #25730
Merged
Conversation
… tag-open and script escape corrections (#25351) Two rows in the class-by-class refused table: a hole in a tag that opens right after a character the tag open state reconsumes answers `tag`, and a hole after an end tag in a script's double-escaped text answers `raw-text-element`. Each row goes red with its correction reverted. Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
hotlong
marked this pull request as ready for review
October 25, 2026 02:40
hotlong
enabled auto-merge
October 25, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25351
The maintainer's action on #25351, written under the maintainer's delegation in chat: two refused-direction rows in the class-by-class refused table of
packages/formula/src/mail-html-hole-placement.test.ts, one per scan correction of86330c090(PR #25212), as contract review6342085020③ asked. Test-only: no change to the classifier, the rule, its doors or the renderer.Per the card's disclosure rule, this body names each row by class only; the samples live in the test source.
The two rows
tagand is refused.raw-text-elementand is refused.Both rows were built from the HTML Living Standard's tokenizer section (the tag open state; the script data escaped and double escaped states).
Ablation (local, against the classifier at this PR's base)
Each correction of
86330c090inpackages/formula/src/mail-html-hole-placement.tswas reverted on its own, the file run, and the correction re-applied; the file was byte-identical to the base after each restore.tagrow added heretag, receivedelement-textraw-text-elementrow added hereraw-text-element, receivedelement-textWith both corrections in place: 48 of 48 pass in this file.
Verification
packages/formula:vitest run, 53 files and 1424 tests pass;pnpm typecheck(includingcheck:test-typecheck) passes.eslinton the changed file: clean.Declarations
Clause-②: no
Metadata-protocol: none
Test-only, so no changeset: the diff publishes nothing from any released package, and this PR carries
skip-changeset, as the card's acceptance states.Generated by Claude Code