Repository navigation
docs(adr): ADR-0138 dated note — D5 is built for the public form doors - #25644
objectstack-fleet[bot] wants to merge 2 commits into
Conversation
Claude-Session: https://claude.ai/code/session_01KzNShz7MFV7SFobNr9FWFf Co-authored-by: Claude <noreply@anthropic.com>
…es not hold yet Claude-Session: https://claude.ai/code/session_01KzNShz7MFV7SFobNr9FWFf Co-authored-by: Claude <noreply@anthropic.com>
|
The red
The Tier H path is unchanged: the maintainer merges this PR after #25641. Generated by Claude Code |
维护者速读改了什么 为什么改 风险与代价(含回滚) 席位意见 你要做的 席位核对Tier H · #25574 (ADR note) ·
Edited 2026-10-24T13:05Z: item 1's Generated by Claude Code |
|
Ruling: #25574 re-ruled A · maintainer 「25447 A」 2026-10-24T16:06:19Z · record #25574 comment 6386464761 D5 不建,本说明不再成立:本 PR 不合并,请 spec 席经 relay 关闭(分支保留)。 Generated by Claude Code |
|
Closed unmerged · Generated by Claude Code |
Refs #25574
Adds a dated note to ADR-0138 recording that D5 ("the public-site binding: shape only, built when demand arrives") is now built for the public form doors, by #25641, and the shape it took. Only
docs/adr/0138-guest-model-anonymous-principal-doors-grants-and-organization.mdchanges; no changeset (docs/adr/**publishes nothing). #25574 stays open on this PR; the code PR #25641 carries its closing keyword.What the note says
· **Note** (2026-10-24, ruling B on #25447, 6377889413, maintainer 「#9 同意」; card #25574), pointing at the note under D5; every other decision of the record is unchanged.sharing.organizationson the form, by slug, named by the link's?organization=parameter; a missing or unlisted organization is answered as an unpublished form, with no fallback to the default organization; the guest grants are unchanged (the form grant, now resolved under the bound organization; no set bound toguest); the allowed doors are the two public form doors only, and the class 4/5 endpoint doors keep D4's located refusal.Gates
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackat4512b4bb8derived 20 commands; all 20 run, each exit captured before any pipe, all exit 0;--ranreconciles "20 derived famil(ies) accounted for — 20 run, 0 NOT-MEASURED (a DERIVED zero)". The first run ofcheck-adr-symbol-anchors.mjsexited 1 on a path anchor topackages/core/src/security/public-form-organization.ts, a file only #25641 adds; the note names that decision by its export instead.check:doc-formula-expressionsfirst refused with a prerequisite (@objectstack/formulaand@objectstack/lintunbuilt in this fresh worktree); after building both it exited 0.维护者速读(草稿)
改了什么
ADR-0138 加一条带日期的说明:D5("公共站点绑定:只定形状,有需求时再建")已经为公共表单建成,由 #25641 实现。说明记录了建成后的样子:表单上声明它发布到哪些组织(按组织 slug),链接带上组织(
?organization=),提交落进链接点名的那个组织、用那个组织自己的编号。只改这一个 ADR 文件,不改代码。为什么改
裁决 B(#25447 评论 6377889413,维护者「#9 同意」)要求实现 D5。代码在 #25641 里落地;ADR 原文仍写着"只定形状、什么都没声明",不加这条说明,记录就和代码对不上,下一个读 ADR 的人会以为这个能力不存在。
风险与代价(含回滚)
只是文档,不影响运行时。风险在于时序:如果 #25641 没合或被回滚,这条说明就会描述一个不存在的能力,所以建议在 #25641 合并之后再合本 PR。回滚:直接 revert 本 PR 即可,不牵连其他文件。
席位意见
你要做的
在 #25641 合并后,审阅并批准合并本 PR。
Generated by Claude Code