Repository navigation
fix(release): revert the red 18.1.0 version commit and fix the dogfood proof that reddened it - #25605
Conversation
…25549 words #25591 (#25549) made a public object's share row reachable by an external member of the record's organization, so SharingService.grant's refusal on a public object now names the recipient's standing. The showcase D3/D4 proof still pinned the pre-#25549 sentence and failed the Dogfood Regression Gate on main from a57643d, which refused the 18.1.0 release at its version commit. Claude-Session: https://claude.ai/code/session_014C7q5Hm34g4EPdirar9SzN Co-authored-by: Claude <noreply@anthropic.com>
This reverts commit 74fa3cb. The 18.1.0 publish was refused at that version commit: its full battery is red (Dogfood Regression Gate, the showcase D3/D4 proof pinning the pre-#25549 refusal sentence), and the release gate reads only runs at or before the version commit, so no re-run on it can go green. Reverting restores the 265 changesets it consumed, including the five that landed after the Version Packages PR was generated (#25591, #25592, #25596 and two patches), so the regenerated Version Packages PR versions 18.1.0 again from a tree whose battery can be read green, with a changelog that names everything it ships. Nothing was published: npm still has 18.0.0 and no 18.1.0 tag exists. Claude-Session: https://claude.ai/code/session_014C7q5Hm34g4EPdirar9SzN Co-authored-by: Claude <noreply@anthropic.com>
📓 Docs Drift Check
What this run could not see
Coarse fallback — 175 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
|
The level axis reads the This PR's own changes release nothing: a dogfood test in a private package, plus package versions going back to 18.0.0. Declaring Generated by Claude Code |
…-pluvu5 One conflict, in showcase-d3-d4-capabilities.dogfood.test.ts: #25605 loosened the same contrast to the prefix "consulted only for an external member" on the absent record. Kept this branch's side, which grants on a real showcase_project to a staff member of its organization and pins "and the recipient is not one". Main's other incoming change (#25607) is scripts/release-pending-publish.mjs only. Claude-Session: https://claude.ai/code/session_014rFBGqoBLiroi35e82xEa7 Co-authored-by: Claude <noreply@anthropic.com>
Clause-②: no
Metadata-protocol: none
Release fix for 18.1.0. The maintainer chose to revert the version commit and re-cut 18.1.0. This pull is the one landing the merge freeze lets through.
What happened
74fa3cb6dat 04:58Z. Its release run (40064441171) was refused byFull battery green at the version commit. The reason: the newest full-battery run at or before it, the 04:01Z hourly run 40060651935 ona57643d3d, concludedfailure.showcase-d3-d4-capabilities.dogfood.test.ts("[app-showcase: two sharing rules declared on objects without record sharing enabled — boot backfill fails, rules never take effect #9237] the grant the rule reconciles is one the gates CONSULT") still matched the pre-sharing: a share or sharing rule to an external member is refused as inert on a public_read_write or model-less system object, though the external OWD floor would consult it #25549 sentence'showcase_project' is not under record-sharing enforcement. feat(sharing): a share or sharing rule on a public object reaches an external member of the record's organization #25591 (sharing: a share or sharing rule to an external member is refused as inert on a public_read_write or model-less system object, though the external OWD floor would consult it #25549) changedSharingService.inertGrantReasonon purpose: on a public object a share row is now consulted for an external member of the record's organization. The refusal therefore names the recipient's standing: "has a public sharing model, so a share row on it is consulted only for an external member of the record's organization, and that organization could not be resolved".main. The push and 05:00Z hourly runs on74fa3cb6ditself fail the same way.74fa3cb6dgreen. A new version commit is needed.The diff
test(dogfood): the contrast now matches the public-OWD sentence sharing: a share or sharing rule to an external member is refused as inert on a public_read_write or model-less system object, though the external OWD floor would consult it #25549 writes, up to "consulted only for an external member". The object and the code stay asserted, and a comment records why the wording moved. Locally,vitest run test/showcase-d3-d4-capabilities.dogfood.test.tsinpackages/qa/dogfoodgives 5 passed (5).Revert "chore: version packages (#24876)": a plaingit revert 74fa3cb6dwith no conflicts. Every package version goes back to 18.0.0, and the 265 changesets it consumed come back.minor, semantic), fix(plugin-approvals)!: refuse a reassign target that resolves to no one #25592, feat(core): import reads dotted and compact year-first days and matches option values in any case #25596 and two patches. Their code is in74fa3cb6d's tree.Nothing was published.
npm view @objectstack/cli versionstill answers 18.0.0, and no 18.1.0 tag or GitHub Release exists.After it lands
release.yml,refresh_version_pr: true) regenerates the Version Packages PR.releasedeployment onceFull battery green at the version commitreads the new version commit green.Out of scope
No product code,
content/docs/releases/, or workflow changes. The 18.1 release page (#25460, #25553, #25590) already describes 18.1.0.🤖 Generated with Claude Code