Skip to content

refactor(plugin-auth): move the createAuthInstance body into auth-manager-auth-instance.ts (#25224 cut 14) #25566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Oct 24, 2026
+926 −749
Merged

refactor(plugin-auth): move the createAuthInstance body into auth-manager-auth-instance.ts (#25224 cut 14) #25566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/plugins/plugin-auth/src/auth-email-locale.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,8 +858,9 @@ describe("#14641 — an invitation reads the INVITEE's own sys_user.locale", ()
*
* ⚠️ POPULATION of the class claim these blocks close, stated rather than
* implied: the auth mail surface is the five `sendTemplate` call sites in
* `auth-manager.ts` and `auth-manager-email-sms-delivery.ts` (the body of the
* change-email notice) — `IEmailService` declares exactly two delivering
* `auth-manager.ts`, `auth-manager-auth-instance.ts` (the body of
* `createAuthInstance`) and `auth-manager-email-sms-delivery.ts` (the body of
* the change-email notice) — `IEmailService` declares exactly two delivering
* members (`send`, `sendTemplate`), plugin-auth's only `.send(` calls are the
* SMS service's, and no other file under `plugin-auth/src` calls either.
* Those five are the same five `driveAllFive` above drives and `TEMPLATES`
Expand Down Expand Up @@ -1122,9 +1123,9 @@ describe('#15106 — the CLASS claim: all five auth sends read the recipient col
});

it('every one of the five sends is written in the stored language of its own recipient', async () => {
// ⚠️ POPULATION: the five `sendTemplate` sites in `auth-manager.ts` and
// `auth-manager-email-sms-delivery.ts` — the same five `driveAllFive`
// drives and `TEMPLATES` names, and the whole of
// ⚠️ POPULATION: the five `sendTemplate` sites in `auth-manager.ts`,
// `auth-manager-auth-instance.ts` and `auth-manager-email-sms-delivery.ts`
// — the same five `driveAllFive` drives and `TEMPLATES` names, and the whole of
// plugin-auth's mail surface (see this section's header). This is the pin
// that closes the class; the per-send pins above only cover one member.
//
Expand Down
Loading
Loading