Skip to content

refactor(plugin-auth): move AuthManager's email and SMS delivery into auth-manager-email-sms-delivery.ts (#25224 cut 5) #25395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Oct 23, 2026
+527 −332
Merged

refactor(plugin-auth): move AuthManager's email and SMS delivery into auth-manager-email-sms-delivery.ts (#25224 cut 5) #25395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/plugins/plugin-auth/src/api-error-code.pin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ describe('every new APIError( in plugin-auth/src carries an ADR-0112 code (#2424
'auth-manager-actor-guards.ts',
'auth-manager-sign-in-lockout.ts',
'auth-manager-password-session-policy.ts',
'auth-manager-email-sms-delivery.ts',
];
expect(sites.length).toBeGreaterThanOrEqual(30);
expect(new Set(sites.map((s) => s.file)).size).toBeGreaterThanOrEqual(4);
Expand Down
15 changes: 9 additions & 6 deletions packages/plugins/plugin-auth/src/auth-email-locale.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,10 +858,12 @@ describe("#14641 — an invitation reads the INVITEE's own sys_user.locale", ()
*
* ⚠️ POPULATION of the class claim these blocks close, stated rather than
* implied: the auth mail surface is the five `sendTemplate` call sites in
* `auth-manager.ts` — `IEmailService` declares exactly two delivering members
* (`send`, `sendTemplate`), plugin-auth's only `.send(` calls are the SMS
* service's, and no other file under `plugin-auth/src` calls either. Those
* five are the same five `driveAllFive` above drives and `TEMPLATES` names.
* `auth-manager.ts` and `auth-manager-email-sms-delivery.ts` (the body of the
* change-email notice) — `IEmailService` declares exactly two delivering
* members (`send`, `sendTemplate`), plugin-auth's only `.send(` calls are the
* SMS service's, and no other file under `plugin-auth/src` calls either.
* Those five are the same five `driveAllFive` above drives and `TEMPLATES`
* names.
* Before this change four of them read the column and `sendMagicLink` did not;
* `the whole surface reads it` is pinned below by driving all five against one
* recipient-keyed engine, not by asserting it about this send alone.
Expand Down Expand Up @@ -1120,8 +1122,9 @@ describe('#15106 — the CLASS claim: all five auth sends read the recipient col
});

it('every one of the five sends is written in the stored language of its own recipient', async () => {
// ⚠️ POPULATION: the five `sendTemplate` sites in `auth-manager.ts` — the
// same five `driveAllFive` drives and `TEMPLATES` names, and the whole of
// ⚠️ POPULATION: the five `sendTemplate` sites in `auth-manager.ts` and
// `auth-manager-email-sms-delivery.ts` — the same five `driveAllFive`
// drives and `TEMPLATES` names, and the whole of
// plugin-auth's mail surface (see this section's header). This is the pin
// that closes the class; the per-send pins above only cover one member.
//
Expand Down
Loading
Loading