Repository navigation
docs(os-dev): name the harness attribution-line exemption in 〈干净收尾〉; Check Changeset reads the PR body - #25393
Conversation
…Check Changeset reads the PR body One exemption line under the HTML-comment ban: the harness-written attribution comment on PR body line 1 stays as given and is reported; `Fixes #<n>` follows it; every HTML comment the dev writes itself stays banned. Paid by dropping the cdn.playwright.dev 403 line (moot under the no-`playwright install` rule above it). The changeset-line rule now says `Check Changeset` reads the two declaration lines off the PR body (check-changeset-no-major.mjs declarationFromPullRequest); the changeset-body copy is AGENTS.md Post-Task Checklist ③'s publishing rule. Net zero lines; ceiling 404 untouched. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01REMuzhz6MWRjg8uohedMnM
Contract reviewServed-tier: Written 2026-10-23T07:08Z. Review of draft PR #25393 (Fixes #25220) against ① Derived judgmentsFace: governed rules text ( (a) The exemption line, 〈干净收尾〉 L323 (new, 118 bytes): 「- 例外:harness 自写的 PR 正文首行归属注释原样留、只报;
(b) The changeset-line reword, L280 (in place, 111 bytes): old 「- 两行同抄进每个 changeset 正文行首,
(c) The payment line, Toolchain traps L128 (deleted, 111 bytes): 「-
Ratchet and lints: ceiling map PR form: draft, base ② Semver level
③ Boundary flags
Implemented-by: VERDICT: PASS |
席位核对ACCEPT · Landing authority: the maintainer's own words in this seat's thread of the Claude Code project "Objectstack" (
Generated by Claude Code |
Fixes #25220
Clause-②: no
Metadata-protocol: none
.claude/agents/os-dev.mdonly, net zero lines (404 → 404; ceiling 404 untouched). One exemption line under 〈干净收尾〉's HTML-comment ban: the harness-written attribution comment on PR body line 1 stays exactly as the harness gives it and the dev reports it;Fixes #Nthen sits on the first line after it; every HTML comment the dev writes itself stays banned. Paid by deleting thecdn.playwright.dev403 line (moot under theplaywright installban directly above it). Carry-over from PR #25240's contract review: the changeset-line rule now saysCheck Changesetreads the two declaration lines off the PR body (scripts/check-changeset-no-major.mjsdeclarationFromPullRequest,readClause2Line(pr.body)/readMetadataProtocolLine(pr.body)); the changeset-body copy is AGENTS.md Post-Task Checklist ③'s publishing rule (check:adr-0087-registrationreads it there). Every changed line is ≤120 bytes; no re-wrap.维护者速读(草稿)
改了什么:
os-dev.md两处。① 〈干净收尾〉HTML 注释禁令下加一行例外:harness 自写的 PR 正文首行归属注释原样留、只报;Fixes #N紧随其后;dev 自写的 HTML 注释仍禁。② 「两行同抄进 changeset 正文行首」一行改为写明Check Changeset读的是 PR 正文。为付行数,删掉 Toolchain traps 里cdn.playwright.dev403 那一行(上一行已禁playwright install,该情形不再出现)。为什么改:项目线程的 harness 要求 PR 正文第一行是一条 HTML 注释归属行,与 os-dev.md 的 HTML 注释禁令必然冲突,此前每张卡都只能记一条 deviation。② 来自 PR #25240 的合同复核:门禁实际读 PR 正文(
check-changeset-no-major.mjs),原句写成读 changeset,会误导。风险与代价(含回滚):仅规则文本,不发布、不改脚本。风险是删掉的 403 一行所载的教训丢失(被上一行规则覆盖)。回滚 = revert 本 PR 一个 commit。
席位意见:
你要做的:席位的
CONTRACT_REVIEW_TIERPASS 落在本 head 之后,一句「objectstack-ai/objectstack#N 可以落地」(N 为本 PR 号)。Gates
Derived with
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackatfc7b53ff(20 commands); all 20 ran on the working tree that becameda46daf, each exit code captured before any pipe;--ranreconciliation: 20 derived, 20 run, 0 NOT-MEASURED, 0 UNRUN. All exit 0, includingpnpm check:pm-skill-ratchet(os-dev.md is 404 lines (ceiling 404; headroom 0)) andpnpm check:pm-skill-id-lint.check:doc-formula-expressionsexit 0 (no prerequisite build needed). CI-only families (type-check lanes, wide-population and roster families) are read off this PR's check-runs.🤖 Generated with Claude Code
https://claude.ai/code/session_01REMuzhz6MWRjg8uohedMnM