Repository navigation
chore(console): move the objectui pin 0d12e95361b2 → 5fef032b1ada, so the 18.1.0 console makes one request per open for a nav entry and a page element bound to the same read - #25358
Merged
Conversation
…5353) Written by scripts/bump-objectui.sh 5fef032b1ada --no-commit: the pin file and the console changeset the digest derived over the range. Claude-Session: https://claude.ai/code/session_01RVrmCeThcAT38hSxtChLz4 Co-authored-by: Claude <noreply@anthropic.com>
…er lockstep at 5fef032b1ada (#25353) pnpm objectui:build, then node scripts/gen-sdui-manifest-node.mjs (107 components, sha256 d1fde278ffd6, unchanged: only the provenance record moves), and pnpm gen:sdui-lockstep (only rev, revDate and recordedAgainstPin move). Claude-Session: https://claude.ai/code/session_01RVrmCeThcAT38hSxtChLz4 Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift Check
What this run could not see
Coarse fallback — 3 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Fixes #25353
Clause-②: no
Metadata-protocol: none
This PR moves the console pin from
0d12e95361b2to5fef032b1ada: objectuimainat5fef032b1ada5b86bad640637e7331e26ee5da6e, its tip when this PR was opened. It is the pin move the maintainer's 18.1.0 ruling puts before the release cut ("卡 5 同意", 5a-B): move the pin first, then cut 18.1.0. With it, the 18.1.0 console carries objectui#13323: a navigation entry's APIdataSourceand a page element bound to the same read make one request per console open instead of two.Branch name: the harness assigned
claude/project-thread-wyb8o7, not the repo'sclaude/issue-25353-…convention; the card'sClaim:names this branch. No other open PR moves.objectui-sha.The diff
The same four files as the precedent pin moves #25262 and #25193. The repo's own tooling wrote each one; none was edited by hand.
.objectui-shaand.changeset/console-5fef032b1ada.md:OBJECTUI_ROOT=/home/claude/objectui OBJECTUI_NO_DEEPEN=1 bash scripts/bump-objectui.sh 5fef032b1ada5b86bad640637e7331e26ee5da6e --no-commit, exit 0. It printed "0d12e95361b2..5fef032b1ada walks completely", "1 releasing changeset(s), 0 breaking", "objectui declaredminor, recorded aspatch" and "(on origin/main)".scripts/sdui-manifest.record.json:pnpm objectui:build, thennode scripts/gen-sdui-manifest-node.mjs, exit 0. It reported 107 components and sha256d1fde278ffd6…, the same as at the old pin, so the trackedsdui.manifest.jsonis byte-identical and only its provenance record moves.node scripts/check-sdui-manifest.mjspasses at the new pin.packages/sdui-parser/objectui-lockstep.json:OBJECTUI_ROOT=.cache/objectui-5fef032b1ada pnpm gen:sdui-lockstep. It reported "214 region line(s), blob 0131f27cf86d, 25 diagnostic code(s)". Onlyrev,revDateandrecordedAgainstPinchanged, andpnpm check:sdui-locksteppasses.One build note: the first
pnpm objectui:buildin this container died withJavaScript heap out of memoryin@object-ui/app-shell'stsc(node's default heap, 2 GB). It was re-run withNODE_OPTIONS=--max-old-space-size=6144and finished with "dist ready … from objectui@5fef032b1ada"; the manifest was regenerated from that complete build.The changeset
scripts/objectui-changeset-digest.mjsderived it from the changesets objectui added over the range. Under ruling A (#25105) a console refresh ispatchwithMetadata-protocol: none, whatever objectui declared. objectui declaredminorhere (the newElementApiOpenScope/useElementApiOpenexports of@object-ui/react), and the digest recordedpatch.The range holds two non-merge objectui commits: objectui#13328 (
b911ebb4e, the objectui#13323 fix) and objectui#13329 (5fef032b1, a CI gate fix that carries a release-nothing changeset).Choosing the pin
5fef032b1adais objectuiorigin/main's tip, and0d12e95361b2is its ancestor. objectui CI on5fef032b1ada, read when this PR was opened:success.CI39840220761:failure, on itsTestaggregation job alone. All 16 test shards concludedsuccess; the gate read shard 15/16 (job 120038970141, completedsuccessat 19:35:14Z) as stillin_progressfrom the jobs API for its whole re-read window (19:39–19:45Z) and refused. That stale-read class is exactly what objectui#13329, the commit pinned here, fixes.CIon the same sha, after that run: 39872395655, 39881943452 and 39885608893, allsuccess.Spot-check of objectui#13323 on the built console
Verdict: PASS. One
GETper console open for a nav entry and a page element bound to the same read, and the element draws that answer.Setup: this branch at
67d8b675, framework built (pnpm build --concurrency=2, 76/76 tasks), console built at the pin (packages/console/dist/.objectui-sha=5fef032b1ada5b86bad640637e7331e26ee5da6e). Stockexamples/app-showcasebooted withpnpm dev -- --fresh -p 38517and signed in as the seeded admin; headless Chromium (Playwright 1.63) drove it and counted every request to the probe URL. The showcase declares no API-bound nav entry, so a throwaway fixture added two lines to the working tree for the run and was restored afterwards (git statusclean, nothing committed):nav_probe_13323, first inshowcase_app's navigation:type: 'page',pageName: 'showcase_contact_form',visible: 'data.total >= 0',dataSource: { provider: 'api', read: { url: '/api/v1/data/showcase_inquiry' } };showcase_contact_form, anelement:textwith the samedataSourceand contentPROBE total=${data.total}.GET /api/v1/data/showcase_inquiry/_console/apps/showcase_app(the landingreplaces onto the probe page)…/page/showcase_contact_formPROBE total=3…/page/showcase_contact_formPROBE total=3PUSHto Capability Map through the nav…/page/showcase_capability_mapPOP, a new open)…/page/showcase_contact_formPROBE total=3The nav gate needs the read to draw the entry and the element needs it to draw
3; both drew on one request in A, B and D, so the element took the answer the nav read already held. D reads again, as objectui#13323 specifies for aPOP. Not run here: a control at the old pin (the two-request baseline), which objectui#13328's own ablations cover.Out of scope
.github/workflows/**,scripts/build-console.shorcontent/docs/releases/is in the diff. This PR is not a release act and does not touch the Version Packages PR chore: version packages #24876, which the release seat refreshes after this lands.🤖 Generated with Claude Code
https://claude.ai/code/session_01RVrmCeThcAT38hSxtChLz4
Generated by Claude Code