Repository navigation
docs(adr): ADR-0131 18.x notes, review precision (B1–B3, B6) and the #25155 / #25179 citations (Tier H) - #25154
Merged
Merged
Conversation
…hipped, the storage residue's doors and refused class, the fixture-18.0.0 pin, the maintainer's words quoted Folds in the accuracy review's non-blocking findings B1, B2, B3 and B6 (record 6329955338 on #25149). Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQCyrGmMy6kwav9XCzAuQ9
Contributor
Author
⛔ 请先不要批准 · epic PM Do not approve this PR yet. It is unfinished.
|
This was referenced Oct 22, 2026
…r-0131-dated-notes
…on no-organization refusal Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQCyrGmMy6kwav9XCzAuQ9
This was referenced Oct 22, 2026
…r-0131-dated-notes
…migrate plan advisory Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQCyrGmMy6kwav9XCzAuQ9
Contributor
Author
维护者速读 · 请批准 · epic 席
|
os-zhuang
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24897
Clause-②: no
Metadata-protocol: none
A follow-up to #25149 (merged as
37ccd5f2cf). ADR text only, in one file:docs/adr/0131-total-organization-ownership-no-null-organization-id.md. Tier H (docs/adr/**).Both citations this PR waited on have merged, and the PR cites them (B4). It is complete and ready for the maintainer's one approval.
What changes
These are the non-blocking findings of the accuracy review of #25149 (contract review record 6329955338, PASS):
964a23700f) added thesharing_ruleactivation type and the same-name refusal, fix(spec,metadata-protocol)!: the /meta door no longer authors sharing rules; Setup lists declared sharing rules #24599 (1e8b6284c0) closed the/metadoor, and the D10 ceremony's clone migration is inpackages/cli/src/utils/organization-ownership-apply.ts.requireStartingOrganization: commit, chunk and chunked-completion before their first write, and progress when its expiry stamp is due (storage-routes.ts:992,:1166,:1308,:1416onorigin/main).os serve, because they ride the HTTP server that the production no-auth / no-secret refusals gate.81e6edd463), which held on every step-7 merge (record6323222024).ab488d9b7d, the fix for [Decision] A production os serve that composes no organization object (no auth secret, or no auth) still writes ownerless rows under --no-server: refuse that boot too, or refuse such writes in the engine everywhere #25133) shipped the production refusal. A productionos serve/os startthat composes no organization object is refused whether or not--server, before any plugin starts.6251f59051, the execution of [Decision] ADR-0131 D1 on stores already certified (18.0.0-born or ceremonied): an advisory for the voluntary ceremony plus a documented residue, or a shape-generation bump #25134) shipped theos migrate planadvisory. Each listed column is markedtightensorleaves, with the reason, and--jsoncarries it asnullableTenantColumns. The ceremony now reports a shard the driver created NOT NULL asalready-not-null. Item 3 (Order) cites fix(cli)!: refuse a production os serve that composes no organization object, --server or not #25155 too.6328195425) in the Status-line entry and in the D1 Amended note, and 「同意」 (6328987873) in the D9 note.Verification
check-adr-links,check-adr-anchorsandcheck-adr-symbol-anchorseach exit 0.dispatch-gates --ran: 20 derived, 20 run, 0 NOT-MEASURED, every command exit 0.node scripts/pm/check-governed-merges.mjs --branch origin/claude/issue-24897-adr-0131-dated-notes: GOVERNED, Tier H,docs/adr/**×1, 53 changed lines (+32 / −21) againstmainat6251f59051, at headfdfbe4965d.Acceptance notes
origin/mainafter docs(adr): ADR-0131 dated notes for the 18.x line — release scope, D1 as ruled, the D9 lean-embedding exception and its boundaries (Tier H) #25149 merged, keeping the same name. The old head had been deleted, so nothing was force-pushed.mainwas merged in twice with merge commits (cd6eb02236,eb6b796657), so the cited commits are ancestors of this head. There was no rebase and no force-push.skip-changeset).Generated by Claude Code