Repository navigation
test(cli): put serve-mcp-stdio-early-initialize's test-budget on the 10 s grid at its CI reading (#23181 slice 6) - #24494
Merged
Conversation
…10 s grid at its CI reading The header declared 15 s from a local timing, off the 10 s grid, so the shard-timings refresh diff refused it and every refresh carried no per-file regression readings. Re-measured from the refresh window's own per-file captures: slowest CI reading 14999 ms (run 39184708096, Test Core 3/6) x 1.25 = 18.75 s, rounded up to 20 s. Line 2 only; class unchanged. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SYEJqDL3NXxrJRBVqaMu9T
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
席位核对 — ACCEPT
Generated by Claude Code |
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #23181
Clause-②: no — basis: the diff is one header comment of a test file under
packages/cli/test/, outside@objectstack/cli'sfiles(dist,README.md,CHANGELOG.md); nothing ships, and no accept set or public surface moves.This puts line 2 of
packages/cli/test/serve-mcp-stdio-early-initialize.integration.test.tson the 10 s grid, at its CI reading. The header declared 15 s from a local timing, someasure-test-shard-timings.mjs --diffrefused it (readTestBudget: "the budget 15 s is not on the 10 s grid"). Because of that refusal, the weekly refresh PR #24467 (run 39205844620) reports "Regression readings: NOT MEASURED -- the diff refused (exit 1)" for every lane. Only line 2 changes. The class, the test body and every other file are untouched.The CI reading
scheduleruns. Its log reads "Accumulated 7 run(s): 39202368342 39197429467 39192681060 39188268133 39184708096 39178996284 39174682274", and its dataset (PR chore(ci): refresh the Test Core shard-timings dataset #24467 head1f11e11f0) names the same 7 inprovenance.runs. I downloaded all 42 of their per-file captures (test-core-timings-N-of-6, written byreport-test-timings.mjs --capture).readWindowCapturesandwindowFilesread the captures, with declarations not read. That takes the refusal out of the way without changing the script. The file executed in all 7 runs, none of them replayed, in projectintegrationon Test Core shard 3/6:Test Core (3/6)(job 117844650149), printstest/serve-mcp-stdio-early-initialize.integration.test.ts (1 test) 14999ms.2a1e48a1c1,725a5b1311) and at this branch's base4bd7215a1(git diff --quiet, exit 0 on each). The reading is a reading of this file.The arithmetic
SECONDS is the measured CI reading x 1.25 (
CEILING_HEADROOM), rounded up to the next 10 s (ruling records 6181973363 item 2 and 6212133431 item 2):14.999 s x 1.25 = 18.749 s, which rounds up to 20 s. That is above the 10 s line, so the file still owes a budget.
The CLASS is unchanged:
spawns the real producer once per single-cause fixture. The REASON keeps the producer description. It now names the reading, its run, and why the number rose, in the shape the spec lane's re-measured lines use: "re-measured 2026-10-19 over the 7 hourly runs that executed it (39174682274 to 39202368342, the window of shard-timings refresh run 39205844620): slowest CI reading 15.0 s (run 39184708096, 14999 ms) x 1.25, rounded up; rose from 15, which rested on a local reading and was off the 10 s grid".The census
I ran
readTestBudget, the script's own reader, over every tracked file whose text has a test-budget-shaped comment. The file list comes from agit grep -I -i -Ethat matches everything the script's attempt pattern matches, and more. Three trees:e11ae4b6b(the seat's census)4bd7215a1(this branch's base)c79774fe1(this branch)The seat's reading holds: this header was the only one off the grid. With this line, the refusal set is empty.
End to end. I re-ran the refresh's own
--diffin this worktree, on the same inputs:scripts/test-shard-timings.jsonatec951e29e, the refresh's base;The results:
4bd7215a1it exits 1, with the same refusal as run 39205844620's log.c79774fe1it exits 0 and reports "127 file(s) over budget (10 s, or the 20 declared)". This file is listed under "Held to the budget it declares" as "15.00 s of its 20 s".No changeset
skip-changesetis applied in the create stroke. The basis:packages/cli/test/, and@objectstack/cli'sfilesisdist,README.md,CHANGELOG.md.grep -rl -e serve-mcp-stdio-early-initialize -e test-budget dist README.md CHANGELOG.mdfinds 0 files, with 652 files indist.ignoreStdin, theservebehaviour this file pins, is found indist/commands/serve.js.Local verification (head
c79774fe1)--project integration, this one file): 1 file and 1 test passed, 13.76 s on a shared container.pnpm --filter @objectstack/cli typecheck: exit 0. That covers tsc and the test layer'scheck:test-typecheck.@objectstack/cliunit tier (--project unit --maxWorkers=2): 311 files and 4610 tests passed, exit 0.dispatch-gates.mjs --commands: 52 families, all exit 0. The three that readdist/passed after the build.--ranreconciliation: 52 run, 0 NOT-MEASURED, 0 UNRUN.pnpm lintand the CI check-runs for this head are reported in theos-dev-reportcomment on the card.Acceptance notes
These readings come from the same window. They belong to the card's rows, not to this PR, and are not changed here:
@objectstack/clifiles ran over the budgets they declare:src/commands/migrate/plan.declared-default-datasource.integration.test.ts: 93.22 s against its 80 s;test/start-stdio-stdout-purity.integration.test.ts: 20.30 s against its 20 s.test/start-mcp-stdio-early-initialize.integration.test.ts: 18.96 s, which gives 30;test/start-stdio-stdout-purity.integration.test.ts: 20.30 s, which gives 30.@objectstack/spec'ssrc/shared/alias-integrity.test.tsread 51.09 s against its 50 s. That is the spec lane's row.Generated by Claude Code