Skip to content

ci(spec-shape-gate): register #24442's row-patch retirement against objectui#13022 - #24492

Closed
objectstack-fleet[bot] wants to merge 1 commit into
mainfrom
claude/issue-24483-register-row-patch-retirement
Closed

objectstack-fleet[bot] wants to merge 1 commit into
mainfrom
claude/issue-24483-register-row-patch-retirement

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #24483

Clause-②: no

What

One entry in scripts/ci/spec-shape-retirements.json for objectstack PR #24442 (merge commit 69f342b92470e0b66aa9b17ccd2fc7db04e4e568), which retired a page action row's own patch with a retiredKey() tombstone. The downstream card is objectstack-ai/objectui#13022.

The pattern covers exactly one diagnostic. It is the TS2353 that Spec Shape Gate run 39206747055 (job 117911140691) reported as NEW:

field value
file packages/components/src/renderers/action/__tests__/action-button-undoable-11168.test.tsx
code TS2353
message the full text the gate printed for it (… 'status' does not exist in type …, on the row-patch tombstone)

The objectui line it covers is :64, patch: { status: 'done' }, on an action:button node with operation: 'update' (read at objectui main 47508f3bb). That is the row patch #24442 retired. objectui#13022 covers the renderers and the Undo snapshot that still read the row patch, and this test pins that same Undo path.

Evidence (local, at 04f90660e8)

  • pnpm check:spec-shape-gate (the reader's --self-test): 60/60 passed across 7 batteries, exit 0.
  • A probe that ran parseRegistry and classifyRows from the gate script over the committed registry gave these results:
    • The logged diagnostic reads known, entry objectstack-ai/objectui#13022.
    • A different code in the same file reads unknown.
    • The same TS2353 message in a different file (action-icon.tsx) reads unknown.
    • So the pattern is not wider than the one diagnostic.
  • node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 22 commands, and all 22 exited 0. The --ran reconciliation reads: 22 derived famil(ies) accounted for — 22 run, 0 NOT-MEASURED (a DERIVED zero …).

The registration's own gate run

This PR changes the registry, so the workflow's pull_request trigger runs Spec Shape Gate on it. That run is the proof the header asks for, and its verdict is reported in the os-dev-report comment on #24483. The card says fb0d85b7fb (#24458) also landed after run 39206747055. The same report says whether this run shows any other NEW diagnostic. No entry is added for one: this PR registers only the #24442 diagnostic, against the card that covers it.

Changeset

None. scripts/ci/** is not shipped by any package's files[], and the root package is private. This PR publishes nothing, so it carries skip-changeset, route 2 of the Check Changeset gate.


Generated by Claude Code

…ainst objectui 13022

One registry entry: objectstack PR 24442 (merge commit 69f342b) retired a
page action row's own `patch` with a retiredKey() tombstone, and objectui's
action-button Undo test still authors a row `patch`. The pattern names that
one file, TS2353, and the full tombstone message for the `status` key -- no
wider.

Claude-Session: https://claude.ai/code/session_01D6F9axfoPzR7t8G1J7Ytzz
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 19, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Review: ACCEPT · PR #24492 @ 04f90660e80aa3dced1c8e6d2403e80f892b0663 · domain:spec seat 3 · 2026-10-19T07:55Z

Session session_01D6F9axfoPzR7t8G1J7Ytzz · baozhoutao. Reviewer of record; checked against GitHub, not the report.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 19, 2026 07:56
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 19, 2026 07:56
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate, not merged. domain:spec seat 3 · baozhoutao · session session_01D6F9axfoPzR7t8G1J7Ytzz · 2026-10-19T08:23Z.

The registry entry this PR adds (PR #24442 against objectui#13022) is already on main: PR #24485 → ce2e08ee3b, landed 07:44Z, by the accepting seat's aftercare on #24394. This PR's diff was read three-dot against its merge base, which predates ce2e08ee3b, so the duplicate did not show at review. Merging it would put a second entry for PR #24442 in the registry. Auto-merge was disabled before close. My ACCEPT above is withdrawn. Overlap notice: 6262321210 on #24483.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants