Repository navigation
docs(forms): the sketch answers { id } and names form-routes.ts; re-point checklist item 14 anchor - #24159
Merged
objectstack-fleet[bot] merged 1 commit intoOct 17, 2026
Conversation
… checklist anchor
content/docs/ui/forms.mdx: the architecture sketch's submit answer read
{ object, id, record }; the submit route answers
res.status(201).json({ id: result.id }) in packages/rest/src/form-routes.ts,
as the same page's client example and response section already say. Its
"rest-server scans views" line now names form-routes.ts, where
resolveFormBySlug reads the environment's view list since the
registerFormEndpoints body moved there (c40a0dd). Columns unchanged.
docs/qa/platform-checklist/areas/access-security.json, item
access-security.public-form-withdrawal-layers: acceptance[0]'s verify
anchor re-pointed from rest-server.ts#registerFormEndpoints to
form-routes.ts#registerFormEndpoints; revision 3 with a history row.
Anchor only, no re-run owed.
Claude-Session: https://claude.ai/code/session_016PVjjuVPte5XEJvaQx1E4t
Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
席位核对 · ACCEPT · PR #24159 (draft, head
|
objectstack-fleet
Bot
deleted the
claude/issue-24128-form-routes-citations
branch
October 17, 2026 08:08
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24128
Clause-②: no
Two docs citations that the move of
registerFormEndpointsintopackages/rest/src/form-routes.ts(#24054, mergec40a0dd9c8) left stale, plus the sketch's submit answer from before #22437. Docs and checklist prose only: no product code, and no changeset, because nothing in any package'sfiles[]changes.1.
content/docs/ui/forms.mdx, the architecture sketch (the card)main(c40506aac):38← { object, id, record }← { id }packages/rest/src/form-routes.ts:538:res.status(201).json({ id: result.id });:30rest-server scans views →form-routes.ts scans views →packages/rest/src/form-routes.ts:178–:188:resolveFormBySlugbuilds thetype: 'view'request, callsp.getMetaItems(viewsRequest)and hands the list tofindPublicFormView(:128–:143):214–:217,{ "id": "r7p8cUZoBJbFWudt" }) and the client example (:270,return r.json(); // { id } — the created record's id only). The sketch was the one answer that disagreed.rest-server.tskeeps only a privateregisterFormEndpointsstub (:9107–:9125). It builds the host literal and callsregisterFormEndpoints.call(host, basePath). The scan itself is inform-routes.ts.:30stays at character column 59, the same column as on:31,:36and:37. The new label is 26 characters padded with 2 spaces; the old one was 23 padded with 5. The arrow on:38stays at column 27.2. Declared rider:
docs/qa/platform-checklist/areas/access-security.json, item 14 (access-security.public-form-withdrawal-layers)Source pointer: the
domain:clipointer on #24036, comment6227883776. It named this one sentence and the re-point owed.main(c40506aac)acceptance[0].verify(:1599)packages/rest/src/rest-server.ts#registerFormEndpoints reads the environment's view list alone and drops a candidate ...packages/rest/src/form-routes.ts#registerFormEndpoints reads the environment's view list alone and drops a candidate ...packages/rest/src/form-routes.ts:109:export function registerFormEndpoints(this: FormRouteHost, basePath: string): void {. The withdrawn candidate is dropped at:136:if (anonymousFormIntakeWithdrawnIn(views, view, c)) continue;revision(:1568)23historyrevision: 3,date: 2026-10-17,ref: #24128, naming the pointer as its sourcesource[2]already namedform-routes.ts#registerFormEndpoints, because refactor(rest): move registerFormEndpoints into form-routes.ts (#23050 slice 11) #24054 re-pointed that one. After this change the item citesrest-server.ts#registerFormEndpointszero times andform-routes.ts#registerFormEndpointstwice.qa-runrecord is written.Tests and gates (all on
d7e847a3e, this PR's head)node scripts/check-platform-checklist.mjs: exit 0,OK — 16 areas, 327 items ...; symbol anchors: 853/863 ...; 18 file floors held. Before the edit, onc40506aac, it read the same853/863.--anchor-censusgivesareas/access-security.json83 before and after, and the per-file census is identical.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 41 commands. All 41 ran, each with its exit code captured before any pipe, and all answered 0.--ranreports41 derived, 41 run, 0 NOT-MEASURED, 0 UNRUN.PREREQUISITE NOT MET, nothing measured).check:doc-formula-expressionsandcheck:doc-security-postureneeded@objectstack/lintand@objectstack/formulabuilt, andcheck:skill-examplesneeded@objectstack/clientand@objectstack/client-reactbuilt. Afterturbo run buildof those packages under the verify lock, each re-run answered exit 0.check:docsran afterpnpm --filter @objectstack/spec gen:schema, which writes the schema tree it reads.node scripts/pm/check-governed-merges.mjs --branch claude/issue-24128-form-routes-citations: exit 0,0 of 2 path(s) hit the register ... NOT governed. Size: 14 changed lines (+10 / -4).Build Docsjob and theTest Coreshards this path set schedules, and the type-check lanes (no TypeScript is touched).Acceptance notes
{ form, objectSchema }(:32) lists a subset. The route answersslug,object,label,formandobjectSchema(form-routes.ts:385–:391). Every key the sketch lists is present, so it misleads nobody. It is outside this card's surface and was not changed.check:platform-checklistkept accepting the old anchor through the private stub. That is how both citations stayed green after refactor(rest): move registerFormEndpoints into form-routes.ts (#23050 slice 11) #24054. Observation only.Generated by Claude Code