Repository navigation
docs(adr): ADR-0078 and ADR-0087 note the conversion-conflict channel's retirement - #24046
Merged
Merged
Conversation
…el's retirement Claude-Session: https://claude.ai/code/session_01WdZxJadrrYettvjrqiWeAV Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
维护者速读 · PR #24046(Tier H,
|
This was referenced Oct 16, 2026
os-zhuang
approved these changes
Oct 17, 2026
os-zhuang
marked this pull request as ready for review
October 17, 2026 00:29
os-zhuang
enabled auto-merge
October 17, 2026 00:29
Contributor
Author
|
Maintainer's word on the PR line · director seat (summon #43 continuation 3,
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24001 — the governed half (Tier H). The code half is the companion draft PR #24045 on
claude/issue-24001-conversion-conflict-retire, which carriesFixes #24001; this PR closes nothing.What this changes
Three lines under
docs/adr/, nothing else:docs/adr/0078-no-silently-inert-metadata.md— oneAmended 2026-10-16 (#24001), a citation retired — no decision changesline under Status: the ADR-0087 conversion layer's conflict channel, which cited this ADR's "never silent" rule for a flow-node rename refused over a live executor name, is retired with its last producer. Protocol 18 reserves the old callout node types (FLOW_RESERVED_NODE_TYPES), so the engine refuses such an executor at registration — this ADR's rule applied one step earlier. The completeness gate and every decision are unchanged.docs/adr/0087-metadata-protocol-upgrade-contract.md— one dated note closing the 2026-08-02 addendum: the conflict guard that addendum and the 2026-07-31 / 2026-08-01 ones describe is gone, and with itreservedNodeTypes/onConflict,ConversionConflictNotice/ConversionConflictDetail, theconflictsarrays and409 FLOW_CONVERSION_CONFLICT(D3 entryconversion-conflict-channel-removed). The historical text above it is left as recorded, per this repo's note-not-rewrite convention for ADRs.Why separate: the claim keeps every
docs/adr/**line out of the code PR, because one governed path makes the whole PR Tier H. The ADR-0087 registries (D2 conversions, D3 entries) live in code (packages/spec/src/conversions/,packages/spec/src/migrations/entries/), so the D3 entry rides the code PR.Placement note: PR #23986 (#23903) also adds a dated note to ADR-0087, after the 2026-10-16 #23775 note (~line 575). This note sits at the end of the 2026-08-02 addendum (~line 711), a different gap, so the two merge clean in either order.
node scripts/check-adr-anchors.mjson this branch: exit 0.维护者速读(草稿)
改了什么:只在两份 ADR 里各加了一条带日期的注记。ADR-0078 状态行下加一行"引用退役、决策不变";ADR-0087 在 2026-08-02 附录末尾加一条注记,说明"转换冲突通道"已整体退役。没有改动任何已有的决策文字。
为什么改:#24001 的代码 PR 删除了"转换冲突"这一整套已发布接口(冲突通知类型、两个转换选项、
conflicts数组和 409 错误码FLOW_CONVERSION_CONFLICT)。它唯一的触发来源——旧 HTTP 节点类型被第三方执行器占用时拒绝改名——在 #23543 F5-http 把三个旧名保留后已不可能发生。ADR 里仍描述着这条通道,读者(包括 AI)会以为它还存在,所以要留一条注记让文档跟上实现。风险与代价(含回滚):纯文档,无运行时影响。回滚即删除这三行。唯一需要留意的是与 PR #23986 同改 ADR-0087,但插入位置不相邻,任一先合都不冲突。
席位意见:
你要做的:代码 PR 通过合同复核后,批准本 PR(Tier H 需授权人工批准);若希望注记措辞或位置调整,直接在评论里指出即可。
🤖 Generated with Claude Code
https://claude.ai/code/session_01WdZxJadrrYettvjrqiWeAV
Generated by Claude Code