fix(rest)!: the /meta item and list reads serve a view stored with no label without an invented label

.changeset/23967-view-label-not-invented.md

@@ -0,0 +1,22 @@
+---
+'@objectstack/rest': minor
+---
+
+fix(rest)!: the `/meta` item and list reads serve a view stored with no `label` without the `label` the translator invents from its name
+
+Clause-②: no (narrowing)
+
+<!-- adr-0087: not-required (no-migration-prescription) No metadata moves: no spec key, authorable spelling, object definition or stored shape is added, removed, renamed or re-shaped, and no exported declaration is removed or narrowed, so there is nothing for `objectstack migrate meta` to rewrite. What changes is the document two `/meta` reads serve for a view whose stored row carries no `label`: it no longer carries one the serving layer made up. The stored row was never touched and is not touched now. The other categories are closed on facts: the package publishes (not unpublished); no ADR-0087 id is named or touched (not registered or already-registered); and nothing exported is removed or narrowed (not runtime-interface-only, type-surface-only or runtime-export-retired). -->
+
+**BREAKING** (a `/meta` read stops serving a value nobody authored), shipped as `minor` under the launch-window convention for breaking changes.
+
+A view's `label` is optional in the spec, with no default. When the translation catalog carried no string for a view, the read-side translator answered the view's own name, so a view stored without a `label` was served one: `GET /api/v1/meta/view/NAME` and `GET /api/v1/meta/view` returned `label: "OBJECT.KEY"`, on the standalone server and on the runtime dispatcher alike. The console drew that machine name as the view tab. The view-container read already dropped this value; the item read and the list read now drop it too.
+
+What a client reads now:
+
+- A view stored with no `label` is served with no `label` key, in every locale, with or without a translation catalog.
+- A view with an authored `label` is served that label, unchanged, including a label that happens to equal the view's name.
+- A catalog translation (`objects.OBJECT._views.KEY.label`) is still served, for a view with a `label` and for one without.
+- A read that resolves no locale is served the stored document as before, and the layered read (`?layers=true`) never carried the invented value.
+
+Who reads differently: a client that displays a served view's `label` now finds the key absent for a view stored without one, where it used to find the qualified name; it shows its own wording for such a view (the object's plural label, for example). The console's view tab falls back to the view's name on its own, so it keeps showing a machine name for such a view until its own fallback changes.

packages/rest/src/meta-item-read-gate.ts

@@ -2794,6 +2794,10 @@ export interface MetaListTranslationSources {
  * applies built-in fallbacks (the injected system-field labels on custom
  * objects). No locale is: nothing is translated then.
  *
+ * [#23967] A `view` element is served without the `label` the translator
+ * falls back to when the view stored none ({@link withoutInventedViewLabel}),
+ * the rule the item read and the container read apply.
+ *
  * `RestServer.translateMetaItems` delegates here, and the list chain
  * ({@link createMetaListAnswer}) runs it as its last step on both transports.
  */
@@ -2820,10 +2824,13 @@ export async function translateMetaList(
     const p = PACKAGED_BASE_ACCESSORS.has(metaType) ? await sources.resolveProtocol() : undefined;
     // `getMetaItems` elements are metadata documents (the list envelope is the
     // OUTER `{ type, items }`), so every element translates directly (#5563).
-    const translated = arr.map((item) => translateMetadataDocument(metaType, item, bundle, {
-        ...metaTranslateOptions(i18n, locale),
-        packagedBase: packagedObjectBaseOf(p, metaType, item?.name),
-    }));
+    const translated = arr.map((item) => {
+        const out = translateMetadataDocument(metaType, item, bundle, {
+            ...metaTranslateOptions(i18n, locale),
+            packagedBase: packagedObjectBaseOf(p, metaType, item?.name),
+        });
+        return metaType === 'view' && item && typeof item === 'object' ? withoutInventedViewLabel(item, out) : out;
+    });
     return Array.isArray(raw) ? translated : { ...raw, items: translated };
 }
 
@@ -2851,6 +2858,10 @@ export async function translateMetaList(
  * type `view` — the registry files a `defineView` container under the object
  * it binds and serves it on that key's by-name read — and the spec translator
  * the table dispatches `view` to reads a single view's `name`.
+ *
+ * [#23967] A single view is served without the `label` that translator falls
+ * back to when the view stored none ({@link withoutInventedViewLabel}) — the
+ * rule the container read and the list read apply.
  */
 export async function translateMetaDocument(
     sources: MetaListTranslationSources,
@@ -2878,10 +2889,11 @@ export async function translateMetaDocument(
     const packagedBase = PACKAGED_BASE_ACCESSORS.has(metaType)
         ? packagedObjectBaseOf(await sources.resolveProtocol(), metaType, (document as any)?.name)
         : undefined;
-    return translateMetadataDocument(metaType, document as any, bundle, {
+    const translated = translateMetadataDocument(metaType, document as any, bundle, {
         ...metaTranslateOptions(i18n, locale),
         packagedBase,
     });
+    return metaType === 'view' ? withoutInventedViewLabel(document as Record<string, unknown>, translated) : translated;
 }
 
 /**
@@ -2912,8 +2924,9 @@ export async function translateMetaDocument(
  *
  * A string the catalog does not carry is never invented: the translator falls
  * back to a view's `name` for a missing label, and that fallback is not a
- * translation ({@link projectViewTranslation}). With no bundle, nothing
- * changes and the SAME container is returned.
+ * translation ({@link withoutInventedViewLabel}, through
+ * {@link projectViewTranslation}). With no bundle, nothing changes and the SAME
+ * container is returned.
  *
  * Known limit: a container saved at runtime on ANOTHER package's object is
  * expanded by the metadata protocol under its own name (`<object>.<name>.<key>`),
@@ -3004,8 +3017,8 @@ async function translateMetaViewContainer(
  * lands on `target`, and so does every key it replaced in the view's `config`
  * (`bulkActionDefs`): an expanded view nests its whole list or form body under
  * `config`, and the slot IS that body. The expansion's own identity keys are
- * never copied. A `label` that equals `input.name` where `input` had none is
- * the translator's fallback, not a translation, and is dropped.
+ * never copied. The translator's `label` fallback is not a translation and
+ * never lands ({@link withoutInventedViewLabel}).
  */
 function projectViewTranslation(
     target: Record<string, unknown>,
@@ -3018,9 +3031,8 @@ function projectViewTranslation(
         if (out === target) out = { ...target };
         out[key] = value;
     };
-    for (const [key, value] of Object.entries(translated)) {
+    for (const [key, value] of Object.entries(withoutInventedViewLabel(input, translated))) {
         if (key === 'config' || VIEW_EXPANSION_IDENTITY_KEYS.has(key) || value === input[key]) continue;
-        if (key === 'label' && input.label == null && value === input.name) continue;
         set(key, value);
     }
     const config = translated.config;
@@ -3033,6 +3045,38 @@ function projectViewTranslation(
     return out;
 }
 
+/**
+ * [#22614 · #23967] `translated` — what the spec's `translateView` answered for
+ * the view `input` — without the `label` that translator invents. It answers
+ * `input.label ?? input.name` when the catalog carries no string for the view,
+ * so a view stored with no `label` comes back carrying its own name, and the
+ * spec declares a view's `label` optional with no default: that value was
+ * authored by nobody and translated from nothing, and a reader could tell it
+ * from a real label only by comparing it to `name`.
+ *
+ * The rule: a `label` equal to `input.name` where `input` carried none (absent
+ * or nullish) is the fallback, and `input`'s own value takes its place — no
+ * `label` key when `input` had none. An authored `label`, even one equal to the
+ * view's name, and a catalog string that differs from the name are served
+ * unchanged; a catalog string equal to the name cannot be told from the
+ * fallback and goes with it.
+ *
+ * ONE rule for every `view` read this module translates: the item read
+ * ({@link translateMetaDocument}), the list read ({@link translateMetaList})
+ * and each part of a container ({@link projectViewTranslation}). Returns
+ * `translated` itself when nothing is dropped.
+ */
+function withoutInventedViewLabel(
+    input: Record<string, unknown>,
+    translated: Record<string, unknown>,
+): Record<string, unknown> {
+    if (input.label != null || translated.label !== input.name) return translated;
+    const served: Record<string, unknown> = { ...translated };
+    if ('label' in input) served.label = input.label;
+    else delete served.label;
+    return served;
+}
+
 /** The keys `expandViewContainer` stamps on an item — its identity, never the view's own content. */
 const VIEW_EXPANSION_IDENTITY_KEYS: ReadonlySet<string> = new Set([
     'name', 'object', 'viewKind', 'order', 'scope', 'isDefault', '_diagnostics',