Repository navigation
spec(liveness): app.branding.logo is live — objectui AppMark renders it at the pin - #23830
Merged
objectstack-fleet[bot] merged 2 commits intoOct 16, 2026
Merged
Conversation
…it at the pin Claude-Session: https://claude.ai/code/session_01PfJqaHVFSJ1Znqb9vBPZe2 Co-authored-by: Claude <noreply@anthropic.com>
…ng.logo flip Claude-Session: https://claude.ai/code/session_01PfJqaHVFSJ1Znqb9vBPZe2 Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift Check
What this run could not see
Coarse fallback — 142 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
席位核对 · ACCEPT · PR #23830 @
|
objectstack-fleet
Bot
deleted the
claude/issue-23394-branding-logo-live
branch
October 16, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23394
Clause-②: no
What changes
packages/spec/liveness/app.json,app.branding.children.logoflips fromplannedtolive(verifiedAt2026-10-16,evidenceScope: "cross-repo")..objectui-shapin this tree carries (daeb77fc84): objectuipackages/app-shell/src/layout/AppMark.tsx#AppMarkreadsbranding.logoand draws it as anobject-containimage (it falls back to theicontile when the key is absent or the image fails to load). It is mounted byAppSwitcher#AppSwitcherat 22 px, on the top-bar app pill and on every switcher row (the switcher is mounted inAppHeader), and byUnifiedSidebar#UnifiedSidebarat 26 px, in the phone drawer header. All three are cited inevidence.producer: kept and re-pinned todaeb77fc. The designer'sAppCreationWizard,BrandingEditorandEditAppPagestill write or pre-fillbranding.logoat the pin.note: rewritten to say what renders it. The "PLANNED, carrier objectui#10827" and "Flip tolive" wording is gone, and so is the paragraph about objectui's top-levellogo, because objectui has since retired that second spelling. The ONE SPELLING paragraph stays, because it is still true:AppSchemadeclares onlybranding.logo, and the alias table answers an app-levellogowithbranding(packages/spec/src/ui/app.zod.ts).brandingcontainernote: only the sentence aboutlogois changed. It now sayslogoreached nothing mounted at the 2026-09-27 drill and has since gonelivethroughAppMark.state-counts/app.md: regenerated withgen:liveness-counts. Before:live 50 · planned 1. After:live 51 · planned 0.classifiedstays 59.patchchangeset for@objectstack/spec.liveness/is in the package'sfiles[], so the ledger ships.No schema, objectui file or
.objectui-shachanges.Verification
At head
0a6dbaf4:pnpm --filter @objectstack/spec check:liveness: exit 1 before the regeneration (the expected count drift,| app | 50 | 0 | 0 | 8 | 1 | 59 |to| app | 51 | 0 | 0 | 8 | 0 | 59 |), then exit 0 aftergen:liveness-counts. Everyliveentry's repo-local evidence resolves, andstate-counts/is current.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 62 commands for this diff. 59 exited 0,pnpm --filter @objectstack/spec run check:generatedamong them, after a spec build. 3 exited 3 because a prerequisite was missing (NOT MEASURED, left to CI):check:dual-build-cjs-loadsandcheck:lean-entry-closureneed a full workspace build, andcheck-plugin-teardown-shape.mjs --self-testneeds an unshallowed clone.--ranreconciles: 62 derived, 59 run, 3 NOT-MEASURED, 0 UNRUN.Acceptance notes
_notestill has the dated 2026-09-27 sentence "brandingis now DRILLED:logoisplannedwith carrier objectui#10827". It records history and sits outside this card's claimed file surface (the row and the container note only), so it is left as it was.docs/audits/2026-06-appschema-property-liveness.mdlistsbranding.logoamong the unimplemented keys. It is a dated audit snapshot, not a current-state page, and it is left as it was.🤖 Generated with Claude Code
https://claude.ai/code/session_01PfJqaHVFSJ1Znqb9vBPZe2
Generated by Claude Code