You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
spec(system): push-config / push-device docblocks still cite ADR-0012 §6 for "domestic vendors are alternate channel plugins", the reading #29817 retires #29960
Filing gate: ① a defect at named locations. The contract review of PR #29952 (#29817, the ADR-0012 amendment), records 6610988758 and 6611334981, found it and escalated it. ⛔ Not a claim. Suggested-grade: p3 (comment text only, nothing an author writes changes).
Business reason. Once PR #29952 lands, ADR-0012 §6 says the hosted relay fronts the domestic Android vendors (HMS/Honor, Xiaomi, OPPO, vivo), and that vendor on a device row is a token type the relay routes on, not a plugin boundary. The spec docblocks that cite §6 would then send a reader to the ADR for the opposite reading. A future card that widens PushVendorSchema would be told, by the schema's own comment, that the vendors belong in channel plugins. Reader: the domain:spec seat (packages/spec/src/system/).
What the code says (at origin/main6a4737ab)
packages/spec/src/system/push-config.zod.ts ≈:76: "Out of scope here: the other vendors ADR-0012 §6 routes to alternate channel plugins (HMS, Xiaomi, OPPO, vivo)."
the same file ≈:83, the PushVendorSchema docblock: "ADR-0012 §6 plugs the domestic Android vendors in as alternate channel implementations, not as transports of this channel".
packages/spec/src/system/push-device.zod.ts ≈:12 "(ADR-0012 §6, narrowed to what core ships)" and ≈:49 "Narrowed from ADR-0012 §6: … the domestic Android vendors plug in as alternate channel implementations".
Rewrite those comments to the amended §6 / §6.1 reading. Core ships apns | fcm. The relay fronts the domestic vendors in phase 2, and vendor is the token type it routes on. Widening PushVendorSchema remains a spec change made together with the relay's vendor support.
Comment text only: no schema, .describe(), export or default moves. Measure whether any generated reference page carries these docblocks; if one does, regenerate it.
Clause-②: no, Metadata-protocol: none, and a changeset only if the gate asks for one.
Serial: after PR #29952 merges (Tier H; the maintainer merges it), so the comments never cite a §6 that main does not have. Seat 2's #29820 also edits push-config.zod.ts (the transport-selection docblock and markers). Expect a trivial merge at most.
Dedupe: searched PushVendorSchema, push vendor relay, alternate channel. Found #29817 (the ADR, which carries no code), #29820 (scope: token, key, reader), and #29920 (the relay sender). New.
Activity
objectstack-fleet commentedon Nov 3, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: first-touch audit · p3 ·
domain:speckept ·pm:triage→pm:queue· 2026-11-03T17:55Z⛔ Not a claim.
push-configandpush-devicedocblocks still cite ADR-0012 §6's "domestic vendors are alternate channel plugins", which ADR-0012 amendment: the push channel's relay transport, and vendor as a token type rather than a plugin boundary (ruling cloud#3519) #29817 / PR docs(adr): ADR-0012 — the hosted push relay transport (default) beside direct APNs/FCM, and vendor as a token type the relay routes on (ruling cloud#3519) #29952 retires. Comment text only, so p3, as suggested. Serial after PR docs(adr): ADR-0012 — the hosted push relay transport (default) beside direct APNs/FCM, and vendor as a token type the relay routes on (ruling cloud#3519) #29952.Generated by Claude Code