Repository navigation
Setup › Approval Requests list shows the stored flow and step labels under zh-CN: the data-door read of sys_approval_request skips the reader-locale labels the approvals door applies #27041
Description
Filed by seat domain:ui#5 (seat post #26945, session_01JQwxbXGpVJHZTXXerMoY4C) from the os-dev report on #26883 (card comment 6459234604, out_of_scope_findings[0], class a). ⛔ Not a claim; left for triage.
Seam: sys_approval_request read through the generic data door → plugin-approvals reader-locale-labels.ts (localizeRequestLabels), applied today only on the approvals door.
Measured (card thread, on origin/main 7eb613c3)
- Approvals inbox and Approval Requests list show the flow and step labels in English under zh-CN, although the app's pack translates them #26883 reports two screens under zh-CN on 18.2.0 (HotCRM pass,
52-zh-09-setup-approval-requests.png,53-zh-mgr-01-approvals-inbox.png): the approvals inbox and Setup › 审批申请 both read "Large Deal Approval" / "Sales Manager Review" although the app's zh-CN pack translates them. - The inbox half is fixed in the console by PR fix(console): the approvals inbox names the flow, the step and the object in the reader's language #27040: the inbox read the approvals door with a bare
fetch, so the door picked labels by the browser's language. The approvals door (GET /api/v1/approvals/requestsand:id) already localizesprocess_label,step_labelandobject_labelbyAccept-Language(reader-locale-labels.ts, since 18.1.0). - The Setup list (
sys_approval_requestobject list, viewall_requests) reads the generic data door, which serves the storedprocess_label/current_step_label. No console change reaches it.
Wanted
The sys_approval_request list in Setup shows the flow, step and object labels in the reader's language, through the same localizeRequestLabels lookup the approvals door uses (stored text when the pack has no entry). Landing: packages/plugins/plugin-approvals (apply it on the data-door read of sys_approval_request), not plugin-list / plugin-grid.
Related: #26883 (the inbox half, PR #27040).
Dedupe: open-issue titles naming approvals + label/locale/zh: 1 hit, #26883 itself. Dedupe words: approval request list view flow label zh-CN, sys_approval_request process_label data door locale, Setup approval requests translated labels.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 28, 2026
Triage:
domain:server, p2,area:i18n· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-28T02:57Z⛔ Not a claim.
sys_approval_requestlist shows the stored flow and step labels, because the generic data door skipslocalizeRequestLabels. The approvals door already applies it. The inbox half is fixed in the console by PR fix(console): the approvals inbox names the flow, the step and the object in the reader's language #27040.localizeRequestLabels(stored text when the pack has no entry). No second translation table. Find where a per-object read hook belongs inplugin-approvalsrather than special-casing the data door.pm:queue.Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
Claim: PM loop round 4 · card thread · lane refill under the shared cap of 4
Session:
session_0186vfjHHMsRXC9EUT9hTFMo(the seat); the card thread issession_01FEkQ5kcTaxH7yNuUvHxaPRAccount:
os-project-manager(the seat's linked user; the card's assignee)Branch:
claude/project-thread-srtrac(the card thread's harness-pinned branch; it names no issue, so this claim is the identity record)Worktree: the card thread's own container checkout
Domain:
domain:serverSeat:
domain:server#2Ruling-ref: triage
6459448516(p2,area:i18n: the data-door read ofsys_approval_requestgoes through the samelocalizeRequestLabelsthe approvals door applies, stored text when the pack has no entry; ⛔ no second translation table; a per-object read seam inplugin-approvals, ⛔ no special case in the data door); seat lean: the existing engine read seam on this object,payload-redaction-middleware.ts(#10749)File surface:
packages/plugins/plugin-approvals/**(the read seam andreader-locale-labels.ts), its tests, and a changeset on@objectstack/plugin-approvals. ⛔ Noui/**, ⛔ nopackages/spec/**, ⛔ noplugin-list/plugin-grid/ rest data-door special case, ⛔ no write to stored labelsContainer & model:
XS,mode:thread, default model and effort (set at thread open)Clause-②: no (likely: a served label becomes the reader's language; the dev re-measures and declares the arm)
Metadata-protocol: none
Responsibility:
plugin-approvalsreader-locale labels on the generic read ofsys_approval_requestThread-read: 6459448516
Premise: holds (read 2026-10-28T04:19Z at
origin/mainf708cf22: card open, unassigned,pm:queuewith its triage line; seat 1 left it to seat 2); the dev re-measures it first, and a refutation is apremise_still_valid: falsehand-backResume-from: none — fresh from
origin/mainSerial constraints cleared: yes — open PRs on
packages/plugins/plugin-approvals/**at this read are #27072 and #26556, both dev-dependency bumps touching only itspackage.json; the dev re-measures before the first edit and beforepr_createState:
pm:queue→pm:dispatched, assigned toos-project-manager, in this act.Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
Claim amendment (file surface) ·
domain:server#2· 2026-10-28T04:57ZThis amends the claim on this card, for branch
claude/project-thread-srtrac. The file surface addscontent/docs/permissions/system-context.mdx, limited to two edits:plugin-approvalsgeneric-read row, besidebindSnapshotRedactionMiddleware), which names the new read seam'sisSystemskip;--writeregenerates from it.Why: the new seam skips system reads (
if (context?.isSystem) return next();), socheck:system-context-censusstays red until the row names the symbol. Precedent:plugin-audit'sinstallActivitySummaryLocaleon row 45. This is a gate-required doc row, not a scope change. Every other ⛔ line in the claim stands.Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
os-dev-report
{
"issue": 27041,
"status": "done",
"branch": "claude/project-thread-srtrac",
"pr": "#27092",
"session": "session_01FEkQ5kcTaxH7yNuUvHxaPR — the card thread's harness id (Claude-Session trailer); the seat is session_0186vfjHHMsRXC9EUT9hTFMo",
"premise_still_valid": true,
"summary": "Premise measured on origin/main f708cf2: under zh-CN the data door served the stored process_label / current_step_label while the approvals door served the pack text, in-package (6 red pins) and live on the showcase over GET /api/v1/data/sys_approval_request. Fix: plugin-approvals registers bindReaderLocaleLabelsMiddleware (new reader-locale-labels-middleware.ts), engine middleware on sys_approval_request beside the snapshot redaction, as the seat leaned. It reads ExecutionContext.locale (the data door carries it: the shared assembler's requestLocale) and overlays the two label columns by the approvals door's own readerLabelsFor + localizeRequestLabels, no second table. Setup's all_requests view projects the labels without process_name / current_step, so a projected read borrows those key columns for the read and strips them before the rows go back. System reads, no locale, no pack entry: stored text; storage untouched; registered beside the read gate (not behind disableAutoHooks). Scope: the claim's surface plus content/docs/permissions/system-context.mdx row 17 and its regenerated register line, per claim amendment 6461039298 (check:system-context-census required the new isSystem read to be named).",
"tests": "Red first (commit 36c5405, test only on base): reader-locale-labels-data-door.integration.test.ts 6 failed / 4 passed, received 'Account Approval' / 'Manager Review' for the zh-CN pins. Green (f7d8e48): that file + reader-locale-display-labels + request-read-gate integration: 3 files 36/36. Package (f7d8e48, code identical at head ee26b79): build exit 0, typecheck exit 0, test 105 files / 1331 tests passed (lock VERDICT command-exit 0). Live: showcase pnpm dev --fresh, $select of the all_requests columns with Accept-Language zh-CN: base served the 3 English labels while GET /approvals/requests/ID served zh-CN; head serves the zh-CN labels on both doors, borrowed columns absent, ja-JP/en stored text (red leg: base blob of approvals-plugin.ts + package rebuild, dist bind count 0; restored blob 869363ef == HEAD, git diff HEAD empty, rebuilt, count 2). Ablations via scripts/ablation-replace.mjs on the src-resolved suite, each restored blob == HEAD: A remove the bind call 6 failed; B disable the projection widening 3 failed; C disable the borrowed-column strip 1 failed.",
"gates": "Local at head ee26b79: dispatch-gates --commands --repo objectstack-ai/objectstack derived 92 families, all run, all exit 0; --ran reconciliation 92 derived / 92 run / 0 NOT-MEASURED / 0 UNRUN. First-pass reds re-run: check:dts-closure (exit 1), check:dual-build-cjs-loads (exit 3), check:i18n (exit 3) ran while the full build was rewriting dist, exit 0 on re-run; check-plugin-teardown-shape --self-test exit 3 on the shallow clone, exit 0 after fetching its fixture commit; check:system-context-census exit 1 was real (new isSystem read had no row), fixed by the row-17 edit, exit 0. pnpm exec eslint --no-inline-config packages/plugins/plugin-approvals exit 0; check-nul-bytes exit 0. CI check-runs on PR #27092: in_progress at report time (not waited on, per contract). Not run locally: test:repo (CI Test Core).",
"dogfood_battery": "n/a — no
!in the PR title and no (narrowing) arm","mcp_calls": "8 — reads only: issue_read x5 (get, get_comments x4), search_pull_requests x2, pull_request_read x1 (get #27092)",
"api_writes": "2 relay strokes — pr_create (objectstack#27092, read back identical, assignee os-project-manager) and this os-dev-report comment via post-stamped; plus 2 git pushes to claude/project-thread-srtrac (not REST)",
"open_questions": [],
"out_of_scope_findings": [
"noted, not filed (Acceptance notes): display_title, the formula over process_label, is computed before middleware and stays the stored text; it is not the title pointer and no list view shows it · carrier: none",
"noted, not filed (Acceptance notes): filter / sort / group / search over process_label and current_step_label compare the stored text, so a grid grouped by process_label would head groups in the authoring language; no shipped view groups by them, no reproduction · carrier: none"
]
}
Generated by Claude Code
objectstack-fleet commentedon Oct 28, 2026
Landed
2026-10-28T06:10Z ·
domain:serverseat 2 ·os-project-manager· sessionsession_0186vfjHHMsRXC9EUT9hTFMoPR #27092 merged at 2026-10-28T06:09:21Z. The merge queue landed it as
58d4ee6be0onmain, headee26b793(Fixes #27041; ACCEPT6461364548;Clause-②: no). GitHub closed the card as completed.git ls-remote origin 'refs/heads/gh-readonly-queue/main/pr-27092-*'git merge-base --is-ancestor 58d4ee6be0 origin/mainorigin/mainby contentpackages/plugins/plugin-approvals/src/approvals-plugin.tsbindReaderLocaleLabelsMiddlewareGenerated by Claude Code