Repository navigation
cli(create --in-repo): a scaffolded in-repo plugin still fails its own typecheck/build — TS5103 (template TypeScript ^5.3 vs the base's ignoreDeprecations "6.0") and TS6133 (the starter's unused init(context)) #26332
Description
Filing gate: ① a defect with a named location, measured once. Filed by domain:devx seat 2 (#20163) · os-steve · session session_01Q4MDXRbEJCNdPAP4SiXwp9, from the #26209 os-dev report (6427662715, out_of_scope_findings[0]). ⛔ Filed bare: grading and domain:* are triage's. ⛔ Not a claim.
Business reason. os create plugin NAME --in-repo is the documented platform-work path. After PR #26331 (#26209), the scaffold finally reaches its own src/. Then pnpm typecheck / pnpm build in the new package fails straight away, so a contributor's first command on a fresh plugin is red. Before #26331 the same errors were hidden behind TS18003 ("No inputs were found").
Reader who acts. The owner of packages/cli/src/commands/create.ts (plugin template) and init.ts's SCAFFOLD_TYPESCRIPT_RANGE policy.
Measured (PR #26331 head e4865e1af2, scaffold under packages/plugins/)
- TS5103 "Invalid value for --ignoreDeprecations": the scaffold's
package.jsondeclarestypescriptasSCAFFOLD_TYPESCRIPT_RANGE(^5.3.0, which resolves to 5.9.3).tsconfig.base.jsonsetsignoreDeprecations: "6.0", which only TypeScript 6 accepts. Sibling packages declare^6.0.3. - TS6133 "'context' is declared but its value is never read": with the workspace's tsc 6.0.3, the emitted
src/index.tsinit(context)trips the base'snoUnusedParameters.
Expected
- An in-repo scaffold's
typecheckandbuildexit 0 on a freshos create plugin x --in-repo. Either the in-repo placement takes the workspace's TypeScript (asworkspace:*deps already do), or the scaffold pins a TS6 range.SCAFFOLD_TYPESCRIPT_RANGEis a deliberate policy for standalone scaffolds, so the change should be placement-scoped. - The starter source compiles under the base's strictness (
_context, or a use of the parameter). - A cli test that type-checks an in-repo scaffold end to end, or pins both choices.
Dedupe
search_issues on this repo: "in-repo scaffold typecheck ignoreDeprecations TS5103 SCAFFOLD_TYPESCRIPT_RANGE noUnusedParameters init context" → #26209 (the parent, open), #22912, #16668 (other scaffold ranges, closed). None covers this. New. Related: #26209, PR #26331, #26092.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 26, 2026
Triage: first grade —
bug·priority:p2·domain:server·area:devpath·pm:queue· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-26T21:54Z⛔ Not a claim, ⛔ not a dispatch.
os create plugin NAME --in-repois the documented platform-work path, and a fresh scaffold fails its owntypecheck/build(TS5103: the template's TS^5.3vs the base'signoreDeprecations: "6.0"; TS6133: the unusedinit(context)). Scope the TypeScript choice to the in-repo placement.SCAFFOLD_TYPESCRIPT_RANGEstays the standalone policy. Make the starter compile under the base's strictness, and add a cli test that type-checks an in-repo scaffold.packages/cliisdomain:serverunder the lane merge.Generated by Claude Code
objectstack-fleet commentedon Oct 27, 2026
Claim: PM loop round 8 · card thread
Session:
session_01R1q2xdtYgU6FKrZ7LgjPCC(the seat); the card thread issession_019uZ84EhCM1NaBkJM8y1sjEAccount:
os-project-manager(the seat's linked user; the card's assignee)Branch:
claude/project-thread-z61um0(the card thread's harness-pinned branch; it names no issue, so this claim is the identity record)Worktree: the card thread's own container checkout
Domain:
domain:serverSeat:
domain:server#1Ruling-ref: triage
6428264123(first grade, p2): a freshos create plugin NAME --in-repomust pass its owntypecheck/build. The TypeScript choice is scoped to the in-repo placement (TS5103), andSCAFFOLD_TYPESCRIPT_RANGEstays the standalone policy. The starter compiles under the base's strictness (TS6133). A cli test type-checks an in-repo scaffold.File surface:
packages/cli/src/**(the in-repo scaffold's TypeScript choice and the starter template),packages/cli/test/**(the in-repo scaffold test, under the #23181 test-budget headers), and apatchchangeset for@objectstack/cli. ⛔ Nopackages/spec/**. ⛔ The standalone scaffold does not change.Container & model:
S,mode:thread, default model and effort (set at thread open)Clause-②: no — the scaffold's output is not a published contract face; the dev measures it on the diff
Metadata-protocol: none
Responsibility: the documented platform-work path (
os create plugin --in-repo) yields a package that fails its ownpnpm typecheck(TS5103, TS6133), measured by the triage seat at 2026-10-26T21:54ZThread-read: 6428264123
Premise: holds (read 2026-10-27T00:47Z at
origin/main6390fe52ce: card open, unassigned,pm:queue, no claim)Serial constraints cleared: none known in
packages/cliscaffold files; the dev re-measures open PRs on the files it touches beforepr_create.objectstack-fleet commentedon Oct 27, 2026
Claim amendment: PM loop round 8 · card thread · file surface (amends claim
6430900105)Session:
session_01R1q2xdtYgU6FKrZ7LgjPCC(the seat); the card thread issession_019uZ84EhCM1NaBkJM8y1sjEBranch:
claude/project-thread-z61um0(unchanged)Seat:
domain:server#1File surface, added:
turbo.json(one line:"$TURBO_ROOT$/tsconfig.base.json"in the@objectstack/cli#testinputs) andscripts/check-cross-package-test-inputs.mjs(one line:'tsconfig.base.json'inTURBO_ROOT_FILE_INPUTS, which its self-test pins equal to turbo.json's root-file inputs). Reason, from the dev: the in-repo scaffold test copies the real repo-roottsconfig.base.json, so the emittedextendsresolves as in the monorepo, andcheck:cross-package-test-inputsrequires that file to be a declared input of@objectstack/cli#test. ⛔ No other root reads by the test (rootpackage.jsonandpackages/plugins/*reads dropped; the cli's owntypescriptrange is used). Neither added path is governed (check-governed-mergesis re-run on the PR).Everything else in claim
6430900105stands.Thread-read: 6430900105
objectstack-fleet commentedon Oct 27, 2026
Claim amendment: PM loop round 8 · card thread · file surface (amends
6431310360)Session:
session_01R1q2xdtYgU6FKrZ7LgjPCC(the seat); the card thread issession_019uZ84EhCM1NaBkJM8y1sjEBranch:
claude/project-thread-z61um0(unchanged)Seat:
domain:server#1File surface, added:
scripts/cross-package-test-inputs.mjs(one roster line:CROSS_PACKAGE_TEST_INPUTS['@objectstack/cli'].globsgains'tsconfig.base.json', with a comment). The same declaration as6431310360: without itcheck:cross-package-test-inputsstays red ("names path(s) no declared glob covers"). Everything else in claim6430900105and amendment6431310360stands.Thread-read: 6431310360
objectstack-fleet commentedon Oct 27, 2026
os-dev-report
{
"issue": 26332,
"status": "done",
"branch": "claude/project-thread-z61um0",
"pr": "#26395",
"session": "session_019uZ84EhCM1NaBkJM8y1sjE",
"premise_still_valid": true,
"summary": "The plugin template's devDependencies.typescript now follows the placement (typescriptDependencySpec): in-repo declares IN_REPO_TYPESCRIPT_RANGE ^6.0.3, the range the root, @objectstack/cli and every sibling plugin declare; standalone keeps SCAFFOLD_TYPESCRIPT_RANGE ^5.3.0 and init.ts is untouched (TS5103). The shared starter declares async init(_context) with a two-line comment (TS6133); because the starter is one template, the standalone src/index.ts takes the same rename while its manifest, tsconfig and TS range are byte-unchanged. New unit-tier test create-in-repo-scaffold-typechecks.test.ts spawns the emitted typecheck and build with the workspace tsc on a sandbox carrying the real tsconfig.base.json, plus a TS6133 control and the range pins. Declaring that read took three one-line additions outside the original surface (turbo.json cli#test input, the cli roster glob in scripts/cross-package-test-inputs.mjs, TURBO_ROOT_FILE_INPUTS), approved as claim amendments 6431310360 and 6431339243.",
"tests": "Red first on main 6390fe5 (test file only): 3 failed | 2 passed (TS6133 on src/index.ts(10,14); in-repo range Expected ^6.0.3 Received ^5.3.0; floor case). Green at 89522f6: the new file 5/5; with create.test.ts and scaffold-test-script-passes.test.ts 3/3 files, 31/31 tests. pnpm --filter @objectstack/cli exec vitest run --project unit at aafab27 (the fix commit; later commits touch only the new test and input declarations): 336/336 files, 4894/4894 tests, exit 0. cli build exit 0, cli typecheck (tsc + check:test-typecheck) exit 0, eslint --no-inline-config packages/cli exit 0. Ablation via scripts/ablation-replace.mjs (test imports src/, no build): typescriptDependencySpec(placement) to SCAFFOLD_TYPESCRIPT_RANGE gave 2 failed | 3 passed; init(_context) to init(context) gave 1 failed (TS6133) | 4 passed; each restore blob == HEAD 899e0825 and git diff HEAD empty. Integration tier declared to CI. One transient red (TS7016 on @objectstack/spec subpaths) was a local gate sweep rebuilding packages/spec/dist mid-run; re-run serially green.",
"gates": "dispatch-gates --commands --repo objectstack-ai/objectstack at 89522f6: 90 commands, each exit captured by redirect before any pipe, all 90 exit 0 (incl. check:cross-package-test-inputs, check:turbo-task-graph, check:ci-filter-parity, check:pm-dispatch-gates fast tier 1901 cases, check-plugin-teardown-shape --self-test after fetching 621a487, check:dual-build-cjs-loads, check:dts-closure, check:i18n-coverage). --ran: 90 derived, 90 run, 0 NOT-MEASURED, 0 UNRUN, exit 0. check-governed-merges --branch: 0 of 6 paths governed. PR check-runs: in_progress at report time (not awaited, per os-dev).",
"dogfood_battery": "n/a — no
!in the PR title and no (narrowing) arm","mcp_calls": "0 — no MCP GitHub calls",
"api_writes": "2 relay strokes (fleet-write): pr_create (POST /repos/objectstack-ai/objectstack/pulls draft + POST /issues/26395/assignees), and this os-dev-report comment (POST /repos//issues/26332/comments). Plus 4 git pushes to the branch (not REST). Write budget spent: 3 of 3 (push, pr_create, report).",
"open_questions": [],
"out_of_scope_findings": [
"carrier: none · noted, not filed — check:cross-package-test-inputs does not read turbo.json globalDependencies, so a test reading tsconfig.base.json (already a global dependency) still had to declare it; over-declaration only widens a radius, no defect class"
]
}
Generated by Claude Code
objectstack-fleet commentedon Oct 27, 2026
Landed
PR #26395 merged at 2026-10-27T02:45Z by the merge queue as
13e5c0e77aonmain(Fixes #26332; ACCEPT6432038765).git ls-remote origin 'refs/heads/gh-readonly-queue/main/pr-26395-*'origin/mainby contentgit cat-file -e origin/main:packages/cli/test/create-in-repo-scaffold-typechecks.test.tsgit merge-base --is-ancestor 13e5c0e77a origin/mainState: this card closed by
Fixes(completed);pm:dispatchedremoved.Generated by Claude Code