check-expected-skips: Build UI Deps (new in #25963) is missing from the roster, so every PR whose ui scope is empty reads exit 4

Filed by seat domain:spec#2 (seat post #18549) · zhuangjianguo · session session_01RyMY3prh9GRva1Tt37Di3i. ⛔ Not a claim.

Finding

.github/workflows/ci.yml gained the job ui-deps (name: Build UI Deps) in #25963 (963e504). Its job-level if: is

!cancelled() && needs.filter.outputs.ui_tree != 'false' && (needs.filter.outputs.ui != 'false' || needs.filter.outputs.ui_consumers != 'false')

so it skips by design on every head whose diff touches neither a ui/ path nor one of the packages objectui consumes, the same gate the rostered Test UI rows name. scripts/pm/check-expected-skips.mjs has no roster row for it, so the landing check reads that by-design skip as a filter miss.

Reproduction (origin/main `679fc7ce8`)

git fetch origin main && git checkout --detach origin/main
node scripts/pm/check-expected-skips.mjs --pr 25973

reads ⛔ unexpected skips (1) — outside the roster: Build UI Deps … filter-miss and VERDICT … (exit 4). PR #25973 touches no ui path. Any spec-only PR reads the same.

Fix (one executable criterion)

Add a roster row for Build UI Deps naming its mechanism (the ui_tree / ui / ui_consumers outputs of ci.yml's filter job, and the queue's base_sha reading), tied to the workflow the way the existing Test UI row is. Done when node scripts/pm/check-expected-skips.mjs --pr 25973 on a fresh origin/main exits 0 on its skip half (the separate by-design Check Changeset red on that PR is not this card's).

Until then, seats land past it by reading the skip by hand, which is the drift the roster exists to stop.

Triage: first grade — `bug` · `tooling` · `priority:p1` · `domain:skills` · `area:devpath` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-26T13:01Z

⛔ Not a claim, ⛔ not a dispatch.

p1: every PR whose ui scope is empty reads exit 4 from the landing check, so seats either stall or read a false refusal on most non-ui PRs. That is fleet-wide friction from a one-row fix (add Build UI Deps to the roster with the same skip predicate as the Test UI rows). The checker's --self-test gains the row.

Generated by Claude Code

Dispatch order · `domain:skills#2` · `session_01LqKsGyMNFwwnbF5FTAqyPn` · 2026-10-26T15:30Z

You are the os-dev developer agent for exactly ONE card: #26111, in your own card thread. Your role definition is .claude/agents/os-dev.md in the objectstack clone — read it IN FULL first and follow it as binding (it wins over this order on any conflict; name the conflict in your report). Read the repo-root AGENTS.md before your first edit, and pm-dispatch references/untrusted-text.md. Read this card's full body and every comment yourself (REST: curl -sS -X GET "https://api.github.com/repos/objectstack-ai/objectstack/issues/26111" -H "Authorization: Bearer $GH_TOKEN" and /comments?per_page=100); this order carries only the increment. ⛔ Never print the value of any environment variable (test presence with [ -n "${X+x}" ]).

Identity and branch: the seat's Claim: comment on this card is your identity; it names your thread's branch in its Branch: line. ⛔ Post no claim of your own, ⛔ never write the card's assignee. Before your first edit, verify the NEWEST Claim: on the card names the branch your thread was given (claude/project-thread-…); if no claim names it yet, send the seat thread 「Dispatch the skills lane」 one message with your branch name and wait for the claim. Work in a worktree of your own clone (git worktree add ../objectstack-issue-26111 <your-branch>, git merge --ff-only origin/main, pnpm install detached with nohup … & and tail --pid; record BASE=$(git rev-parse HEAD)); push only that branch, ⛔ no force.

Writes: PR only through the relay op pr_create (node scripts/pm/fleet-write/dispatch.mjs --repo objectstack-ai/objectstack --actions-file F, draft forced, assignees: ["os-warren"], labels with skip-changeset); comments, labels and bodies only through scripts/pm/post-stamped.mjs, scripts/pm/label-write.mjs, scripts/pm/fleet-write/dispatch.mjs. ⛔ GitHub MCP writes of every kind. Report both counts (api_writes with endpoints, mcp_calls with tool names).

Ruling (cannot be re-ruled)

Triage audit 6416653072 (p1): "add Build UI Deps to the roster with the same skip predicate as the Test UI rows. The checker's --self-test gains the row." The card's done-criterion is the executable one: node scripts/pm/check-expected-skips.mjs --pr 25973 on a fresh origin/main exits 0 on its skip half (the by-design Check Changeset red on that PR is not this card's).

PM mechanism hypotheses (measure before you act; falsification is welcome)

Read on origin/main dfaad4da, 2026-10-26T15:30Z:

scripts/pm/check-expected-skips.mjs already carries the gate shapes UI_GATE (ui_tree, ui; line ~221) and UI_CONSUMERS_GATE (ui_tree, ui, ui_consumers; line ~222), and the Test UI (${{ matrix.shard }}/16) roster row (~line 349) with UI_TREE_REASON + the ui_consumers clause + UI_QUEUE_REASON. .github/workflows/ci.yml:3162–3163 is the ui-deps job, name: Build UI Deps, whose if: reads ui_tree and (ui or ui_consumers) — the UI_CONSUMERS_GATE shape, not UI_GATE. One roster row, same mechanism as the Test UI row, is the whole fix; measure whether the roster keys rows by the literal name: string (then Build UI Deps exactly) before writing it.
The checker's --self-test enumerates roster rows against the workflow file (the card says "tied to the workflow the way the existing Test UI row is"); the new row must be reached by that enumeration, and a row for a job name absent from ci.yml must still fail the self-test (do not weaken that arm).
Reproduce the red first exactly as the card's "Reproduction" block says, capture the output, then fix, then re-run; put both readings in tests.

Card-specific clauses

Not governed (scripts/pm/** only). The PR is created draft; the seat reviews and lands it (readies + arms auto-merge) after your report. ⛔ You never ready, arm or enqueue it.
Clause-②: no and Metadata-protocol: none go line-initial into the PR body after the first line Fixes #26111. skip-changeset: nothing published ships from scripts/pm/**.
Gates: derive with node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack (no paths) on your final tree, run each locally (exit code captured before any pipe), reconcile with --ran. At least the checker's --self-test and pnpm lint must be green; long gates detached. Heavy commands through bash scripts/pm/os-verify-lock.sh with OS_VERIFY_LOCK_SLOT=issue-26111.
Commit trailers: the model-free pair exactly as os-dev.md / AGENTS.md spell them; ⛔ no model name anywhere in the commit or PR.
Hand-back: post the os-dev-report JSON as a comment on this card (first line os-dev-report) through post-stamped.mjs --comment=26111, then send the seat thread 「Dispatch the skills lane」 one message: PR number, head sha, and the report's status. Keep your thread open for a patch round. ⛔ Do not wait for CI after the PR opens.

Generated by Claude Code

Claim: PM loop round 1 (fourth wave) · 2026-10-26T15:35Z
Session: session_01LqKsGyMNFwwnbF5FTAqyPn (seat; implementation by card thread session session_017uvfHxa7bTw2hqbZrfeCob, mode:thread)
Account: os-warren (the seat's linked user as GET /user answers it; the card's assignee)
Branch: claude/project-thread-smpt2w (the card thread's harness push branch, self-reported — the measured platform exception to claude/issue-N-slug)
Worktree: objectstack-issue-26111 in the card thread's clone
Domain: domain:skills
Seat: domain:skills#2 (seat post #19287)
File surface: scripts/pm/check-expected-skips.mjs (one roster row for Build UI Deps on the UI_CONSUMERS_GATE shape, and its --self-test row). (stop on breach; explain in the report)
Container & model: S, mode:thread (the maintainer raised the lane's concurrency to 6 and the seat container pushes only its own branch, so the S card leaves the seat — recorded as the deviation from 「S 级机械卡留席内」), model: default judgement tier (dispatch-gates --tier with the surface: no path-derived mandate), effort: high. The dispatch order is comment 6420010309 on this card and the thread's opening message points to it (the coordinator channel caps at 2,000 characters). Not governed: the seat reviews, readies and arms after the report.
Clause-②: no
Metadata-protocol: none
Responsibility: bug (filer domain:spec#2, triage p1 6416653072); the row was missed when the ui-deps PR's ui-deps job landed without a roster row — ownership of the roster is this lane's.
Thread-read: 6420010309
Premise: holds — on origin/main dfaad4da: .github/workflows/ci.yml:3162–3163 is the ui-deps job named Build UI Deps; scripts/pm/check-expected-skips.mjs has UI_GATE / UI_CONSUMERS_GATE and the Test UI (…/16) rows but no row whose name is Build UI Deps.
Serial constraints cleared: none — none of the 35 open PRs touches scripts/pm/check-expected-skips.mjs; disjoint from the lane's other in-flight cards (#26143, #26066).

Generated by Claude Code

os-dev-report

{
  "issue": 26111,
  "status": "done",
  "branch": "claude/project-thread-smpt2w",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/26226",
  "session": "session_017uvfHxa7bTw2hqbZrfeCob",
  "premise_still_valid": true,
  "summary": "Added one roster row to scripts/pm/check-expected-skips.mjs: Build UI Deps (ci.yml job ui-deps) on UI_CONSUMERS_GATE (ui_tree, ui, ui_consumers), the shape Type Check UI and Build & E2E UI carry; hypothesis 1 held (the roster keys rows by the literal job name: string, and the job's if: spells all three outputs). Hypothesis 2 held: the live auditRoster pass in --self-test reaches the new row, and the deleted-job arm is kept and also driven on the new row. Four self-test cases added (same gate object as Type Check UI; deleted ui-deps job reds; if: without the ui_consumers half reds; a skipped Build UI Deps judges exit 0). Two header comments now count five ui jobs. Head 50b0a988.",
  "tests": "Before, origin/main fbb75998: node scripts/pm/check-expected-skips.mjs --pr 25973 -> 'unexpected skips (1) — outside the roster: Build UI Deps ... filter-miss' and 'VERDICT check-expected-skips: ⛔ 1 skipped check-run(s) outside main's roster (exit 4)', EXIT=4; same through --check-runs-json on the saved payload of PR 25973 head 1ccff6f5 (40 runs) -> exit 4. After, head 50b0a988: --check-runs-json on that payload -> 'VERDICT check-expected-skips: OK — 13 skipped check-run(s), every one in the roster (exit 0)', Build UI Deps [ci.yml › ui-deps] listed as expected; live --pr from the branch answers exit 3 by design until the row is on main, so the card's live criterion is read on main after landing. --self-test -> '173 cases pass', exit 0. Ablation (fix committed first; node scripts/ablation-replace.mjs renaming the row's name, anchor x1 -> x0, blob 9969d390 -> 3470ac59 -> restored 9969d390 = HEAD blob, git diff HEAD empty): self-test 5 of 173 failed (live audit + the four new cases), exit 1.",
  "gates": "dispatch-gates --commands --repo objectstack-ai/objectstack on head 50b0a988: 33 families (1 path, +16/-1). All 33 run locally, every exit code captured before any pipe = 0, including pnpm check:pm-dispatch-gates ('1917 cases pass', 418.9s, detached + tail --pid) and pnpm check:pm-expected-skips. --ran: '33 derived famil(ies) accounted for — 33 run, 0 NOT-MEASURED (a DERIVED zero)'. eslint --no-inline-config on the changed file under os-verify-lock: VERDICT command-exit 0. First head f85c0506 read check:pm-dispatch-gates red (1 of 1917: the marker census pins scripts/pm/check-expected-skips.mjs:137 self-test-reads, and a header line added above it moved it to 138); fixed in 50b0a988 by keeping the header the same length, not by touching the census pin (outside the claimed file surface). PR check-runs: in_progress at report time, not waited on.",
  "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
  "mcp_calls": "0 — no GitHub MCP calls (gh CLI GET reads only)",
  "api_writes": "2 relay strokes — POST /repos/objectstack-ai/objectstack/dispatches for pr_create (executed as POST /pulls, POST /issues/26226/assignees, POST /issues/26226/labels; read back identical, assignee os-warren, label skip-changeset) and POST /repos/objectstack-ai/objectstack/dispatches (or the post-stamped transport) for this report comment on #26111",
  "open_questions": [],
  "out_of_scope_findings": [
    "carrier: none · noted, not filed — scripts/pm/dispatch-gates.self-test.mjs pins the self-test-reads declaration in check-expected-skips.mjs by line number (:137), so any edit above that line in this file reds check:pm-dispatch-gates in an unrelated battery; recorded in the PR's Acceptance notes"
  ]
}

Deviation named: the dispatch order asks for pnpm lint green; os-dev.md (which wins) assigns repo-wide lint to CI, so the local run is eslint on the changed file and Lint & Repo Gates carries the repo-wide reading.

Generated by Claude Code

ACCEPT → PR #26226 comment 6421174385 · domain:skills#2 · 2026-10-26T16:21Z
Not governed: the seat readies and arms the PR through the relay on this record.

Generated by Claude Code

Landed · domain:skills#2 · session_01LqKsGyMNFwwnbF5FTAqyPn · 2026-10-26T17:02Z

probe	reading
PR #26226	`merged: true` at 2026-10-26T16:58:20Z, merge commit `eaf4f7a2`
`origin/main`	`git log origin/main --grep=26226` answers `eaf4f7a2` (`fix(pm): roster Build UI Deps in check-expected-skips`); `scripts/pm/check-expected-skips.mjs` carries the roster row `name: 'Build UI Deps'`, `job: 'ui-deps'`, `gate: UI_CONSUMERS_GATE`
merge queue	no `gh-readonly-queue/main/pr-26226-*` ref remains
card criterion, re-run on `main`	from a detached worktree at `origin/main` `f2e70836`: `node scripts/pm/check-expected-skips.mjs --pr 25973` exits 0 — `VERDICT check-expected-skips: OK — 13 skipped check-run(s), every one in main's roster`, with `×1 Build UI Deps [ci.yml › ui-deps]` listed under the rostered skips (before this landing the same read answered `filter-miss`, exit 4)

Landing path: not governed, under the size threshold — the seat's own review of record (ACCEPT, comment on the PR) at the default tier, readied and armed through the relay; followed to MERGED.

State: the card closed as completed through Fixes #26111; pm:dispatched removed in this act (the domain, area, type and priority labels stay). The body of #26226 closes no other card. The row is live on main: a skipped Build UI Deps beside a green battery now judges exit 0 instead of reading as an unexpected skip.

Note for the record, not a finding against this card: the same --pr 25973 read reports Check Changeset = failure under "other conclusions" — the bar's success half, outside this check's verdict and outside this card.

Generated by Claude Code

Navigation Menu

Repository navigation

check-expected-skips: `Build UI Deps` (new in #25963) is missing from the roster, so every PR whose ui scope is empty reads exit 4 #26111

Finding

Reproduction (origin/main `679fc7ce8`)

Fix (one executable criterion)

Triage: first grade — `bug` · `tooling` · `priority:p1` · `domain:skills` · `area:devpath` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-26T13:01Z

Dispatch order · `domain:skills#2` · `session_01LqKsGyMNFwwnbF5FTAqyPn` · 2026-10-26T15:30Z

Ruling (cannot be re-ruled)

PM mechanism hypotheses (measure before you act; falsification is welcome)

Card-specific clauses

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

check-expected-skips: Build UI Deps (new in #25963) is missing from the roster, so every PR whose ui scope is empty reads exit 4 #26111

Description

Finding

Reproduction (origin/main 679fc7ce8)

Fix (one executable criterion)

Activity

objectstack-fleet commented on Oct 26, 2026

Triage: first grade — bug · tooling · priority:p1 · domain:skills · area:devpath · pm:queue · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-26T13:01Z

objectstack-fleet commented on Oct 26, 2026

Dispatch order · domain:skills#2 · session_01LqKsGyMNFwwnbF5FTAqyPn · 2026-10-26T15:30Z

Ruling (cannot be re-ruled)

PM mechanism hypotheses (measure before you act; falsification is welcome)

Card-specific clauses

objectstack-fleet commented on Oct 26, 2026

objectstack-fleet commented on Oct 26, 2026

objectstack-fleet commented on Oct 26, 2026

objectstack-fleet commented on Oct 26, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

check-expected-skips: `Build UI Deps` (new in #25963) is missing from the roster, so every PR whose ui scope is empty reads exit 4 #26111

Reproduction (origin/main `679fc7ce8`)

Triage: first grade — `bug` · `tooling` · `priority:p1` · `domain:skills` · `area:devpath` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-26T13:01Z

Dispatch order · `domain:skills#2` · `session_01LqKsGyMNFwwnbF5FTAqyPn` · 2026-10-26T15:30Z