tooling: eslint.config.mjs is 1,271 lines of which 906 are four inline custom-rule plugins and 67% is comment — move the rules into a local eslint-plugin-objectstack workspace package with their own tests

Filing gate ③: a maintainer-directed task. Maintainer, 2026-10-26, verbatim: 「完整的评估本项目，还有哪些可以优化的地方。包括 ci 和文档」 then 「使用 pm-dispatch 技能创建 issue，需要决策的立为决策卡。」 and 「低优先级的先不考虑」. Batch-of: 19 (repository evaluation 2026-10-26, session_019a9XCWsbMFp75REzthE6cs; 9 decision cards + 10 execution cards). ⛔ Filed bare: grading, domain:* and area:* are triage's. ⛔ Not a claim. Reader: the domain:spec execution seat (packages/lint and gate tooling anchor there per the lane table; triage decides) — one os-dev, one PR. Dedupe: REST list (439 issues), grep eslint.config|eslint plugin → 0 hits. New.

谁付代价（业务筛）: a seat that wants to know why lint rejected a line opens a 69 KB config file and reads rule implementations inline; a change to a rule has no test but the config's self-assert; the actual configuration (eight objects, lines 939–1271) is the last quarter of the file.

Measured (HEAD `0d83ee8`)

eslint.config.mjs: 1,271 lines, 69,544 bytes; about 46.4 KB (67%) are comment lines.
Lines 1–906: four custom rule plugins written inline — slot-lookup (with scripts/slot-lookup-baseline.json, 25 files / 100 sites), query-options (scripts/query-options-erasure-baseline.json, 15 files / 50 sites), verify-stand-in, comment-swallow — plus a self-assert block.
Lines 939–1271: the config array, 8 objects; ignore lists are small (NEVER_LINTED 5 globs plus the two JSON baselines).
packages/lint exists and is the metadata linter (a different thing); a workspace-local ESLint plugin package does not exist. The ui tree has ui/eslint-rules/ as a folder of rule files, a lighter precedent.

Wanted

A private workspace package (e.g. tools/eslint-plugin-objectstack, "private": true, not published) holding the four rules, each with a RuleTester test file; eslint.config.mjs imports the plugin and keeps only configuration. ⛔ Behaviour-preserving: the baselines and every current verdict are unchanged — the dev proves it by running pnpm lint before and after and diffing the output.
Comments that explain a rule's history move with the rule (file header) or to the ADR that decided it; per docs: narrative cost — 42.5% of source lines are comments, workflows 58.6%, AGENTS.md is 103 KB with three stale claims, ROADMAP.md still says v3.3.2 and 80 Storybook stories #25919 ruling A (「存量不横扫」) no other comment is rewritten.
The self-assert block becomes the plugin's tests.

Acceptance

pnpm lint output identical before/after (0 errors both sides, same warning set); wc -l eslint.config.mjs under about 400.
The plugin's tests run in the lane where packages/lint tests run; pnpm typecheck covers the new package (coverage ratchet: new packages arrive covered).

Size: M. Clause-②: no. Metadata-protocol: none.

Triage: first grade — `tooling` · `tech-debt` · `priority:p2` · `domain:devx` · `area:devpath` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-26T12:13Z

⛔ Not a claim, ⛔ not a dispatch. On the maintainer's 「完整的评估本项目…」 / 「低优先级的先不考虑」 (repository evaluation, Batch-of 19). Low priorities were excluded at filing, so the execution cards grade p2.

Lane: the root eslint.config.mjs is repo tooling (domain:devx). These custom rules lint this repository's own code, not @objectstack/lint. Move them into a local workspace plugin with their own tests. The rule behaviour is unchanged, and the PR shows pnpm lint output identical before and after.

Generated by Claude Code

Claim: PM loop round 3 · 2026-10-26T13:35Z
Session: session_01Q4MDXRbEJCNdPAP4SiXwp9 (devx seat 2) · card thread session_01CHC483oAMSwyfmTu1xajpZ
Account: os-steve
Branch: claude/project-thread-qgt0lb (the harness-pinned branch of the card thread; it names no issue, so this claim is the identity record; amended on spawn)
Worktree: objectstack-issue-26093
Domain: domain:devx
Seat: domain:devx#2 (seat post #20163)
File surface: eslint.config.mjs, one new private workspace package for the four rules (under an existing pnpm-workspace.yaml glob, so the workspace file stays untouched) with its RuleTester tests, pnpm-lock.yaml only as pnpm install regenerates it, and scripts/ci/select-gate-families.sh + its .selftest.sh (widened by the seat's review on PR #26177: the move must keep both ratchets triggered by rule edits); ⛔ nothing under ui/, ⛔ no baseline file changed (stop on breach; explain in the report)
Container & model: M, mode:thread, model: default tier (TIER_DEFAULT, from dispatch-gates --tier: no path-derived mandate), effort: high
Clause-②: no
Metadata-protocol: none
Responsibility: n/a — not a defect card
Thread-read: 6415718360
Premise: holds (eslint.config.mjs on origin/main still carries the four inline plugins; not governed)
Serial constraints cleared: no other Claim: names eslint.config.mjs; #26082 (as-any rule) is an open decision and adds nothing until ruled; #26092 (this seat) touches tsconfig/vitest files, disjoint, and if both need the new package typechecked the later PR rebases

Generated by Claude Code

os-dev-report

{
  "issue": 26093,
  "status": "done",
  "branch": "claude/project-thread-qgt0lb",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/26177",
  "head": "4d18cf1c34",
  "session": "session_01CHC483oAMSwyfmTu1xajpZ",
  "premise_still_valid": true,
  "summary": "The four inline rule plugins (slot-lookup, query-options, verify-stand-in, comment-swallow) moved out of eslint.config.mjs into the private package packages/eslint-plugin (plain ESM, checkJs, no build). The config imports it by relative path and keeps only configuration. Rule ids, messages and namespaces are unchanged. The slot lists and the verify guarded set stay in the config and reach the rules as required options. The comment-swallow self-assert block became RuleTester and vitest cases. Every name the ratchet scripts import is still exported from the config. pnpm lint and all three ratchet outputs are byte-identical before and after.",
  "tests": "pnpm --filter @objectstack/eslint-plugin test: 4 files, 73 tests passed. pnpm --filter @objectstack/eslint-plugin typecheck (tsc --noEmit, checkJs): exit 0; --listFiles shows 5 src/*.mjs, 5 test/*.ts and vitest.config.ts. turbo run typecheck --filter=@objectstack/eslint-plugin: exit 0. pnpm lint at d1ea2363 and at 4d18cf1c34: exit 0 with no output on both sides, diff empty. check:slot-lookup, check:query-options-erasure, check:verify-stand-in: exit 0 at both commits, outputs diff empty (100 sites in 25 files; 50 non-test sites in 15 files plus 236 test sites in 47 files; 2 guarded, 10 call sites, 0 asserted). Test Core lane: partition-test-shards over turbo ls --affected places the package on shard 1/8. No ablation, because no tested behaviour changed (a move).",
  "gates": "dispatch-gates --commands --repo objectstack-ai/objectstack at 4d18cf1c34: 68 families, all run on that head with exit captured before any pipe, all exit 0. --ran reconciliation: 68 derived, 68 run, 0 NOT-MEASURED, 0 UNRUN. The build-reading families ran after a full pnpm build (119/119), and the plugin-teardown self-test ran after git fetch --unshallow. First run at 949d206b: check:cross-package-test-inputs and check:test-source-alias were exit 1, both caused by a moved test-data string containing an @objectstack/hono import line; fixed in 4d18cf1c34. CI check-runs: in_progress at report time.",
  "line_budget": "eslint.config.mjs 1271 -> 649 (225 code, 402 comment, 22 blank); card target about 400 not met, see deviations",
  "files_changed": [
    "eslint.config.mjs",
    "packages/eslint-plugin/package.json",
    "packages/eslint-plugin/tsconfig.json",
    "packages/eslint-plugin/vitest.config.ts",
    "packages/eslint-plugin/src/index.mjs",
    "packages/eslint-plugin/src/slot-lookup.mjs",
    "packages/eslint-plugin/src/query-options.mjs",
    "packages/eslint-plugin/src/verify-stand-in.mjs",
    "packages/eslint-plugin/src/comment-swallow.mjs",
    "packages/eslint-plugin/test/rule-tester.ts",
    "packages/eslint-plugin/test/slot-lookup.test.ts",
    "packages/eslint-plugin/test/query-options.test.ts",
    "packages/eslint-plugin/test/verify-stand-in.test.ts",
    "packages/eslint-plugin/test/comment-swallow.test.ts",
    "pnpm-lock.yaml"
  ],
  "deviations": [
    "wc -l eslint.config.mjs is 649, not about 400. The remaining 402 comment lines explain configuration (the lint-script stack-size header, the global-ignore history, scope and baselines), not rule history. Reaching about 400 means sweeping them, which #25919 ruling A and the dispatch's no-other-comment rule forbid. Comment-budget decision left to the seat.",
    "No reviewer request on the PR: the session default does it through an MCP write, which the dispatch forbids. The assignee os-steve was set at pr_create through the relay.",
    "Not merged with origin/main before pr_create: 17 commits landed since d1ea2363, none touching eslint.config.mjs, pnpm-lock.yaml, the baselines or the three ratchet scripts."
  ],
  "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
  "mcp_calls": "0 — card, comments and PR state read with gh api REST reads",
  "api_writes": "2 — pr_create (relay, PR #26177, body read back 7723/7723 bytes identical, labels skip-changeset, assignee os-steve), this os-dev-report comment (relay, post-stamped)",
  "open_questions": [],
  "out_of_scope_findings": [
    "class: none of a/b/c (gate-selection coverage gap created by this move; tooling) · reach: scripts/ci/select-gate-families.sh runs slot_lookup and query_options_erasure for packages/* only when is_ts_source, so a later PR that edits only packages/eslint-plugin/src/*.mjs skips both ratchet re-measures in CI. Before, the rules lived in eslint.config.mjs (root-config, which runs every family). Remaining CI coverage for such a PR: pnpm lint and the package's RuleTester suite. · carrier: seat (devx#2), suggested fix: add packages/eslint-plugin/* to both families' triggers · dedupe words: select-gate-families slot_lookup eslint-plugin mjs trigger"
  ]
}

Generated by Claude Code

os-dev-report

{
  "issue": 26093,
  "status": "done",
  "round": "patch round 1, answering seat review 6419089653 (REVISE)",
  "branch": "claude/project-thread-qgt0lb",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/26177",
  "head": "025d3287b7",
  "session": "session_01CHC483oAMSwyfmTu1xajpZ",
  "premise_still_valid": true,
  "summary": "Closed the gate-selection gap this PR opened. In scripts/ci/select-gate-families.sh the slot_lookup and query_options_erasure workspace arm now returns run for any packages/eslint-plugin/* path before the is_ts_source test, and the read-set header names the rules. scripts/ci/select-gate-families.selftest.sh gains a merge_group case: an added packages/eslint-plugin/src/rule.mjs selects query_options_erasure, slot_lookup and comment_mask_corpus, with both ratchet reasons naming the path. Existing cases are unchanged.",
  "tests": "bash scripts/ci/select-gate-families.selftest.sh: all 60 cases passed (310 checks). Reverse verification with the fix committed first: deleting the new case arm (grep count 0 on disk) turned the new case red (got slot_lookup=skip query_options_erasure=skip) and the suite exit 1; restored with git checkout HEAD, blob hash equal to HEAD, and git diff HEAD empty.",
  "gates": "dispatch-gates --commands --repo objectstack-ai/objectstack at 025d3287b7: 85 families (68 before, plus 17 the scripts/ci edit pulls in, among them check:select-gate-families, check:pm-dispatch-gates, check:entry-guard, check:self-test-workflow-commands). All 85 run on that head, all exit 0. --ran: 85 derived, 85 run, 0 NOT-MEASURED. CI check-runs: in_progress at report time.",
  "line_budget": "eslint.config.mjs 649 (accepted as measured by the seat ruling in 6419089653)",
  "files_changed": [
    "scripts/ci/select-gate-families.sh",
    "scripts/ci/select-gate-families.selftest.sh"
  ],
  "deviations": [
    "PR body not edited: os-dev allows the dev one body write, at pr_create. Line for the seat to add under Acceptance, verbatim: 'wc -l eslint.config.mjs = 649, accepted as measured by the seat (review 6419089653): the remaining comments explain configuration and #25919 ruling A forbids sweeping them.' The Acceptance notes bullet on gate selection is now fixed by 025d3287b7, not an open finding."
  ],
  "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm",
  "mcp_calls": "0",
  "api_writes": "3 in total — pr_create, the first os-dev-report comment, this round comment (relay, post-stamped)",
  "open_questions": [],
  "out_of_scope_findings": []
}

Generated by Claude Code

devx seat 2 · review: ACCEPT → PR #26177 comment 6419670995. Landing: ready + merge queue, every check on the reviewed head green or skipped.

Generated by Claude Code

Navigation Menu

Repository navigation

tooling: eslint.config.mjs is 1,271 lines of which 906 are four inline custom-rule plugins and 67% is comment — move the rules into a local eslint-plugin-objectstack workspace package with their own tests #26093

Measured (HEAD `0d83ee8`)

Wanted

Acceptance

Related

Triage: first grade — `tooling` · `tech-debt` · `priority:p2` · `domain:devx` · `area:devpath` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-26T12:13Z

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

tooling: eslint.config.mjs is 1,271 lines of which 906 are four inline custom-rule plugins and 67% is comment — move the rules into a local eslint-plugin-objectstack workspace package with their own tests #26093

Description

Measured (HEAD 0d83ee8)

Wanted

Acceptance

Related

Activity

objectstack-fleet commented on Oct 26, 2026

Triage: first grade — tooling · tech-debt · priority:p2 · domain:devx · area:devpath · pm:queue · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-26T12:13Z

objectstack-fleet commented on Oct 26, 2026

objectstack-fleet commented on Oct 26, 2026

objectstack-fleet commented on Oct 26, 2026

objectstack-fleet commented on Oct 26, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Measured (HEAD `0d83ee8`)

Triage: first grade — `tooling` · `tech-debt` · `priority:p2` · `domain:devx` · `area:devpath` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-26T12:13Z