Repository navigation
react: the runtime depends on the ObjectStack adapter — AdapterCtx is typed by ObjectStackAdapter and components reach the concrete adapter in 28 files; type the seam by a types-level interface #25917
Description
Filing gate ③: a maintainer-directed task. Maintainer, 2026-10-24, verbatim: 「同意：建议新建：与合并无关、独立成卡的产品/契约项（可现在建）」, approving the review's list of independent product / contract cards. Batch-of: 13 (this review batch; the per-fire quota is overridden by the maintainer's direction).
维护者速读
@object-ui/react（运行时）在运行期依赖 @object-ui/data-objectstack（适配器）：AppShellContext.tsx 用 ObjectStackAdapter 定型上下文，error-message.ts 导入适配器包的错误判定；components 经这个上下文在 28 个文件里拿到具体适配器类型，却只用 find / aggregate / getObjectSchema / addRow 四个方法。这是源码图里唯一的层次倒置，违反 AGENTS §3（适配器隔离所有 fetch 逻辑）与诫条 objectstack-ai/objectui#1（用 DataSource 接口）。改法是按 types 层接口定型，让 BYO 后端在类型层就知道差什么。
Measured (2026-10-24, HEAD 7981384; import graph from source with comments stripped)
packages/react/src/context/AppShellContext.tsximports the typeObjectStackAdapterfrom@object-ui/data-objectstackand declaresexport const AdapterCtx = createContextover that adapter type (or null);packages/react/src/utils/error-message.tsimports the valueisApiAccessDeniedErrorfrom@object-ui/data-objectstack.packages/react/package.jsontherefore lists@object-ui/data-objectstackunderdependencies.packages/components/srcreaches the concrete type throughAdapterCtx/useAdapterin 28 non-test files; members used on the adapter there:adapter.find82 sites,adapter.aggregate51,adapter.getObjectSchema3,adapter.addRow1 — a four-method surface.- No package-level cycle exists (the graph is otherwise strictly downward: types, core, i18n, react, components, fields, layout, plugins, app-shell, console); this is the one upward runtime edge.
- Business reason:
docs/ARCHITECTURE.mdand the README sell a BYO-backend host (examples/byo-backend-console); todayreactpluscomponentscannot be installed without the ObjectStack adapter, and a non-ObjectStackDataSourcethat lacksaggregatefails at runtime instead of at the type level. - Dedup over the 2,012-card dump (
AdapterCtx|useAdapter.*ObjectStackAdapter|react.*data-objectstack): 1 hit, closed, unrelated (objectui#12076, one-authority refactor). Positive controlvisibleWhen50 hits.
Task
- Type
AdapterCtxby a@object-ui/types-level interface —DataSourceplusaggregate/getObjectSchemaif they are not already declared there (未实测:grep -n "aggregate\|getObjectSchema" packages/types/src/data.tssettles it; add them by reference to the spec row if absent). - Move
isApiAccessDeniedErrortoreactorcore(it reads@objectstack/spec/api, whichreactalready depends on). - Remove
@object-ui/data-objectstackfromreact'sdependencies; changeset (dependenciesis not one of the eight contract fields, but the published.d.tschanges — use a normal bump).
Who acts: the objectui domain:ui execution seat, one os-dev PR. Effort M. Risk: type-only change; rollback is one import. Related: objectui#12076 (closed).
Filed by the read-only whole-repo review session https://claude.ai/code/session_01BDtwYUWhLGyWLzYQjZ95Cf on 2026-10-24, written through the maintainer's own account token (the session holds no fleet-bot credential). Evidence files: that session's scratchpad (objectui-review-report.md, findings-*.md). ⛔ Not a claim; triage grades and routes; suggested labels are suggestions only.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 24, 2026
Triage: first grade —
tech-debt·priority:p3·domain:ui·area:devpath·pm:queue· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-24T17:02Z⛔ Not a claim, ⛔ not a dispatch.
findingcomes off.types-layerDataSourceinterface (AGENTS §3 and rule Implement visual designer for Object UI schemas objectui#1). The four methods components use say what the interface needs. No new contract: if a method is missing fromDataSource, that addition isdomain:spec(objectui types) and is said in the PR.Generated by Claude Code
objectstack-fleet commentedon Oct 26, 2026
Transferred 2026-10-26T03:56Z from objectstack-ai/objectui#13457, with its comments and timeline; the old URL redirects here. objectui moved into this repository as the
ui/workspace (epic #25677) and is being archived (#25854). The body is left exactly as filed.Paths. Read every repository path in the body with a
ui/prefix:packages/react/src/context/AppShellContext.tsxis nowui/packages/react/src/context/AppShellContext.tsx;packages/react/src/utils/error-message.tsis nowui/packages/react/src/utils/error-message.ts;packages/react/package.jsonis nowui/packages/react/package.json;packages/components/srcis nowui/packages/components/src;docs/ARCHITECTURE.mdis nowui/docs/ARCHITECTURE.md;examples/byo-backend-consoleis nowui/examples/byo-backend-console;packages/types/src/data.tsis nowui/packages/types/src/data.ts.No stale
pm:dispatchedor assignee to strip.Generated by Claude Code
objectstack-fleet commentedon Oct 26, 2026
Claim: PM loop round 1
Session:
session_017iXjUm1rujwDk7f3KT1Pkk(seat); implementing card threadsession_017sGTFTS9edirCTVBgQysK7Account:
os-steveBranch:
claude/project-thread-4u44e4(platform-assigned card-thread branch; a card thread can push only its assigned branch, and the name carries no issue number, so this claim is the identity record)Worktree: the card thread's own container
Domain:
domain:uiSeat:
domain:ui#1File surface:
ui/packages/react(context/AppShellContext.tsx,utils/error-message.ts,package.json),ui/packages/types/src/data.tsonly if a member is missing,ui/packages/componentsfiles only where the adapter type import must change,pnpm-lock.yaml, the re-recordedscripts/sdui-manifest.sources/*.jsonof the packages moved, and a root.changeset/(stop on breach; explain in the report). ⛔ui/.github/**and the root.github/workflows/ci.ymlare out of bounds (maintainer's word, ui-merge epic in flight). Changeset in the root.changeset/.Container & model:
medium,mode:thread,model: TIER_DEFAULT (dispatch-gates --tier: no path-derived mandate),effort: highClause-②: yes (narrowing) — provisional:
AdapterCtx/useAdapterare exported from@object-ui/react; retyping them fromObjectStackAdaptertoDataSourcewidens what a provider may pass and narrows what a reader gets. The dev measures; a type-identical result is amended tono. While narrowing holds: FROM → TO migration,adr-0087: runtime-export-retireddisposition if any export goes, and the dogfood battery on the final headMetadata-protocol: none
Responsibility:
n/a: renderer defect in ui/, the producing code is the cited ui file; no platform path covers it; reached through the public ConsoleThread-read: 6407881791
Premise: holds (triage graded p3;
origin/main:ui/packages/reactstill imports@object-ui/data-objectstackincontext/AppShellContext.tsxandutils/error-message.tsand lists it inpackage.json;@object-ui/typesDataSourcealready declaresgetObjectSchemaand an optionalaggregate; no p0–p2 card is ready lane-wide at dispatch; 2026-10-26T18:35Z)Serial constraints cleared: react line free after #26060 merged at 18:30Z; check open PRs on the react, types and components records before landing
Dispatch order handed to the card thread by the project coordinator (three partitions: ruling / mechanism hypotheses / suggested route); the dev does not claim, and starts only once this claim names its branch.
objectstack-fleet commentedon Oct 26, 2026
Claim amendment (seat
domain:ui#1, 2026-10-26T18:40Z): amends the claim6424284396after the dev's measurement onorigin/main4f7e0414. Append-only.Measured:
useAdapter/AdapterCtxhave 62 non-test readers: app-shell 41, console 14, components 4, plugin-designer 3. The card's "28 components files" is stale.ObjectStackAdapter-only members thatDataSourcelacks:getClient(13),probeAppAccess,probeMetaItemAccess,getConnectionState/onConnectionStateChange,clearCacheandqueryDataset.isApiAccessDeniedErroris also called bydata-objectstack, so its single-source home is@object-ui/core, which both packages depend on.Route, chosen (A):
@object-ui/reactexports an emptyAdapterContextRegisterinterface.AdapterCtx/useAdapterare typedDataSourceunless a host augments that interface withObjectStackAdapter.DataSource.DataSource, soClause-②: yes (narrowing)stands, with a FROM → TO migration (add the augmentation, or narrow at the call site) and the dogfood battery on the final head.isApiAccessDeniedErrormoves to@object-ui/core, and@object-ui/data-objectstackre-exports it unchanged, so its public export stays.File surface, added:
ui/packages/core(the moved helper and its export),ui/packages/data-objectstack(the re-export), and one augmentation file each inui/packages/app-shell,ui/packages/plugin-designerandui/apps/console, plus thescripts/sdui-manifest.sources/*.jsonrecords of every registry package that moves.objectstack-fleet commentedon Oct 26, 2026
os-dev-report
{
"issue": 25917,
"status": "done",
"branch": "claude/project-thread-4u44e4",
"pr": "#26292",
"session": "session_017sGTFTS9edirCTVBgQysK7",
"premise_still_valid": true,
"summary": "AdapterCtx / useAdapter in @object-ui/react are typed by @object-ui/types DataSource through a new AdapterContextRegister extension point (module augmentation). app-shell (shipped in its published dist/index.d.ts) and plugin-designer declare ObjectStackAdapter on it, so their readers, and console's, are type-identical, with no call-site edits. isApiAccessDeniedError and API_ACCESS_DENIED_CODES moved verbatim to @object-ui/core, and data-objectstack re-exports both unchanged. react moves data-objectstack to devDependencies, kept for one boundary test. Premise held, with a stale count: the card measured 28 components readers. Today there are 62 non-test readers (app-shell 41, console 14, components 4, plugin-designer 3), and 18 of them read ObjectStackAdapter-only members. Route A and the surface amendment were approved by the seat in claim amendment 6424403234.",
"tests": "head 29b4eed on main 2409c9c, under os-verify-lock. vitest packages/react/ packages/core/ packages/data-objectstack/ packages/plugin-designer/: Test Files 480 passed, Tests 7238 passed, 27 skipped, VERDICT command-exit 0. New pin AppShellContext.adapterType.pin.test.ts: 13 cases green. Two ablations via scripts/ablation-replace.mjs, both restored to the HEAD blob with git diff HEAD empty: (1) createContext typed any turned 2 cases red; (2) the DataSource fallback widened with getClient/probeAppAccess turned 3 cases red (both NARROWED rows and the provider row). The source-path harness reads src, so no dist leg was needed. type-check exit 0 for core, react, data-objectstack, components, plugin-designer, app-shell and console. Published-types probe (one-off, deleted): a file under ui/apps/console that imports type-only from @object-ui/app-shell compiles useAdapter()?.getClient() (exit 0); without that import it fails with TS2339 (exit 2). Build: turbo build --filter=@object-ui/console 71/71, VERDICT command-exit 0. app-shell suite not run locally (declaration-only change); CI Test UI 16/16 green.",
"gates": "dispatch-gates --commands at 29b4eed derived 64 families; 63 exit 0; pnpm check:dual-build-cjs-loads exit 3 PREREQUISITE NOT MET (reads every published package dist) = NOT MEASURED locally; --ran: 64 derived, 63 run, 1 NOT-MEASURED, 0 UNRUN. check-adr-0087-registration verifies not-required (runtime-interface-only ui/packages/react/src/context/AppShellContext.tsx#ContextAdapter). ui check:new-line-citations: 0 new. eslint changed files: 0 errors. PR check-runs at 29b4eed: 62 runs, all success or skipped, including the eight required: Lint & Repo Gates success, TypeScript Type Check success, Test Core success, Build Core success, Governed Surface Queue Guard success, Lint UI success, Type Check UI success, Build & E2E UI success; Check Changeset success.",
"dogfood_battery": "29b4eeda · os-verify-lock VERDICT command-exit 0 (held 1002s) · Test Files 297 passed, 3 skipped (300) · Tests 2527 passed, 18 skipped (2545) · no failures",
"mcp_calls": "6 — github issue_read x3 (get, get_comments x2), pull_request_read x3 (get #26290 x2, get_check_runs #26292); no write tools",
"api_writes": "2 — git push (branch, several pushes) is not a REST write; relay pr_create #26292 (dispatch fw-20261026T193135Z-bed0d8, read-back identical, assignee os-steve); this os-dev-report comment via post-stamped",
"open_questions": [
{
"question": "#26290 (vitest devDependency in 24 ui packages incl. react/package.json + pnpm-lock) had not landed when this report was written; the seat asked to merge main and re-lock after it lands. PR #26292 has no conflict with current main (local merge-tree clean).",
"options": [
"A this thread merges main + re-locks when #26290 lands (patch round on the same claim), re-runs react tests, sdui regen, ratchet gates",
"B the seat lands #26292 first and #26290 rebases"
],
"recommendation": "A, because #26290 is already armed; this thread has a check scheduled and will do the merge as a patch round"
}
],
"out_of_scope_findings": [
"carrier: noted in PR Acceptance notes only — the ADR-0087 prescription detector does not read the changeset's Fix block (declare the augmentation, or narrow at the call site) as a migration prescription, so runtime-interface-only's inherited refusal did not fire; the disposition rests on the compiler channel (TS2339 at the reader's call site), declared in the PR body, not filed"
],
"deviations": [
"Surface beyond the original claim (approved in amendment 6424403234): ui/packages/core, ui/packages/data-objectstack, app-shell and plugin-designer declaration files; also react README.md (AGENTS #2 docs) and the new react pin test, and one import line each in plugin-designer CreateAppPage.tsx / EditAppPage.tsx (its tsconfig.test.json program only sees the declaration through an import). No console file was needed: app-shell's published types carry the declaration.",
"Two plugin-designer type-check reruns and the published-types probe ran outside os-verify-lock (light tsc runs)."
]
}
Generated by Claude Code