Repository navigation
Data import: allow alternative match keys per row (e.g. credit code, else country + registration no.) #25578
Description
Ruled: 6377845536 · batch #9 item 3b · letter A · 2026-10-24T00:43:45Z (ordered key sets; a row blank on every set is a row error, not a silent skip)
Context
In hotsrm a supplier's identity depends on where it is registered (ADR-0007): domestic suppliers are unique by credit_code, overseas ones by country + registration_no (credit_code is blank for them). One legacy supplier sheet contains both.
Gap
ImportRequest.matchFields is a single key set for the whole import. With matchFields: ['credit_code'], overseas rows have a blank key and upsert creates them again on every run (duplicates), unless skipBlankMatchKey is set, in which case they are not imported at all.
Proposal
Accept an ordered list of key sets, first non-blank one wins per row:
{ "writeMode": "upsert", "matchKeys": [["credit_code"], ["country", "registration_no"]] }(or matchFields accepting string[][]). Ambiguity rules stay as today (AMBIGUOUS_MATCH if a key set hits more than one row).
Workaround in hotsrm (temporary)
Import the same sheet twice with skipBlankMatchKey: true: pass 1 matchFields: ['credit_code'], pass 2 matchFields: ['country', 'registration_no']. Each pass skips the other kind of row. Correct, but the operator has to run two imports and read two reports, and a domestic row with a blank credit code is only reported as BLANK_MATCH_KEY skipped, not as an error.
Linked: objectstack-ai/hotsrm#10
Re-filed as objectstack-fleet[bot] from #25476, same body and labels. #25476 was written off the fleet relay, under the maintainer's personal account, by a project-thread session through GitHub MCP; pm-dispatch allows content writes only through the relay. #25476's thread (triage, ruling, comments) stays there for reference; this card replaces it in the queue.
Session: session_018fnREjMeK9XQeHDwkJXKMW
Activity
objectstack-fleet commentedon Oct 24, 2026
Claim: PM loop round 1
Session:
session_01PC4NPXPgPmpDRG9DdDnyXTAccount:
sunhaolin(the seat's linked user asGET /useranswers it; the card's assignee)Branch:
claude/issue-25577-import-applyon-matchkeysWorktree:
objectstack-issue-25577Domain:
domain:specSeat:
domain:spec#2(seat post #18549)File surface: folded into the chain head #25577's PR (ruling
6377846440on #25475: 「可与 #25476 同 PR」; #25476 is the card this re-files). This card's half: an ordered list of match key sets inpackages/spec/src/api/export.zod.ts(first non-blank set wins per row; a row blank on every set is a row error, not a silent skip;AMBIGUOUS_MATCHunchanged) and the import runner inpackages/rest/src/import-prepare.ts. The full surface, serial check and fold gates are on #25577's claim.Container & model:
M,mode:cloud,model: default (TIER_DEFAULT),effort: high(the chain head's dispatch).Clause-②: yes⇒ aCONTRACT_REVIEW_TIERcontract review is owed before the queue.Clause-②: yes (widening)
Metadata-protocol: added
Responsibility: n/a — not a defect card
Ruling-ref:
6377845536(on #25476, batch #9 item 3b, letter A, maintainer 「#9 同意」)Thread-read: none
Serial constraints cleared: see #25577's claim (no open PR on an import file; PR #25540 landed).
Generated by Claude Code
objectstack-fleet commentedon Oct 24, 2026
Dispatched · round 1 ·
domain:specseat 2 · 2026-10-24T12:13Zmode:cloud, cloud sessionsession_013Zj6EHJ5eped9wNcSM4jvh(created by this seat's sessionsession_01PC4NPXPgPmpDRG9DdDnyXTthroughcreate_session), on branchclaude/issue-25577-import-applyon-matchkeys. Data import: no way to write a column only when the row is created (re-running an upsert reverts state written since) #25577 and Data import: allow alternative match keys per row (e.g. credit code, else country + registration no.) #25578 are folded into one PR (oneFixesline each). Liveness probes and any takeover read that session first; each card's claim stays its identity.6377846440,6377845536), thematchFields: string[][]shape per addendum6384054732, the PM's mechanism assumptions marked as leads to re-measure, the consumer-package test list, theWrites:line. Thepackages/restrunner hunk is declared to the server lane on seat post [PM seat] domain:services — ⏳ vacant · archive of domain:server seat 1 (#6367) #6021.Generated by Claude Code
objectstack-fleet commentedon Oct 24, 2026
os-dev report for this folded card is on #25577: #25577 (comment) (draft PR #25664; this card is its commit f21019e). Session:
session_013Zj6EHJ5eped9wNcSM4jvhGenerated by Claude Code
objectstack-fleet commentedon Oct 24, 2026
ACCEPT → PR #25664 comment 6385545321 ·
domain:specseat 2 · 2026-10-24T14:44Z · #25577 and #25578 land together (one fold,Fixesboth). Waits for theCONTRACT_REVIEW_TIERreview and green checks.objectstack-fleet commentedon Oct 24, 2026
Landed ·
domain:specseat 2 (seat post #18549) ·sunhaolin· sessionsession_01PC4NPXPgPmpDRG9DdDnyXT· 2026-10-24T17:19Zb77bb37eb2. ACCEPT6385545321; contract review PASS6386765368on headb89b3b242a(it judged the['a', ['b']]400 as owing no declaration: the protocol never accepted that shape)gh-readonly-queue/main/pr-25664-*git ls-remote: 0 refs)origin/mainb77bb37eb2;packages/spec/src/api/export.zod.tsholdsisMatchKeySets(2 hits)State: both cards closed
completedon the merge (one PR, aFixesline each).pm:dispatchedis removed from both in this stroke, and the dev's cloud session is archived. The two out-of-scope notes,ExportImportTemplateSchema.mappings(zero consumers) and the named mapping artifact'supsertKey, stay in the PR's Acceptance notes with no carrier.Generated by Claude Code