Skip to content

check-governed-queue-guard: a PR landed from a project thread needs a review of record whose Reviewed-by session belongs to a different account from the PR's attribution github_login, else Tier S does not enqueue (maintainer's word 2026-10-23) #25415

Open

Description

@objectstack-fleet

Filing gate ③: a maintainer-direct task, the maintainer's words quoted verbatim. Filed from the Claude Code project "Objectstack" (account os-elon-musk) by the research thread 车队机制迁往 Projects on the maintainer's word there. ⛔ Not a claim. Lane self-applied under exception 二; grade suggested p2 · S; triage may regrade.

Reader (who acts): the domain:devx seat 1 (seat post #6023), as an in-seat subagent S card on scripts/pm/check-governed-queue-guard.mjs (+ record-recognisers.mjs if the account line needs a reader). Not .claude/**; ordinary queue landing. Pairs with the skills card that writes the rule into contract-review.md; this card enforces it.

The maintainer's words (2026-10-23, project thread 车队机制迁往 Projects, verbatim)

我的账户清单不固定的, 20x 周流量用完了,我就会换另外一个账户。 (06:27Z)
具体的分配应该是我人工制定的。 (06:27Z)
元数据项目应该各自分诊,但是决裁可以统一报总监。 (06:32Z)
管理者不是 bill 是 hotlong / 或者你不要强调是谁 (11:45Z, 11:46Z)
全项目并发上限 6 (11:46Z)
分诊不忙不如留给总监管 (12:08Z)
如果我同意这一整套机制,相关的 skills 是不是都要修改,文件应该落在仓库中 (12:10Z)
你立卡并派发处理所有相关任务,跟踪落地 (12:13Z)

The research memo these cards implement: https://claude.ai/artifact/VFTHWcmKkzbah17UM8KRqm (sections 6, 10–13; private to the maintainer's account).

What was measured

Wanted

  • When the PR body carries the attribution line, the review of record must carry a Reviewed-by-account: key line (or an equivalent the skills card settles on) whose login ≠ the attribution login; equal or absent ⇒ the Tier S enqueue leg is refused with a prescription naming both logins and the rule. PRs without an attribution line (Routine seats, humans) keep today's behaviour.
  • Self-test cases: equal logins refused; different logins pass; missing account line on an attributed PR refused; unattributed PR unchanged.
  • --pair landing pre-check prints the two logins it compared.

Acceptance

Dedupe

MCP search_issues, objectstack, "governed queue guard reviewer account must differ from PR author attribution github_login independence check" → 39 hits; top: #25199 (closed, objectui Tier S route), #25220 (open, attribution line exemption — this card READS that line), #18382, #18020 (closed), #18068 (closed, write-identity locks: 「user accounts limited to assignee and approval」 — the invariant this card enforces mechanically), #15187, #11083, #8161 (closed, GitHub forbids self-approval), #25364, #25070. None compares the reviewer's account to the author's. New.

Dedupe words: queue guard Reviewed-by account ≠ attribution login.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Oct 23, 2026

    @objectstack-fleet
    ContributorAuthor

    Claim: PM loop round 3 · 2026-10-23T13:05Z
    Session: session_0186iLxsmzoYpA9qHMo7Stku (card thread, dispatched by seat session session_01LKHDniRQSWjRJyDtacwpEd)
    Account: os-elon-musk
    Branch: claude/project-thread-shhfww (the harness-pinned branch for the card thread; it names no issue, so this claim is the identity record)
    Worktree: objectstack-issue-25415
    Domain: domain:devx
    Seat: domain:devx#1 (seat post #6023)
    File surface: scripts/pm/check-governed-queue-guard.mjs, plus scripts/pm/record-recognisers.mjs only if the account line needs a reader, with self-test cases. ⛔ No .claude/**. (stop on breach; explain in the report)
    Container & model: S, mode:thread, model: default tier, effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: the Tier S queue entry | check-governed-queue-guard.mjs (review-of-record reader) | every PR landed from a project thread
    Thread-read: none
    Serial constraints cleared: pairs with skills card #25414 (the rule text). Use the key name #25414 settles, else Reviewed-by-account:.

    Dispatched under the maintainer's 「同意」 to the director's ruling batch 1, item 5A (devx dispatches p1–p3). This card is also covered by the maintainer's 「同意,立卡」 for the CI performance audit cards, where the card says so. Dispatch order: /mnt/project-files/pm-devx-seat/dispatch-25415.md.

  2. objectstack-fleet commented on Oct 23, 2026

    @objectstack-fleet
    ContributorAuthor

    ACCEPT (seat review) → PR #25436 · domain:devx seat 1 · session_01LKHDniRQSWjRJyDtacwpEd · 2026-10-23T15:00Z · ⏸ landing held: serial after #25422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions