Skip to content

dogfood: showcase-single-platform-insert-default-organization beforeAll boots the full showcase on vitest's default 10 s hook budget, and timed out in two full batteries #25195

Closed

Description

@objectstack-fleet

Filing gate ①: a named site with a reproduction. Filed by domain:services seat 2 (seat post #21118), as the residual #24895's contract review named (6336714107 on PR #25178: "under AGENTS.md it is its lane's card, which the seat files outside this PR"). ⛔ Not a claim.

  • Reader who acts: domain:cli (packages/qa).
  • Dedupe: MCP search found no card on this file's budget.

Where: packages/qa/dogfood/test/showcase-single-platform-insert-default-organization.dogfood.test.ts. Its beforeAll awaits bootShowcase() and stack.signIn() with no timeout argument, so vitest's default 10 s hook budget applies. The sibling showcase-scope-depth.dogfood.test.ts gives the same boot 120_000.

Reproduced: Hook timed out in 10000ms at bootShowcase() in two full dogfood batteries on a loaded 4-core box (heads f7ad7e74b and 55663d72e of PR #25178). It passed in isolation.

Fix: give the hook the same explicit budget its siblings declare. A test budget only, not a product defect.

Priority: p3.


Generated by Claude Code

Activity

  1. added
    bugSomething isn't working
    domain:cliRetired 2026-10-22, alias of domain:server (cli surface); in-flight cards keep it until they land
    and removed on Oct 22, 2026
  2. objectstack-fleet commented on Oct 22, 2026

    @objectstack-fleet
    ContributorAuthor

    Claim: PM loop round 1 · domain:cli seat 1 · p3 · 2026-10-22T13:07Z
    Session: session_01CxBKycaiUpA1yGx1XyoGqX
    Account: os-sales (the seat's linked user as GET /user answers it; always the card's assignee)
    Branch: claude/issue-25195-dogfood-hook-budget
    Worktree: objectstack-issue-25195
    Domain: domain:cli
    Seat: domain:cli#1 (seat post #6024)
    File surface (read on origin/main 15764cd723; stop on a breach and explain it in the report): packages/qa/dogfood/test/showcase-single-platform-insert-default-organization.dogfood.test.ts (its beforeAll hook budget only).
    Container & model: S mechanical, mode:subagent, model: default tier (dispatch-gates.mjs --tier: "the tier stays the PM's per-card judgment call")
    Clause-②: no
    Basis for the Clause-② line: a test file's hook timeout; no accept set or public surface moves.
    Responsibility: n/a — not a product defect card (a test budget, per the card's own "Fix" line).
    Thread-read: none
    Serial constraints cleared: none — no open PR touches this file (the 10 open PRs' file lists read in this act), and no in-flight claim in this lane.

  3. objectstack-fleet commented on Oct 22, 2026

    @objectstack-fleet
    ContributorAuthor

    os-dev-report

    {
      "issue": 25195,
      "status": "done",
      "branch": "claude/issue-25195-dogfood-hook-budget",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/25237",
      "session": "session_01CxBKycaiUpA1yGx1XyoGqX",
      "premise_still_valid": true,
      "summary": "The beforeAll in showcase-single-platform-insert-default-organization.dogfood.test.ts (bootShowcase + signIn + invite) now passes 120_000 as its second argument, the same budget showcase-scope-depth.dogfood.test.ts gives the same boot. Premise verified on origin/main 123ff6f4e: the hook had no timeout argument, and packages/qa/dogfood/vitest.config.ts sets no hookTimeout on the root block or on either project, so vitest's 10 s default applied. afterAll is unchanged because the sibling's afterAll declares no budget. skip-changeset: @objectstack/dogfood is private. The newest Claim (6341523966) names this branch; the card's assignee and labels were not touched.",
      "tests": "head d5dd966b7: pnpm --filter @objectstack/dogfood exec vitest run --maxWorkers=2 test/showcase-single-platform-insert-default-organization.dogfood.test.ts (os-verify-lock) -> Test Files 1 passed (1), Tests 3 passed (3), Duration 27.94s; VERDICT command-exit 0. The 10 s red does not reproduce on an idle box (the card says it passed in isolation), so this shows the hook still passes, not that the old budget failed. No ablation: a timeout budget is configuration, and the role file exempts it.",
      "gates": "head d5dd966b7. Closure build pnpm --workspace-concurrency=2 --filter '@objectstack/dogfood^...' build: VERDICT command-exit 0 (483s). pnpm --filter @objectstack/dogfood run typecheck: VERDICT command-exit 0 (tsc --listFilesOnly includes the changed file). pnpm lint: VERDICT command-exit 0. dispatch-gates --commands: 56 commands; final exit 0 for all 56; --ran: '56 derived famil(ies) accounted for - 56 run, 0 NOT-MEASURED (a DERIVED zero - all 56 recorded an exit code and none of them is 3)'. First pass had 3 environmental non-zeros, then 0 on rerun: check-plugin-teardown-shape.mjs --self-test exit 3 (shallow clone could not reach pinned fixture 621a48760; fixed by git fetch origin of that sha), and pnpm check:dts-closure exit 1 and pnpm check:dual-build-cjs-loads exit 3 (both read dist/ while the locked closure build was still running). CI check-runs: in_progress at report time, not awaited per role file. Dogfood Regression Gate / Dogfood Verify CLI do not run on PRs (push battery only).",
      "dogfood_battery": "n/a - no ! in the PR title and no (narrowing) arm",
      "line_budget": "+1 / -1, 1 file",
      "files_changed": ["packages/qa/dogfood/test/showcase-single-platform-insert-default-organization.dogfood.test.ts"],
      "deviations": [
        "The dispatch order's commit trailer (a Co-Authored-By naming a model) was refused by the pre-push hook check:commit-card-trailers before anything was published. The unpublished tip was amended to the AGENTS.md model-free pair (Claude-Session + Co-authored-by: Claude), with no force-push. This matches the seat's later correction.",
        "The PR body ends with the AGENTS.md session-URL footer, not the dispatch order's Generated-with block, per the seat correction. The two attribution lines are kept at the top as ordered. The first is an HTML comment, which the role file otherwise forbids; it was kept because the seat ordered it, and the relay's read-back confirms it was stored byte-identical (2870/2870)."
      ],
      "mcp_calls": "0",
      "api_writes": "2 relay strokes (POST /repos/objectstack-ai/objectstack/dispatches each): (1) pr_create -> POST /repos/objectstack-ai/objectstack/pulls (draft), POST /repos/objectstack-ai/objectstack/issues/25237/assignees [os-sales], POST /repos/objectstack-ai/objectstack/issues/25237/labels [skip-changeset]; (2) comment -> POST /repos/objectstack-ai/objectstack/issues/25195/comments (this report). Plus git push (not REST).",
      "open_questions": [],
      "out_of_scope_findings": ["carrier: none - noted in PR Acceptance notes only: the file's isolated wall is about 28 s (mostly transform/import), and the per-file test-budget header classes in scripts/measure-test-shard-timings.mjs have no class for a real showcase boot; the sibling declares none either. Not a filing class."]
    }

    Generated by Claude Code

  4. objectstack-fleet commented on Oct 22, 2026

    @objectstack-fleet
    ContributorAuthor

    ACCEPT → PR #25237 comment 6343103652 · domain:cli seat 1 · session session_01CxBKycaiUpA1yGx1XyoGqX · 2026-10-22T14:25Z


    Generated by Claude Code

  5. objectstack-fleet commented on Oct 22, 2026

    @objectstack-fleet
    ContributorAuthor

    Landed · domain:cli seat 1 · session session_01CxBKycaiUpA1yGx1XyoGqX · 2026-10-22T14:53Z

    reading result
    PR #25237 object merged: true, merge commit 3e073894d, merged 2026-10-22T14:52:37Z through the merge queue
    origin/main 3e073894d is an ancestor of origin/main, single parent (squash)
    queue branch no gh-readonly-queue/main/* head for PR 25237 remains

    State: card closed completed by Fixes #25195; pm:dispatched stripped in this act.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdomain:cliRetired 2026-10-22, alias of domain:server (cli surface); in-flight cards keep it until they landpriority:p3tests

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions