pm-dispatch: a Tier H PR never reaches os-zhuang — CODEOWNERS routes docs/adr/ to @hotlong only, and SKILL.md ③ "request review from both approvers" is prose no op performs (3 of 4 open Tier H PRs requested hotlong alone)

Filing gate ③: a task the maintainer set. In the triage seat's chat, about Tier H PRs waiting 8–17 h: 「应该是skills有问题，申请我批准的应该推送给我，我看不到任何提示」. Filed by the triage seat (#6015, session_01AavokzJ5DndAwitDXvKy4U). ⛔ Not a claim.

Reader (who acts): the domain:skills seat. .github/CODEOWNERS is Tier H (its own row), so the PR lands on the maintainer's approval.

Measured (2026-10-21, `origin/main`)

PR	Tier H path	Review requests (timeline)
#24859	`docs/adr/0069`	10-20 11:22: `hotlong` only, at `ready_for_review`
#24975	`docs/adr/0050`	10-20 19:54: `hotlong` only, at `ready_for_review`
#25024	ADR-0030 row	10-21 02:03: `hotlong` only, at `ready_for_review`
#25032	`docs/adr/0139`	10-21 03:31: `hotlong` and `os-zhuang`. os-zhuang marked it ready 30 min later

Cause 1, CODEOWNERS:
- .github/CODEOWNERS reads /docs/adr/ @hotlong (plus its own two rows). Its header says this "requests his review automatically".
- GOVERNED_APPROVERS has been ['os-zhuang', 'hotlong'] since 2026-08-27 (「os-zhuang hotlong 批准算数」, scripts/pm/check-governed-queue-guard.mjs:619).
- So the only request GitHub sends by itself skips os-zhuang.
- No other Tier H path (AGENTS.md, CLAUDE.md, docs/NORTH-STAR.md, skills/**, .github/workflows/**) has a code owner at all.
Cause 2, the seat step:
- .claude/skills/pm-dispatch/SKILL.md (≈:198) says: 「③ 在 draft PR 上向两个授权批准账户 os-zhuang 与 hotlong 都 request review,主动推。」
- No op performs it, and 3 of the 4 PRs above never received it.
- The hotlong request they carry is CODEOWNERS', not the seat's.
Effect: a Tier H PR waits on an approver who is never notified. docs(spec,adr-0069): server.trustProxy names both client-address consumers; D5 mechanism amended #24859 waited 17 h with CI green.
Triage's stopgap, in this act: POST /pulls/{n}/requested_reviewers {"reviewers":["os-zhuang"]} on docs(spec,adr-0069): server.trustProxy names both client-address consumers; D5 mechanism amended #24859, docs(adr-0050): Decision 2 notes that the add-record open mode is no longer declared on addRecord #24975 and feat(service-messaging,spec,cli)!: retire sys_notification_subscription — no reader ever expanded a subscription (ADR-0030 L3, amended) #25024 (read back: hotlong,os-zhuang).

Done when

.github/CODEOWNERS routes every Tier H path to both @os-zhuang and @hotlong: docs/adr/, AGENTS.md, CLAUDE.md, docs/NORTH-STAR.md, skills/, .github/workflows/, and the file's own rows. The header states that the list mirrors GOVERNED_APPROVERS.
The request becomes an op, not prose.
- When a seat opens or readies a PR whose diff hits a Tier H row, the PM tooling requests review from every GOVERNED_APPROVERS account.
- Under the author-identity rule, that account is assigned instead.
- This applies to the relay's PR-open / pr_ready path, or the seat's landing helper. SKILL.md ③ then points at that op.
A self-test pins it: a Tier H diff gets both approvers requested, and a non-governed diff gets none.

⛔ No new gate, no check-run, and no patrol row. It is an action, not a judge.

Dedupe

Open domain:skills cards were read for CODEOWNERS / request review / Tier H notification: none. New.

Generated by Claude Code

Claim: PM loop round 1
Session: session_01M82feuetLzrCiBz41BJb7L
Account: huangyiirene
Branch: claude/issue-25046-tier-h-review-request
Worktree: objectstack-issue-25046
Domain: domain:skills
Seat: domain:skills#1
File surface: .github/CODEOWNERS; the PR-open / pr_ready path under scripts/pm/fleet-write/ (dispatch.mjs, execute.mjs, ops.mjs, validate.mjs, as measurement places the op) or the seat's landing helper under scripts/pm/, plus the self-test beside it; .claude/skills/pm-dispatch/SKILL.md (the ③ line only, net 0 lines) and .claude/skills/pm-dispatch/references/rest-channel.md if its request-review line changes (stop on breach; explain in the report)
Container & model: S, mode:subagent, model: CONTRACT_REVIEW_TIER (dispatch-gates --tier .github/CODEOWNERS scripts/pm/fleet-write/{ops,dispatch,execute}.mjs .claude/skills/pm-dispatch/SKILL.md: "Model tier — MANDATORY: claude-fable-5-1 (derived from the file surface, not recalled)", clause ①, the pm-dispatch MAIN file; no exit taken)
Clause-②: no
Responsibility: this lane's PM tooling and the governed surface's routing file (SKILL.md lane table, domain:skills row) | none: SKILL.md ③ asks for a review request from both approvers in prose, pr_request_reviewers exists in the relay, and nothing calls it on its own | every Tier H PR waits on an approver who may never be notified; measured on the card: 3 of 4 open Tier H PRs had requested hotlong alone, and #24859 waited 17 h with CI green
Thread-read: none
Serial constraints cleared: none — 15 open PRs, read 2026-10-21T05:18Z. The 12 claude/issue-* heads were diffed against their merge base with origin/main 63085c380, and none touches .github/CODEOWNERS, scripts/pm/, .claude/skills/pm-dispatch/ or .github/workflows/. #24467 changes scripts/test-shard-timings.json only, #25047 pnpm-lock.yaml only, and #24876 is the Version Packages PR. The lane has nothing else in flight.

Landing path: the card calls .github/CODEOWNERS Tier H, but check-governed-merges.mjs does not list it as a governed row (its self-test pins .github/CODEOWNERS as a near-miss that stays out). The file's own header, however, calls an edit to it a governance change and routes it to @hotlong. The seat therefore takes the stricter path:

An at-tier contract review (the .claude/skills/pm-dispatch/SKILL.md face).
The seat record with the four-piece set, and review requested from both authorised approvers.
The seat lands the PR on an authorised APPROVED review.

.claude/skills/pm-dispatch/SKILL.md pays its line ratchet line for line, never by re-wrapping. Posted 2026-10-21T05:21Z.

Generated by Claude Code

os-dev-report

{
  "issue": 25046,
  "status": "done",
  "branch": "claude/issue-25046-tier-h-review-request",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/25064",
  "session": "session_01M82feuetLzrCiBz41BJb7L",
  "premise_still_valid": true,
  "summary": "The request is now an op: fleet-write's pr_create and pr_ready rows carry governedReview, and after the row lands the executor reads the pull's whole file list, classifies it through the register (governedPathsIn + landingTierOf, scoped to payload.repo), and on a Tier H hit requests review from every GOVERNED_APPROVERS account not already requested, assigned or holding a submitted review, assigning the pull's own author instead of requesting it (GitHub answers 422 to that). Tier S, ungoverned and already-covered pulls send nothing and the summary row says which; an unreadable or truncated file list, an unreadable pull or review list, or a refused write is a FAILED action, never a quiet skip. .github/CODEOWNERS routes every Tier H register row and the enforcement chain (itself, check-governed-merges.mjs, check-governed-queue-guard.mjs) to @os-zhuang @hotlong and its header names GOVERNED_APPROVERS as the list it mirrors; codeowners/errors on the pushed branch answers an empty errors list. The mirror is pinned as a 12-case battery inside check-governed-queue-guard.mjs --self-test (codeownersMirrorVerdict reads the file on disk): no new gate, check-run or patrol row. SKILL.md step ③ and rest-channel.md point at the op at net 0 lines. Landing site for the op is the relay executor (candidate b): it alone knows the pull number at the right moment (the create's answer), holds the token, and runs on the board's main checkout where the register lives; the seat client could not name a number that does not exist yet and would decide on a possibly stale checkout, and the landing helper does not exist as a script and acts after the approval, too late for Tier H. H3 measured from PR 24859's timeline: the draft create produced no review_requested, CODEOWNERS' hotlong request arrived one second after ready_for_review, so the op fires at pr_create (the silent moment) and again, idempotently, at pr_ready.",
  "tests": "node scripts/pm/fleet-write/execute.mjs --self-test: ✓ 167 cases pass across 18 batteries (new battery of 29 cases, floor 17 → 18). node scripts/pm/fleet-write/validate.mjs --self-test: ✓ 160 cases across 11 batteries (the refused-family pin now covers governedReviewRequests' two endpoints; the alsoSpends pin names pr_create, pr_ready, automerge_enable). node scripts/pm/fleet-write/dispatch.mjs --self-test: ✓ 235 cases across 21 batteries. node scripts/pm/check-governed-queue-guard.mjs --self-test: ✓ 334 cases pass (new 12-case battery, floor 26 → 27). Ablation A (change committed first; scripts/ablation-replace.mjs): anchor `followed = await requestGovernedReview(…)` replaced by `followed = { ok: true }` — tool evidence anchor x1 -> x0, blob c660b170c9e0 -> 58e7fdeed4fd; execute self-test ✗ 17 of 167 case(s) failed, among them `⭐ pr_create on a Tier H diff: the create, then ONE requested_reviewers POST naming BOTH approvers`; restore: blob == HEAD (c660b170c9e0) and git diff HEAD empty. Ablation B: `/docs/adr/ @os-zhuang @hotlong` replaced by `/docs/adr/ @hotlong` in .github/CODEOWNERS — blob 15d3fffd682e -> f223af300219; guard self-test ✗ 2 of 334 case(s) failed (`the-file-on-disk-mirrors-the-register-and-the-approver-list: CODEOWNERS line 42 /docs/adr/ names @hotlong, not every GOVERNED_APPROVERS account`); restore: blob == HEAD (15d3fffd682e) and git diff HEAD empty. Both ablations' expected direction was red and both went red. Live reading for H1: GET /repos/objectstack-ai/objectstack/codeowners/errors?ref=claude/issue-25046-tier-h-review-request answers {\"errors\":[]}.",
  "gates": "Local subset at head 91669b139: node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack (no paths) derived 60 families on the actual diff — the lead's 58 plus pnpm check:closing-target-claim and pnpm check:ratchet-remedy-authority. Each was run with the capture idiom (cmd > log 2>&1; status=$?) and recorded as `cmd :: exit N`; reconciliation: `✓ dispatch-gates --ran: 60 derived famil(ies) accounted for — 59 run, 1 NOT-MEASURED (1 DERIVED from a recorded exit 3)`. 59 exit 0, among them pnpm check:pm-fleet-write-dispatch · pnpm check:pm-fleet-write-execute · pnpm check:pm-fleet-write-validate · pnpm check:pm-governed-merges · pnpm check:pm-governed-prose · pnpm check:pm-skill-ratchet (SKILL.md 319 of ceiling 319, rest-channel.md 82 of 82, edited lines under the 120-byte line budget) · pnpm check:pm-skill-id-lint · pnpm check:skill-frame-sync · pnpm check:pm-dispatch-gates (fast tier: ✓ 1913 cases pass; 6 slow sections deferred; EXIT=0 captured by a wrapper shell under nohup) · pnpm check:pm-write-pace · pnpm check:doc-authoring · pnpm check:required-contexts · node scripts/check-self-test-wired.mjs and --self-test · node scripts/pm/check-governed-queue-guard.mjs --self-test. NOT MEASURED: pnpm --filter @objectstack/lint run check:doc-formula-expressions, exit 3 PREREQUISITE NOT MET (wants a @objectstack/formula + @objectstack/lint build; the diff touches no package so no ① closure was built) — CI runs it. CI check-runs on PR 25064: in_progress at report time (the PR opened minutes ago); not re-run locally.",
  "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm (Clause-②: no)",
  "mcp_calls": "0 — no MCP GitHub tool was called",
  "api_writes": "2 — both POST /repos/objectstack-ai/objectstack/dispatches (the fleet-write relay): ① pr_create, run 39555057015, inside which the executor wrote POST /repos/objectstack-ai/objectstack/pulls (draft), POST /repos/objectstack-ai/objectstack/issues/25064/assignees (huangyiirene) and POST /repos/objectstack-ai/objectstack/issues/25064/labels (skip-changeset); read back 12388 of 12388 bytes identical; ② this os-dev-report comment (POST /repos/objectstack-ai/objectstack/issues/25046/comments via post-stamped.mjs). git push × 2 (the empty-branch probe, then the one commit) are not REST writes. No reviewer was requested on PR 25064 — the seat does that after review.",
  "open_questions": [
    { "question": "CODEOWNERS carries a third enforcement-chain row, /scripts/pm/check-governed-queue-guard.mjs, beyond the two the card's Done-when calls 'the file's own rows'. Keep it?", "options": ["A keep: that file holds GOVERNED_APPROVERS, the very list CODEOWNERS now mirrors, so editing it changes who counts as an approver — the header's own rationale for routing the enforcers", "B drop it to the literal two rows"], "recommendation": "A — real need (the constant is what the mirror pins), long-term soundness (one enforcement chain, routed whole), AI-error resistance (an edit to the approver list cannot route around the approvers), startup scope (one line, no new surface); reversible in one line if the maintainer prefers B" },
    { "question": "AGENTS.md Prime Directive 14 says 'CODEOWNERS routes review requests for docs/adr/ only, so nothing summons the maintainer on the other Tier H surfaces' — false once this PR lands. Where does the one-line rewrite go?", "options": ["A a follow-up PR on AGENTS.md by the seat (Tier H, its own line ratchet)", "B fold it into this PR"], "recommendation": "A — B breaches the dispatch's file surface (the claim says stop on breach); A is one line and lands under the same tier" },
    { "question": "An unreadable or truncated file list after pr_create is a FAILED action (the dev's dispatch exits 5 with the pull already open). Keep the loud direction?", "options": ["A keep FAILED (chosen): the precedent is the assignees leg and graphqlVariables' unread node id, and silence is the defect this card closes", "B a warning row with exit 0"], "recommendation": "A — B reproduces the original failure shape (nobody told) under a green exit; the cost of A is a transient platform read turning one PR-open stroke into an exit 5 the seat repairs by hand from the row" }
  ],
  "out_of_scope_findings": [
    "class: none of a/b/c (agent-read prose, not a runtime contract) · AGENTS.md Prime Directive 14's CODEOWNERS sentence becomes false on landing · evidence: the sentence vs the new .github/CODEOWNERS; check:pm-governed-prose does not pin it (green here) · dedupe words: CODEOWNERS, docs/adr only, Prime Directive 14, summons the maintainer",
    "carrier: the domain:skills seat (a one-line Tier H follow-up on AGENTS.md) · noted, not filed"
  ],
  "line_budget": ".claude/skills/pm-dispatch/SKILL.md 319 → 319 (ceiling 319, net 0: the four lines of step ③ rewritten in place at 105/119/118/69 bytes, under the 120-byte line budget; no re-wrap); .claude/skills/pm-dispatch/references/rest-channel.md 82 → 82 (ceiling 82, net 0: one line rewritten at 120 bytes)",
  "deviations": [
    "The CODEOWNERS mirror pin lives in scripts/pm/check-governed-queue-guard.mjs --self-test — an existing self-test under scripts/pm/, the file that owns GOVERNED_APPROVERS — rather than beside one of the four relay files; it is the one existing self-test that already reads both the register and the constant, and the card allowed a pin only inside an existing self-test.",
    "pnpm --filter @objectstack/lint run check:doc-formula-expressions is NOT MEASURED locally (exit 3, a prerequisite build the diff does not call for).",
    "pnpm check:pm-dispatch-gates was started under nohup to overlap with the other gates; its exit code was captured to a file by a wrapper shell (EXIT=0) and its verdict line read from the log, both after a tail --pid wait in the foreground.",
    "The first commit carried `Claude Fable 5.1` in its Co-Authored-By trailer (the harness reminder's form); the repository's pre-push hook refused it and the still-unpublished commit was amended to the model-free pair before any content was pushed — no published history was rewritten.",
    "The PR body was written once at pr_create and read back byte-identical by the relay (12388 bytes); no PATCH was sent. This comment carries the bare footer under a rule line."
  ],
  "files_changed": [
    ".github/CODEOWNERS",
    "scripts/pm/fleet-write/ops.mjs",
    "scripts/pm/fleet-write/execute.mjs",
    "scripts/pm/fleet-write/validate.mjs",
    "scripts/pm/check-governed-queue-guard.mjs",
    ".claude/skills/pm-dispatch/SKILL.md",
    ".claude/skills/pm-dispatch/references/rest-channel.md"
  ]
}

Generated by Claude Code

ACCEPT → PR #25064 comment from this seat (the 维护者速读 and ## 席位核对 record) · contract review PASS 6309771962 · domain:skills seat 1 · session_01M82feuetLzrCiBz41BJb7L · 2026-10-21T06:42Z

This seat takes the stricter landing path declared on the Claim: pm:dispatched → needs-user-decision in this act. Review is requested from both authorised approvers (os-zhuang, hotlong; relay run 39557012702, success). On an authorised APPROVED review the card returns to pm:dispatched and the seat lands the PR.

Generated by Claude Code

ACCEPT → PR #25064 comment 6309803081 · domain:skills seat 1 · session_01M82feuetLzrCiBz41BJb7L · 2026-10-21T06:43Z

This completes the pointer line above, which named the record without its id. One correction to that record's ⑤: the review items it cites are contract review 6309771962 ③8 (the GET …/reviews read), ③9 (the Tier S spelling) and ③10 (the round-report trail). The record numbered them 19, 14 and 15.

Generated by Claude Code

Navigation Menu

Repository navigation

pm-dispatch: a Tier H PR never reaches os-zhuang — CODEOWNERS routes `docs/adr/` to @hotlong only, and SKILL.md ③ "request review from both approvers" is prose no op performs (3 of 4 open Tier H PRs requested hotlong alone) #25046

Measured (2026-10-21, `origin/main`)

Done when

Dedupe

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

pm-dispatch: a Tier H PR never reaches os-zhuang — CODEOWNERS routes docs/adr/ to @hotlong only, and SKILL.md ③ "request review from both approvers" is prose no op performs (3 of 4 open Tier H PRs requested hotlong alone) #25046

Description

Measured (2026-10-21, origin/main)

Done when

Dedupe

Activity

objectstack-fleet commented on Oct 21, 2026

objectstack-fleet commented on Oct 21, 2026

objectstack-fleet commented on Oct 21, 2026

objectstack-fleet commented on Oct 21, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

pm-dispatch: a Tier H PR never reaches os-zhuang — CODEOWNERS routes `docs/adr/` to @hotlong only, and SKILL.md ③ "request review from both approvers" is prose no op performs (3 of 4 open Tier H PRs requested hotlong alone) #25046

Measured (2026-10-21, `origin/main`)