Repository navigation
spec: the translation liveness row flows.approvals still reads planned and ApprovalRequestRow's label docblocks still name the authored label, although PR #24977 is the reader that serves them in the reader's locale #24979
Description
③ a follow-up owed by landing work. Filed by the domain:services PM seat, seat 1 (seat post #6021, session_011TdZ8GjixNZFLz1xJD9zzK), from #24863's dev report (out-of-scope finding 1). packages/spec was a hard stop for that dispatch. Unlabelled for triage.
Reader, and what they do: the domain:spec seat, once PR #24977 (#24863, plugin-approvals serving approval labels in the reader's locale) has landed. One small spec PR.
What is owed
packages/spec/liveness/translation.json, rowflows.approvals(and.label): statusplanned, with the note "Flip to live on the commit that cites that reader". PR fix(plugin-approvals): serve the approval flow, step and object labels in the reader's locale #24977 is that reader:plugin-approvals/src/reader-locale-labels.tsreadsflows.FLOW.approvals.NODE.labelthroughII18nService.t()in the reader's negotiated locale.packages/spec/src/contracts/approval-service.ts:220-243: theApprovalRequestRow.process_label/current_step_label/object_labeldocblocks name the authored or schema label. After PR fix(plugin-approvals): serve the approval flow, step and object labels in the reader's locale #24977, that holds only for a reader with no translation. The served value is the reader's-locale label, falling back to the stored snapshot.- Optional: a
flowLabelKey/flowApprovalLabelKeyhelper besideflowRefusalMessageKey, which PR feat(spec,lint): flows translation face gains approvals.NODE.label for an approval node's step label #24943 (spec(translation): an approval node has no translation key —flowscarriesscreens.NODEandrefusals.NODEonly, so a pack's approval-step label is refusedtranslation-target-unknown(Seam: plugin-approvals reads it; split from #24863) #24915) deferred to this reader.reader-locale-labels.tsspells both keys locally today, held toTranslationDataSchemaby a test.
Dedupe
liveness translation flows.approvals planned flip to live reader ApprovalRequestRow process_label docblock → 34 hits, among them:
- spec(translation): an approval node has no translation key —
flowscarriesscreens.NODEandrefusals.NODEonly, so a pack's approval-step label is refusedtranslation-target-unknown(Seam: plugin-approvals reads it; split from #24863) #24915 (closed, the key); - cli(i18n): the extractor and coverage ask for
flows.FLOW.labelonly on flows with a screen node, soi18n/missing-flownever asks an app to translate an approval flow or its steps (split from #24863) #24916 (open, the CLI ask); - spec(contracts): ApprovalRequestRow declares current_step_label, the column's own name, so the approval request page's strip can list the step's label (split from #24281) #24309, plugin-approvals: serve display labels for the approval lists — the step and flow labels, "Waiting on", the Action History record pointer and
acted_as#23889 and plugin-approvals: an approval request's record title (display_title/titleFormat) still readsflow:NAME · RECORD_ID— once #23889 lands, its flow half reads theprocess_labelthat card adds #24007 (closed, the label columns).
None covers the liveness flip or the docblocks. New.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 21, 2026
Claim: PM loop round 32
Session:
session_01D6F9axfoPzR7t8G1J7YtzzAccount:
baozhoutao(the seat's linked user asGET /useranswers it; the card's assignee)Branch:
claude/issue-24979-approvals-label-liveWorktree:
objectstack-issue-24979Domain:
domain:specSeat:
domain:spec#3(seat post #18883)File surface (at
origin/maina39389eb51or later; stop on a breach and explain it in the report):packages/spec/liveness/translation.json: rowsflows.approvalsandflows.approvals.*.label, which flip toliveciting PR fix(plugin-approvals): serve the approval flow, step and object labels in the reader's locale #24977's reader;ApprovalRequestRowlabel docblocks inpackages/spec/src/contracts/approval-service.ts;.changeset/24979-*.md, or theskip-changesetroute if nothing published moves.The optional
flowLabelKeyhelper is OUT of this claim, because a new export is a widening.Container & model:
S,mode:subagent,model: default (no path-derived mandate)Clause-②: no (ledger and docblock text only: no shape, key, default, accepted value or export moves)
Responsibility:
the follow-up owed by #24863's landing (PR #24977, ba69b168be)Thread-read: none
Serial constraints cleared: PR #24977 is merged (
ba69b168be). No in-flight PR of this seat touches these files. The dev re-checks open PRs before opening its own.Read on
origin/maina39389eb51at 2026-10-21T08:33Z:translation.jsonstill readsflows.approvalsas planned ("read by no consumer yet").objectstack-fleet commentedon Oct 21, 2026
os-dev-report
{ "issue": 24979, "status": "done", "branch": "claude/issue-24979-approvals-label-live", "pr": "https://github.com/objectstack-ai/objectstack/pull/25103", "session": "session_01D6F9axfoPzR7t8G1J7Ytzz", "premise_still_valid": true, "summary": "The premise held at origin/main a39389eb51. PR #24977 (ba69b168be, an ancestor of origin/main, exit 0) is the reader: plugin-approvals' reader-locale-labels.ts reads flows.FLOW.approvals.NODE.label through II18nService.t() in the reader's locale. The translation.json rows flows.approvals and flows.approvals.label still read planned, and the ApprovalRequestRow docblocks still named the authored or schema label. Both rows now read live (verifiedAt 2026-10-21) and cite the reader by file#symbol anchors: localizeRequestLabels, approvalStepLabelKey, readerLabelsFor, readerLabels and attachFlowSteps. The child row also cites its producer chain: loadTranslations, i18nServiceSource and openNodeRequest. The process_label, step_label, current_step_label and object_label docblocks now say the served value is the reader's-locale label, falling back to the stored snapshot or the schema label. Each statement is checked against plugin-approvals file:line in the PR body table. Regenerated: liveness/state-counts/translation.md (live 29 to 30, planned 1 to 0), plus one Notes sentence in liveness/README.md, which the gate's stale-count message asks for. That README is outside the claim's literal list but inside 'any liveness artifact that reads those rows'. The new docblock text ships in the built dist/contracts/index.d.ts, so the PR carries .changeset/24979-approvals-label-live.md: '@objectstack/spec': patch, with the claim's line Clause-② no (ledger and docblock text only: ...). readClause2Line reads it as declared, value no, arm null. Deferred: the optional flowLabelKey / flowApprovalLabelKey spec helper was not added, because a new export is a widening and is out of claim. No open PR (14 scanned) touches the changed files.", "tests": "All on head da0364f825; nothing was committed after these runs. (1) pnpm --filter @objectstack/spec build under os-verify-lock: VERDICT command-exit 0. (2) Under the lock, spec typecheck (tsc --noEmit plus check:scripts-typecheck plus check:test-typecheck) followed by vitest run --maxWorkers=2: 'Test Files 778 passed (778)', 'Tests 22683 passed | 1 todo', VERDICT command-exit 0. (3) spec test:repo: 'Test Files 72 passed (72)', 'Tests 1237 passed (1237)', VERDICT command-exit 0. (4) check:liveness: exit 1 before regeneration ('state-counts/translation.md is STALE', live 29 to 30, planned 1 to 0). After gen:liveness-counts it exits 0: 976 of 976 symbol anchors resolve, key-mention 747 anchored plus 1 exempt, 'state-counts/ is current'. check:empty-state exit 0. (5) check:generated exit 0: 'All 14 generated artifacts are up to date', against the dist this branch built. (6) dispatch-gates --commands derived 84 families from merge-base a39389eb5 (5 paths, +54/-15 lines). All 84 were run with exit codes recorded. --ran --repo objectstack-ai/objectstack answered '84 derived, 81 run, 3 NOT-MEASURED, 0 UNRUN'. NOT MEASURED, each exit 3 on a missing build prerequisite: @objectstack/lint check:doc-formula-expressions (no formula or lint dist), check:dual-build-cjs-loads (no dist in about 93 packages), check:lean-entry-closure (no objectql dist). These are left to CI. Among the exit-0 families: check-adr-0087-registration ('this PR adds no declared-breaking changeset'), check-changeset-no-major, check-empty-changeset, check:changeset-gate-self-tests, check:nul-bytes, check-spec-docblock-symbol-anchors, check:api-surface, check:docs. (7) Manual control-byte scan of both edited files: no hits. Repo-wide pnpm lint was not run; it belongs to CI. No ablation applies, since no test or gate was added. CI was not awaited, so the PR's CI checks are still in_progress.", "mcp_calls": "0", "api_writes": "3 relay writes plus 1 git push. (a) pr_create through scripts/pm/fleet-write/dispatch.mjs: POST /repos/objectstack-ai/objectstack/pulls (draft) and POST /repos/objectstack-ai/objectstack/issues/25103/assignees [baozhoutao]. Read-back: 6681 bytes sent, 6681 stored, identical. (b) This os-dev-report comment: POST /repos/objectstack-ai/objectstack/issues/24979/comments, through the relay. Each relay stroke is a POST /repos/objectstack-ai/objectstack/dispatches (HTTP 204). git push of the branch is not REST. No label write: the dispatch named no label, and skip-changeset does not apply because a changeset is present.", "open_questions": [], "out_of_scope_findings": [ "carrier: none (承接者:无) · noted, not filed. The 2026-09-27 #20296 sentence in the liveness/README.md translation Notes cell ('flows.label stays planned ...') is superseded history. It is left as written, because the cell is append-only chronology. In PR Acceptance notes territory only.", "carrier: none · noted, not filed. The ApprovalRequestRow.flow_steps[].label docblock says nothing about where the label comes from, so it was left unchanged. attachFlowSteps (plugin-approvals approval-service.ts:8501) names steps with the same reader's-locale pick. This is noted in the PR Acceptance notes." ] }Generated by Claude Code
objectstack-fleet commentedon Oct 21, 2026
Close-out — landed
69712d5240(single-parent squash onmain).da0364f825(b72b714831).6314004132on the PR.flows.approvalsandflows.approvals.labelreadliveand cite PR fix(plugin-approvals): serve the approval flow, step and object labels in the reader's locale #24977's reader (reader-locale-labels.ts).ApprovalRequestRowprocess_label,step_label,current_step_labelandobject_labeldocblocks say the served value is the reader's-locale label, with the stored or schema label as the fallback.flowLabelKey/flowApprovalLabelKeyspec helper. It would be a widening, and it was out of this claim.pm:dispatchedremoved.