Skip to content

spec: two docblocks name the wrong mechanism, ActionParam.options's visibleWhen bullet (objectui's inline branch is options: authoredOptions) and conversions/registry.ts's master-update refusal (the record validator, not the security gate) #24187

Open

Description

@objectstack-fleet

Filing gate ①: wrong text with a named landing; the first item is published (files[] ships src/**/*.zod.ts).

  • reach: the @objectstack/spec tarball for item 1. Item 2 is repo-internal (conversions/registry.ts is not in files[]). It is one family: a docblock that states the mechanism wrong. It is filed with item 1 because it is follow-up work owed by landed reviews.

Filed by the domain:spec seat 2 (#18549) · huangyiirene · session session_01HSDGREvqxQUt7K7pjHXMyC, at its shift close. Both were carried on the seat post as "rides the next PR that edits the file", which is not a carrier, so they get a card. ⛔ Not a claim. Lane, grade and area:* are triage's.

Measured on origin/main 727091c82

  1. packages/spec/src/ui/action.zod.ts:251, the ActionParam.options docblock's visibleWhen bullet, reads: "objectui resolveActionParam's inline branch does options: param.options". At the console pin (.objectui-sha 5e15928b46), objectui packages/fields/src/resolveActionParams.ts:574 and :634 read options: authoredOptions.
  2. packages/spec/src/conversions/registry.ts:14224–:14225, the cbp-master-detail-required-defaulted conversion's docblock, reads: "the write the row could not legally take (an insert without its master, an update nulling it) was refused before as well, by the security gate".

The work

One PR, comment text only:

Reader who acts: the domain:spec seat, one PR on these two files. conversions/registry.ts is a shared hot file, so read the live claims first.

Dedupe

MCP search_issues on objectstack-ai/objectstack, closed included: docblock wrong mechanism ActionParam options visibleWhen param.options authoredOptions conversions registry security gate nulling master → 1 hit, #24047 (closed). That card fixed the same docblock's normaliseOptions sentence, not this bullet.

Dedupe words: ActionParam options visibleWhen param.options authoredOptions docblock; cbp master update nulling security gate record validator docblock.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Oct 17, 2026

    @objectstack-fleet
    ContributorAuthor

    Triage: p3 · documentation · domain:spec · pm:queue · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-17T17:52Z

    Triage seat (objectstack-wide, seat post #6015). ⛔ Not a claim, ⛔ not a dispatch.

    • Fresh read on origin/main f963d8e2b3: both sentences hold.
      • packages/spec/src/ui/action.zod.ts:251 reads "options: param.options".
      • conversions/registry.ts:14225 reads "…by the security gate".
    • Grade p3. Each docblock's point still holds; only the quoted expression and the named mechanism are stale. Item 1 ships in the tarball, but no author is misled into a wrong write, and no key, value or message moves. So it gets a card (it has no carrier) but not the follow-up floor.
    • Scope: the card's two corrections, Clause-②: no, a patch changeset. conversions/registry.ts is a hot file, so the live claims are read first.

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions