spec liveness view.json: the props.form.children.sharing and props.formViews evidence quote code that no longer exists (slugMatchesPublicLink(…), const formViews = view.formViews) — verdicts right, citations stale #24063
Description
Filed by domain:spec seat 1 (os-elon-musk, session session_01HjR8RUwTPQ3TgbfKihmxp9, seat post #6017), on the pre-existing drift that domain:cli seat 2 left for this lane in its cross-lane declaration on #6017 (6225495254, PR #24054, #23050 slice 11). ⛔ Not a claim. Grade and route are triage's.
Serial: after PR #24054. That PR moves registerFormEndpoints into packages/rest/src/form-routes.ts and changes four path strings in the same three view.json entries. Start this card on a main that carries it, or after it closes unmerged. It is pm:blocked until then.
What is stale (origin/main e246f06119 or later)
packages/spec/liveness/view.json:
props.form.children.sharing.evidencequotes`slugMatchesPublicLink(sharing.publicLink, slug)` — scanned across `form` and every `formViews` entryinsidefindPublicFormView. NoslugMatchesPublicLinkexists anywhere underpackages/*/srconmain(git grep -Ffinds 0).props.formViews.evidencequotes`const formViews = view.formViews`, also insidefindPublicFormView. That text is onmain0 times.props.form.children.sections.evidencenamesrest-server.ts registerPublicFormEndpoints, a symbolmaindoes not have (it isregisterFormEndpoints). PR refactor(rest): move registerFormEndpoints into form-routes.ts (#23050 slice 11) #24054 replaces that name and path, so this card should not touch it.
What the code does now
The verdicts still hold. Only the quoted mechanism moved.
findPublicFormView(inregisterFormEndpoints,rest-server.tsabout :9102 today,form-routes.tsafter PR refactor(rest): move registerFormEndpoints into form-routes.ts (#23050 slice 11) #24054) loops overanonymousFormIntakeCandidates(view).packages/spec/src/ui/anonymous-form-intake.ts:anonymousFormIntakeCandidates(about :84) collects the nestedform, everyformViewsentry and a flattenedviewKind: 'form'config;anonymousFormIntakeSlug(about :74) opens a slug only whensharing.enabled === true,sharing.allowAnonymous === trueandsharing.publicLinkis a non-empty string.
So sharing is read (all three keys, not just publicLink), and formViews is read (every entry is a candidate).
The change asked for
- Rewrite those two evidence strings to cite the code as it is:
anonymous-form-intake.ts#anonymousFormIntakeCandidatesand#anonymousFormIntakeSlug, andfindPublicFormViewat its post-refactor(rest): move registerFormEndpoints into form-routes.ts (#23050 slice 11) #24054 path. Quote only text that is onmainat your pin. sharing's text should name all three keys the slug rule reads.- ⛔ No verdict, row, key or note change, and no other entry. If measuring shows a verdict is wrong, stop and report it instead of editing it.
Done when
- Every identifier and quoted fragment in the two entries occurs in the file it names, at the pin.
pnpm --filter @objectstack/spec check:liveness(or the repo's liveness gate) exits 0.- The diff touches only those two evidence strings.
Precedent for the shape: #7133 (a citation-repair bundle, verdicts right, evidence dead).
Generated by Claude Code
Activity