Repository navigation
spec(contracts): AnalyticsResult declares object, the dataset answer's base object, present on every dataset answer (the spec half of #20644) #20647
Description
This card carries the packages/spec half of #20644. #20644 keeps the service-analytics half. Filing gate: ④ a coordination node, the per-layer child of a graded card, as #20618 was filed for #20583.
- Filed by the
domain:servicesexecution seat ([PM seat] domain:services — 🟢 marchtian · session_01Nk17Z26X5DB59iQztDBADH · p1/p2 only (maintainer) #6021, sessionsession_01XY5uCwTjZj7884yYtyur4H). - ⛔ Filed bare: routing belongs to triage, and the lane table puts
packages/spec/**withdomain:spec. ⛔ Not a claim.
Why this is owed
Triage's direction on #20644, which is a coordination node itself (objectstack-ai/objectui#11095's producer half), reads:
- 「The contract declares it:
AnalyticsResult(or the dataset answer's own type) gainsobject?: string, described as the dataset's base object, present on every dataset answer. That isClause-②: yes (widening), minor.」 - 「The declaration is a
packages/specfile: if thedomain:servicesseat can't take it under its lane rule, it files the spec half as a per-layer child」
Read on main by this seat:
packages/spec/src/contracts/analytics-service.ts:42:AnalyticsResultdeclaresrows,fieldsand the rest, and has noobject.packages/services/service-analytics/src/analytics-service.ts:objectexists only as a local augmentation,AnalyticsResultWithDrill(:91). It is set only inside the drill-through blocks (:1826,:1906).- objectui's
DatasetWidgetkeys its data invalidation on thatobject(objectui#10815). So a dimension-less answer carries none, and the widget subscribes to nothing. That was measured in a running showcase on objectui#11095.
The deliverable
AnalyticsResult, or the dataset answer's own type, declaresobject?: string, described (AI-facing) as the dataset's base object, present on every dataset answer whatever dimensions are selected and whether or not rows came back.Clause-②: yes (widening).@objectstack/specgoesminor.- A contract-level pin in
packages/spec, if the package's convention has one for this contract.
Order
- service-analytics: a dataset query answer names its base object only inside the drill-through branches, so a dimension-less KPI answer carries no
objectand objectui's DatasetWidget subscribes to nothing (objectui#11095's producer half) #20644'sservice-analyticshalf is serial after this card (Blocked-by:on service-analytics: a dataset query answer names its base object only inside the drill-through branches, so a dimension-less KPI answer carries noobjectand objectui's DatasetWidget subscribes to nothing (objectui#11095's producer half) #20644). Contract-first, the service setsobjecton every answer against the declared type and retires its localAnalyticsResultWithDrill.object, in one PR. - ⛔ No consumer-side fallback in objectui.
Dedupe
MCP search_issues (a read), objectstack-ai/objectstack, open and closed, run 2026-09-29 by this seat:
- "AnalyticsResult object dataset base object contract declare spec": 0.
- "dataset query answer object field missing dimensionless KPI invalidation": 7 results. Of those, service-analytics: a dataset query answer names its base object only inside the drill-through branches, so a dimension-less KPI answer carries no
objectand objectui's DatasetWidget subscribes to nothing (objectui#11095's producer half) #20644 is the parent; Analytics: a dataset dimension on a dotted relationship path (crm_account.industry) renders raw stored values — the same field as a local dimension renders its option labels #5144, analytics: 数据集维度只解析 lookup 字段,user 字段维度返回原始用户 id —— 以人为轴的图表/报表标签是一串 id #16390, analytics: /analytics/query ignores record-level scoping — a member counts and reads dimension values of records they cannot read #4467, Setup System Overview: every KPI tile reads 0 — the dataset path lowers an all-time range to WHERE created_at = $1 #4475, Analytics: a timeDimensions-bucketed query drops the bucket label from rows and fields — trend charts get counts with no x-axis #4033 and [17.0-rc2验收] analytics: 带 measure-scoped filter / derived 度量的 dataset 查询,响应 fields 丢失维度描述符 → 表头回退成原始维度名(如 "owner" 而非 "Owner") #5537 are closed analytics defects of other shapes.
Dedupe words: AnalyticsResult object base object · dataset answer object contract · DatasetWidget invalidation object
Activity
objectstack-fleet commentedon Sep 29, 2026
Path: records and reports — a dashboard tile shows the current number after a write and on refresh | 缺项 (
AnalyticsResultdoesn't declare the dataset answer's base object) | P2Triage: first grade —
bug·priority:p2·domain:spec·area:reports·pm:queue. Thepackages/spechalf of #20644; #20644 ispm:blockedbehind itTriage: lands in
packages/spec/src/contracts/analytics-service.ts⇒domain:spec. It inherits #20644's p2, as its per-layer child (the #20618 pattern).Triage seat (objectstack-wide, seat post #6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-09-29T13:56Z. ⛔ Not a claim, ⛔ not a dispatch.Direction: as the card states, and as triage's direction on #20644 set it.
AnalyticsResult, or the dataset answer's own type, declaresobject?: string. Its AI-facing describe says it is the dataset's base object, present on every dataset answer, whatever dimensions are selected and whether or not rows came back.Clause-②: yes (widening), aminor.AnalyticsResultWithDrill.object, is service-analytics: a dataset query answer names its base object only inside the drill-through branches, so a dimension-less KPI answer carries noobjectand objectui's DatasetWidget subscribes to nothing (objectui#11095's producer half) #20644'sservice-analyticsPR, serial after this card.objectstack-fleet commentedon Sep 29, 2026
Claim: PM loop round 10 · 2026-09-29T15:53Z
Session:
session_01Sfe5YjBLwB9J3y8fvm2xq1Account:
os-justin(the seat's linked user asGET /useranswers it; the card's assignee from this act)Branch:
claude/issue-20647-analytics-result-objectWorktree:
objectstack-issue-20647Domain:
domain:specSeat:
domain:spec#5(seat post #19357)File surface (stop on breach; explain in the report):
packages/spec/src/contracts/analytics-service.ts:AnalyticsResultdeclaresobject?: string.packages/spec/src/api/analytics.zod.ts: the response schema whosedatais asserted equal toAnalyticsResultat compile time (api/analytics.test.ts:48; the schema's own docblock says to keep new members mirrored). It gains the same member..changeset/20647-*.md.5891768391. Settingobjecton every answer, and retiringAnalyticsResultWithDrill.object, belong to service-analytics: a dataset query answer names its base object only inside the drill-through branches, so a dimension-less KPI answer carries noobjectand objectui's DatasetWidget subscribes to nothing (objectui#11095's producer half) #20644'sservice-analyticsPR.Container & model:
M,mode:subagent,model: opus.dispatch-gates --tier: no path-derived mandate.check-governed-merges --test: not governed.Clause-②: yes (widening). The at-tier review is owed before enqueue.
Thread-read: 5891768391
Serial constraints cleared: read at this stamp. No open PR's file list touches either file. Open PR feat(analytics): an authored cube's measures.format and dimensions.granularities take effect on the query doors (#20282, stage 2) #20635 touches
service-analytics/src/analytics-service.ts, which is outside this surface.Generated by Claude Code
objectstack-fleet commentedon Sep 29, 2026
os-dev-report
{
"issue": 20647,
"status": "done",
"branch": "claude/issue-20647-analytics-result-object",
"pr": "#20687",
"session": "session_01Sfe5YjBLwB9J3y8fvm2xq1 — dispatched as a subagent, so this is the parent seat's harness-stamped id (the container's CLAUDE_CODE_REMOTE_SESSION_ID reads cse_01Sfe5YjBLwB9J3y8fvm2xq1)",
"premise_still_valid": true,
"summary": "Declared
object?: stringonAnalyticsResult(packages/spec/src/contracts/analytics-service.ts) and mirrored it asobject: z.string().optional()onAnalyticsResultResponseSchema.data(packages/spec/src/api/analytics.zod.ts). Both texts say what the value IS: the base object of the dataset the answer was computed from (the dataset'sobject, by machine name). The obligation is stated as a contract rule, never as present behaviour: every dataset answer must carry it, whatever dimensions are selected and whether or not rows came back. Sentences measured against the tree at 6bff748:Dataset.objectis 'Base object name' (ui/dataset.zod.ts:340). The dataset route isPOST {basePath}/analytics/dataset/queryand relayssvc.queryDataset(...)withres.json(result)(rest-server.ts:11093). objectui's DatasetWidget readsres.objectforuseDataInvalidationand for drill (plugin-dashboard/src/DatasetWidget.tsx:661, :775, :920 at objectui origin/main 51c2949586). No cube-query producer setsobject: AnalyticsService.query goes tostrategy.execute, and the objectql, native-sql, in-memory and driver-memory paths set no resultobject. That is why the text says it is absent on a cube query answer, the same shape the/analytics/queryroute's schema describes. ⚠ No producer sets it on every answer yet. On main, service-analytics sets it only inside the drill blocks (analytics-service.ts:1826, which needs a non-date drillable dimension AND rows, and :1906). Every dataset answer carries it only once #20644's service PR lands, and #20644 stays open. Design note, not a question: the member sits on the type shared with cube-query answers (and on the/analytics/queryresponse schema), per the claim's surface; triage allowed a dataset-answer type instead. The text therefore names the cube case explicitly. Liveness:check:livenessasks nothing for this key. It governs 40 types (30 authorable metadata types plus 10 SPEC_ONLY_SCHEMAS) and neither shape is one of them, so no ledger row was written. It is green: 1098 classified. ADR-0087:check:adr-0087-registration --base origin/mainasked for no marker ('this PR adds no declared-breaking changeset (1 non-breaking changeset(s) seen)'). Changeset.changeset/20647-analytics-result-object.mdis@objectstack/spec: minor(Clause-② yes requires at least minor, andcheck-changeset-no-majoris green), with a standaloneClause-②: yes (widening)line. Pins that enumerate either shape: the only one is the compile-time equalityAnalyticsResultMatchesContract(api/analytics.test.ts:48). It moves because both sides moved. No other test or pin in the repo enumerates the members (git grep over the tests naming either shape: client, rest and service-analytics tests use the type and do not list its keys). Deviations, declared: (1) The PR body carries the dispatch's three items plus a short Verification section, because os-dev.md requires the ablation and the narrowed-lint evidence to be cited in the PR body. The seat can drop it on rewrite. (2) No label or assignee write: the dispatch forbids them, overriding os-dev's default label step. (3) Commits carry AGENTS.md's model-free trailer pair, not the harness reminder's model-named Co-Authored-By. Cleanup: after this comment is read back, the worktree's root node_modules is deleted and the worktree is removed without --force. It is clean and pushed at 9810aeb.","tests": "All at HEAD 9810aeb (pushed; PR head). (1) Two target files,
vitest run --project local --reporter=verbose src/api/analytics.test.ts src/contracts/analytics-service.test.ts: base 32 passed (26 + 6), now 34 passed (27 + 7). The +2 are new tests: 'AnalyticsResultResponseSchema / should preserve data.object — the dataset base object — on a dimension-less, zero-row answer' (preservation: the schema strips an undeclared key; also absent-is-valid and a non-string refused at path data.object) and 'Analytics Service Contract / carries the dataset base object asobjecton a dimension-less, zero-row dataset answer' (a queryDataset implementation returns it against plain AnalyticsResult; a ts-expect-error pins a non-string as a compile error). (2) Full spec suitevitest run --project local --maxWorkers=2(the package'stestscript): 575 files passed, 16943 passed, 1 todo. Base leg, the same command with the 5 diff files restored to 6bff748, tree only, under a trap, restore proven by blob == HEAD and an empty git diff HEAD: 574 passed and 1 skipped file, 16939 passed, 1 skipped, 1 todo. Delta attribution: +2 = the two tests named above. +2 passed / -1 skipped = scripts/root-entry-type-nameability.pin.test.ts, a base-leg artefact, not a change: its dist-freshness guard read HEAD's dist as stale against BASE src and took its one named skip, while at HEAD its two fresh-branch tests ran. No other count moved. (3)pnpm --filter @objectstack/spec typecheck(tsc --noEmit + check:scripts-typecheck + check:test-typecheck): exit 0; test layer 'OK — 53 file(s) / 251 error(s) / 138 pinned signature(s)', ledger unchanged. (4) Ablation, with the fix committed first (4ffdc26), one side at a time via scripts/ablation-replace.mjs, with a trap restore on absolute paths. Leg A, the contract member deleted (anchor 1 to 0, blob 7a65f2bb09 to 6c7670b9e7):tsc -p tsconfig.test.jsonreports 'src/api/analytics.test.ts(48,54): error TS2344: Type false does not satisfy the constraint true' plus the expected TS2339 at analytics-service.test.ts(106,19), and check:test-typecheck goes red naming both files. Leg B, the schema member deleted (anchor 1 to 0, blob 802e3c3e79 to a09a57b3fa): the same TS2344 at analytics.test.ts(48,54), plus TS2339 at (267,22). The only other diagnostic was pre-ledgered TS6133 at analytics-service.test.ts(27,21). Both restores were proven by blob == HEAD (7a65f2bb09, 802e3c3e79) and 0 lines of git diff HEAD. Relative imports read src, so no dist rebuild was involved. (5) Buildpnpm --filter @objectstack/spec build: exit 0, no tracked file moved (authorable-surface.base.json untouched).check:generated: 1 of 15 stale (content/docs/references/api/analytics.mdx), regenerated withgen:docs(commit 159d84d), re-run 'All 15 generated artifacts are up to date'. (6)node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 108 commands over 6 paths vs merge base 6bff748. All 108 ran and exited 0.--ranwith a per-command exit record: '108 derived, 108 run, 0 NOT-MEASURED (a DERIVED zero)'. Seven first answered exit 3 PREREQUISITE NOT MET (unbuilt packages): check:doc-formula-expressions, check:doc-security-posture, check:skill-examples, check:docs-transcript-drift, check:dual-build-cjs-loads, check:lean-entry-closure, check:type-check-debt. They were re-run green after building the lint, objectql and client-react closures. check:type-check-debt then built the rest itself: 'OK — 76/80 workspace packages type-checked'. check:dual-build-cjs-loads: '104 published require entry point(s) across 66 package(s) load'. check:liveness is green (see summary). check:nul-bytes is green. check:adr-0087-registration asks for no marker. (7) Lint, a proven narrowing and not the CI-ownedpnpm lint. Population from eslint's own config: calculateConfigForFile puts the 4 changed .ts files in scope (4 or 5 rules enabled, typeAware false) and isPathIgnored is true for the .changeset .md and the references .mdx.eslint --no-inline-config --format jsonon the 4 files: 4 files, 0 errors, 0 warnings, exit 0. Invariance: the config enables no type-aware linting (no parserOptions.project or projectService; eslint.config.mjs:326-328 states it), and the only files it reads are two baseline JSONs this diff does not touch, so no untouched file's verdict can move. CI on the PR: in_progress at the one read after opening (7 success, 2 skipped, 23 running or queued). Not waited on.","mcp_calls": "0 — no MCP GitHub tool was called; reads went through REST GETs with the session token, and writes through the fleet relay",
"api_writes": "2 — both through
scripts/pm/fleet-write/dispatch.mjs(transportdispatch, asobjectstack-fleet[bot]), each onePOST /repos/objectstack-ai/objectstack/dispatches: (1) pr_create → POST /repos/objectstack-ai/objectstack/pulls (draft forced; PR #20687, run 36605424149 success); (2) this report comment via post-stamped → POST /repos//issues/20647/comments. Plus 4 git pushes, which are not REST writes. No label, assignee or PR-state write.","open_questions": [],
"out_of_scope_findings": [
"carrier: #20644's service-analytics PR (it rewrites
AnalyticsResultWithDrillto retire.object) · noted, not filed ·AnalyticsResultWithDrill(service-analytics/src/analytics-service.ts:91) also putsdimensionFields,drillRawRows,drillRawTotalsanddrillRangeson the dataset answer. objectui's DatasetWidget reads three of them (DatasetWidget.tsx:660), and the spec contract declares none of them.packages/client/src/analytics-automation-json-erasure.test.ts:398-401says 'a key the service really emits is a key AnalyticsResult really carries', which holds forobjectonly after this PR and does not hold for those four. It is the same family as this card (dataset-answer members emitted but undeclared), with no public-door wrong answer measured, so it is recorded for the carrier and not filed. Dedupe words: AnalyticsResultWithDrill drill metadata undeclared · dimensionFields drillRawRows contract · dataset answer drill keys spec"]
}
docs(plugin-security): re-anchor the dead tracker citations to the co…
objectstack-fleet commentedon Sep 29, 2026
Landing record · PR #20687 →
35587f76ce· 2026-09-29T18:57Zdomain:specseat 5 (session_01Sfe5YjBLwB9J3y8fvm2xq1), holder of this card's claim.35587f76ce, with one parent,31ed067639. The PR'sClosesline closed this card.git patch-id --stableas the reviewed head9810aebb13against its merge base.5896169822.needs:contract-reviewwas stripped on the PR and this card before enqueue.mainnow:AnalyticsResultandAnalyticsResultResponseSchema.datadeclareobject?: string. This is the declaration only;@objectstack/specpublishes it as aminorwith the next release. No producer sets it on every dataset answer until service-analytics: a dataset query answer names its base object only inside the drill-through branches, so a dimension-less KPI answer carries noobjectand objectui's DatasetWidget subscribes to nothing (objectui#11095's producer half) #20644's service change lands.dimensionFields,drillRawRows,drillRawTotals,drillRanges) are emitted by service-analytics and read by objectui, butAnalyticsResultdeclares none of them #20700, the drill sidecars the service emits and the contract does not declare. It was escalated by the review's ③.pm:dispatchedcomes off in this act.Generated by Claude Code
feat(spec): AnalyticsResult declares object, the dataset answer's bas…
fix(service-analytics): every dataset answer names its base object (o…