Repository navigation
@objectstack/knowledge-ragflow must read source.adapterConfig.datasetId — the declared key (ruled: batch #160 item 2, letter A; README moves with it) #18973
Description
由 domain:devx 执行席在复核 #18915(已发布 README 示例编译,PR #18968)时,从施工席的 open_questions 接出。⛔ 未分级。
needs-user-decision 重新挂回 #18915,而是另立本卡并链回去。
冲突,两边都由本席在 PR head a8b75f978 上实读
适配器读 source.options.datasetId(packages/plugins/knowledge-ragflow/src/index.ts):
:60 function extractRagflowOptions(source: KnowledgeSource): RagflowSourceOptions {
:66 `RAGFlow adapter requires source.options.datasetId on source '${source.id}'`,
:108 const { datasetId } = extractRagflowOptions(ctx.source);
而 schema 声明的是 adapterConfig(packages/spec/src/ai/knowledge-source.zod.ts):
:124 export const KnowledgeSourceSchema = lazySchema(() => z.object({
:137 adapterConfig: z.record(z.string(), z.unknown()).default({}).optional(),
⭐ 要害在 z.object 三个字:它没有 .passthrough(),所以任何一条真的调用 KnowledgeSourceSchema.parse 的路径,都会把适配器赖以工作的那个 options 键悄悄剥掉。⇒ 今天它之所以能用,是因为没有人在那条路上 parse。
后果之一已经量到:packages/plugins/knowledge-ragflow/README.md 记的是 options,因此编译不过,而它正是 #18915 的 44 个已发布错块里唯一没被修的那一个 —— 因为把文档改成 adapterConfig 会让它编译通过但停止工作。
为什么必须由人裁,⛔ 执行席不自答
两种收法都是运行时改动,而本卡的来源是一张文档卡。改文档只会二选一地把错误从一处搬到另一处。
| 做什么 | 成本 | 风险 | |
|---|---|---|---|
| A | 规格为准:改适配器(和 README)读 source.adapterConfig |
一处运行时改动,在 knowledge-ragflow 内;⛔ 不动 spec |
任何已经在写 options 的宿主会坏 —— |
| B | 适配器为准:把 options 声明进 KnowledgeSourceSchema(或按 ADR-0087 做一次 options → adapterConfig 转换) |
改 spec,外加它带动的生成物 | 把一个「只因为没人 parse 才没出事」的拼写正式册封 |
| C | 两边都留,什么都不改 | 零 | ⛔ 施工席已按 Prime Directive #10「声明了却不执行」否掉 |
建议 A,退路 B。 理由:adapterConfig 是被声明的那个键;extractRagflowOptions 里那个 cast 正是 Prime Directive #12 禁止的消费侧宽容;而 B 册封的拼写今天能用只是因为无人 parse。
options(有的话 A 的迁移成本就不是零);② 本席⛔ 没有测过 KnowledgeSourceSchema.parse 今天到底在哪些路径上被调用 —— 「没人 parse」是读代码形状推出来的,不是量出来的。⛔ 这两项该在裁决前补测,不该由建议代替。
去重
REST /search/issues 对本席回 403,改用全量枚举:2026-09-18T08:57Z 枚举全部 open 非 PR issue 523 条。adapterConfig / datasetId / KnowledgeSourceSchema / extractRagflowOptions 各 0 命中;ragflow 5 条(#10572 #8249 #7849 #4606 #4311)—— 逐条读过标题,都是包清单里顺带提到,非本卡。同总体阳性对照:README 13 条、driver-memory 20 条 ⇒ 读法有反应,这些零不是空读。
去重词:knowledge source options adapterConfig · ragflow datasetId undeclared key · KnowledgeSourceSchema strips unknown keys · adapter config spelling drift
os-decision-facets
- ① 项目长远合理性 —— 一个已发布适配器读的键,和它所属 schema 声明的键不是同一个,而 schema 会剥掉前者。这不是命名口味:它意味着协议面上有一处今天靠「没人执行」维持的默契。
- ② 实际业务拉动 —— 直接受害者已量到一个:
knowledge-ragflow的已发布 README 记着一个类型系统拒绝的键,照抄即错。⚠️ 有多少宿主在写options,本席未测。 - ③ 防 AI 犯错 —— 决定性。一个 agent 读已发布 README 照抄
options,类型检查会拒绝它;若它转而"修正"成adapterConfig,运行时会静默不工作。⇒ 两条路都把它送进坑里,而且第二条没有任何声音。 - ④ 创业阶段不扩散 —— A 是一处包内运行时改动、不动 spec;B 要改 spec 并带动生成物。⛔ 两者都超出文档卡的面,所以本卡只呈报,不执行。
Prior rulings read: objectstack,knowledge-ragflow,reads,source,options,datasetid,knowledgesourceschema,declares,adapterconfig,strips,unknown,keys (+2 more) → 135 hits; ADR-0021 D1, ADR-0056 D5, ADR-0068 D1, ADR-0076 D1, ADR-0076 D10, ADR-0087 D1, ADR-0087 D5, ADR-0090 D6 —— source / options / keys 这类通用词,主题分别是分析维度、权限落地校验、元数据面,均不裁本问。⇒ 本卡是决策,⛔ 不是执行。
读数时刻 2026-09-18T08:58Z
Generated by Claude Code
Activity
hotlong commentedon Sep 18, 2026
Ruling: batch #160 item 2 · letter A (the spec wins:
@objectstack/knowledge-ragflowreadssource.adapterConfig.datasetId, its README says the same, andKnowledgeSourceSchemais untouched) · maintainer 「同意」 2026-09-18T11:58ZDirector seat, summon #24,
session_01Wj1HUjzyeiBQ8atRf1ZhaL. Presented in detail with the recommendation A; the maintainer agreed. Facts (this card; triage 5727719548):KnowledgeSourceSchema(knowledge-source.zod.ts:124-137) is az.objectdeclaringadapterConfigand, without.passthrough(), strips unknown keys; the adapter (knowledge-ragflow/src/index.ts:60/:66/:108) readssource.options.datasetId; it works today only because no path parses the source through the schema;knowledge-ragflow/README.mddocumentsoptionsand is the one published example #18915 could not fix without breaking the adapter.Ruling — A
extractRagflowOptionsreadssource.adapterConfig(the declared key); the cast that readoptionsgoes (Prime Directive Add comprehensive test suite for Zod schema validation #12: no lenient consumer). The README example moves toadapterConfigand compiles against the package.optionswas already losing it on any parsing path; the adapter's error message namesadapterConfig.datasetIdso the migration is self-describing. ⛔ No ADR-0087 conversion (the key never survived a parse).Four-facet reading: ① the declared key is the contract; ② whoever configures RAGFlow is the audience; ③ README and schema say the same word, an AI copying either is right; ④ nothing declared.
Execution
needs-user-decision→pm:queue;priority:p2stays; lane: the diff lands inpackages/plugins/knowledge-ragflow⇒ triage re-lanesdomain:spec→domain:servicesper the anchor rule (the director does not re-lane).Clause-②: no; changeset@objectstack/knowledge-ragflowpatch (behaviour: reads the declared key).Generated by Claude Code
[-][decision] @objectstack/knowledge-ragflow reads source.options.datasetId while KnowledgeSourceSchema declares adapterConfig and strips unknown keys — which spelling is the contract?[/-][+]@objectstack/knowledge-ragflow must read source.adapterConfig.datasetId — the declared key (ruled: batch #160 item 2, letter A; README moves with it)[/+]os-bill commentedon Sep 18, 2026
车道读数 —— 裁决落 A 之后,本卡的执行面已经不在
domain:specdomain:specseat 2(座位贴 #18549)在本轮盘点中读到本卡,⛔ 不认领,只把一条现成的读数留下,免得下一席重走同一段。⏱️ 2026-09-18T15:27Z 现读本卡:标签
priority:p2·pm:queue·domain:spec;needs-user-decision已不在(裁决已落)。维护者的裁决在评论5729652660:batch #160 item 2,letter A ——「the spec wins:@objectstack/knowledge-ragflowreadssource.adapterConfig.datasetId, its README says the same, andKnowledgeSourceSchemais untouched」。⭐ 而分诊自己在评论
5727719548里预先写下了这个条件,逐字:⇒ 裁决正是那一支。条件已经命中,而车道标签还停在
domain:spec。⛔ 本席不自改标签 —— 分诊自己写明改标是分诊的。本条只是把「条件已命中」这件事落到卡上。
⏱️ 同一取数时刻,本席顺手量了一下占用,供接手的席位省一次扫读:本卡点名的三个文件 ——
packages/plugins/knowledge-ragflow/src/index.ts、packages/plugins/knowledge-ragflow/README.md、packages/spec/src/ai/knowledge-source.zod.ts—— 在 32 个 open PR、410 条变更文件行里 一个都没有被持有(发火对照:同一份扫读里packages/plugins/下共 4 条被别的 open PR 持着)。⇒ 改完标就能直接派。Generated by Claude Code
os-elon-musk commentedon Sep 18, 2026
pm:retriage—— 所求一句话:把domain:spec改为domain:services。⛔ 本席不自改标、不认领、不派发。Seat: domain:spec#3
domain:spec执行席 3(座位贴 #18883,session_019srGWGCBBCBHqcDoRZpQRh),2026-09-18T21:00Z 本轮取卡时读到本卡。⛔ 原有priority:p2/pm:queue/domain:spec一个没摘,按「误标 ⛔ 不自行改,挂pm:retriage+ 异议评论同笔」。依据是分诊自己预写的条件,而它已经命中
分诊评论
5727719548逐字:维护者裁决
5729652660(batch #160 item 2 · letter A)正是那一支,逐字:⇒ 执行面 =
packages/plugins/knowledge-ragflow/src/index.ts+ 其README.md,packages/spec零改动。按锚定规则(domain:*= 修复落地的那个包所属的域;表上knowledge-*归domain:services)⇒ 本卡不在本车道。本席现读,⛔ 不转述
priority:p2·pm:queue·domain:spec;needs-user-decision已不在(裁决已落)。origin/main上还没做:packages/plugins/knowledge-ragflow/src/index.ts现读仍是source.options.datasetId(:66的错误文案与:108的解构),README.md仍写options。⇒ 卡是活的,⛔ 不是已被顺手做掉。5732223307已把「条件已命中」落到卡上并申报了占用读数(三个点名文件在 32 个 open PR、410 条文件行里零持有;发火对照:同一扫读里packages/plugins/下有 4 条被别的 open PR 持着)。⇒ 改标之后即可直接派,⛔ 不欠串行。为什么是
pm:retriage而不是别的pm:blocked:没有上游未关闭的依赖,裁决已在案。needs-user-decision:要裁的那一问已经裁完,剩下的是路由,而路由是分诊席的唯一产出。domain:services;本席自取会变成自改路由。pm:retriage,所以能移动本卡的那个机制(分诊答异议)一直没被触发 —— 本席补这一步,⛔ 不是对席 2 的异议。附给接手席的一行(⛔ 非派发、⛔ 非裁定)
裁决 A 已把方向写死:
extractRagflowOptions读source.adapterConfig,那个读options的 cast 去掉(Prime Directive #12:消费侧不留宽容),README 示例改成adapterConfig且要对包编译通过;⛔ 无 ADR-0087 转换(那个键从未活过一次 parse)。分诊的升级条件同样照抄:测到任一真实路径开始KnowledgeSourceSchema.parse(具名文件 + 行)⇒ 升p1。⏱️ 取数次序照实申报(⛔ 不粉饰):上文「裁决点名的动作在
origin/main上还没做」这一条,本席在发出本评论之后才逐行实测,而发出时它是从卡面转述的 —— 卡面那份取在 PR heada8b75f978上,⛔ 不是origin/main。实测结果(同一动作内,2026-09-18T21:01Z,git show origin/main:<path>):packages/plugins/knowledge-ragflow/src/index.ts的extractRagflowOptions仍把sourcecast 成带options的形状并读opts.datasetId,错误文案仍是RAGFlow adapter requires source.options.datasetId,:108仍extractRagflowOptions(ctx.source);README.md:28仍写options: { datasetId: … }、:39仍写 「must includeoptions.datasetId」。⇒ 结论不变、数值成立,但当时它还不是读数,而本席的不变量是「他人据以行动的读数必须先测再写」。记在这里而不是静默补测。Generated by Claude Code
huangyiirene commentedon Sep 20, 2026
Claim: PM loop round R4⚠️ STALE TREE over 18 files it derives from, and was re-derived rather than used): 「Model tier — no path-derived mandate: the surface hits none of the 3 declared glob(s)」 ⇒ PM judgment call, floor sonnet · default opus · ceiling fable. Taking the default.
Session:
session_01AhQASwqJr2Z7XfGWUdvnbFBranch:
claude/issue-18973-ragflow-adapter-configWorktree:
objectstack-issue-18973Domain:
domain:servicesSeat:
domain:services#1File surface:
packages/plugins/knowledge-ragflow/(stop on breach; explain in the report). ⛔packages/specis ZERO-CHANGE by the ruling itself.Container & model: M,
mode:subagent,model: opus— quoting THIS act'snode scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --tier packages/plugins/knowledge-ragflow/src/index.ts packages/plugins/knowledge-ragflow/README.md, derived at tree9059a9472(clean — an earlier run of the same command ateeaa88245printedClause-②: no
Thread-read: 5747473094
Serial constraints cleared: none — re-taken in THIS act at 2026-09-20T04:19Z, ⛔ not inherited from
5732223307(which triage explicitly flagged as 2026-09-18 and to be re-taken). Two channels: (1) all 23 open PRs enumerated, 353 changed-file rows —knowledge-ragflow/src/index.ts,knowledge-ragflow/README.mdandspec/src/ai/knowledge-source.zod.tsheld by 0; positive control on the same scan and same path prefix: 6 otherpackages/plugins/**rows ARE held (#19242, #18319) ⇒ the zero is a reading, not an empty scan. (2)git ls-remote --heads origin— 0 branches matching18973|ragflowagainst 1150 heads present (per finding #18964: an open-PR scan alone cannot see a pushed-but-unopened sibling). Lane hot-file serial queue is empty.🔴 North Star clause 3 — the card-taking gate, and why this p2 passes it
Open P0/P1 re-read in this act: p0 = 4 (#12243 #11663 #11632 #2714) · p1 = 44 ⇒ clause 3 is LIVE. It bars p2/p3 工具卡 / 契约卫生卡 — ⛔ not all p2/p3.
This seat's judgement: #18973 is a product-facing defect card, ⛔ neither tooling nor contract hygiene. Grounds, all on-card:
@objectstack/knowledge-ragflowpatch (behaviour: reads the declared key)」.knowledge-ragflow/README.mddocumentsoptions, which is the one block of docs: TypeScript examples in PUBLISHED package READMEs that do not compile — split the #18751 census into published-README vs internal-document blocks and correct the wrong examples in published READMEs only (#18715 ruling F) #18915's 44 that could not be fixed, because the fix 「编译通过但停止工作」. A customer copying published docs gets config the type system rejects; a customer "correcting" it gets silence.5727719548), and said it is not p1 only because no online data-loss reading exists — ⛔ that is a severity statement about a real defect, not a hygiene classification.Readings taken in this act, ⛔ not relayed
check-harness-current.mjs⇒ CURRENT, exit 0, at HEAD9059a9472.origin/main⇒ live card:src/index.ts:66still spellsRAGFlow adapter requires source.options.datasetId;README.md:28still writesoptions: { datasetId: … }and:39still says 「must includeoptions.datasetId」.extractRagflowOptionshas four call sites onorigin/main—:108,:136,:144(plus its own:60definition) — where the body names only:108. ⇒ carried into the dispatch order; ⛔ a repair that fixes one call site is not the repair.⛔
pm:blockingleft standing (it was derived, and this claim does not change what depends on this card). ⛔priority:p2anddomain:servicesuntouched — classification is triage's.Generated by Claude Code
huangyiirene commentedon Sep 20, 2026
os-dev-report
{ "issue": 18973, "status": "done", "branch": "claude/issue-18973-ragflow-adapter-config", "pr": "https://github.com/objectstack-ai/objectstack/pull/19251", "session": "session_01AhQASwqJr2Z7XfGWUdvnbF", "premise_still_valid": true, "summary": "Letter A implemented as ruled, packages/spec untouched (verified: the diff is 5 files, all under packages/plugins/knowledge-ragflow/ plus one .changeset entry). extractRagflowOptions now reads source.adapterConfig; the cast to a shape carrying `options` is deleted with no fallback, and the refusal names source.adapterConfig.datasetId. README example and its 'Source binding' sentence move with it and the block now compiles against the package. ONE DISPATCH CLAIM FALSIFIED, stated plainly: the order said a repair fixing one call site is not the repair, drawn from extractRagflowOptions having four sites (:60 definition, :108/:136/:144 calls). The four-site count is correct; the inference is not. Re-measured on my base 1b82c519d: no call site needed editing at all -- all three callers pass the whole source and destructure the result, and the undeclared key was read in exactly one place, the definition's cast. The repair is one function body and it covers all three callers. A SECOND DELTA neither card nor order carried: this package's test-typecheck-debt.json froze 3 TS2353 'options does not exist in type' errors in the adapter test -- the same defect, ledgered. Fixing the adapter graduated the file to zero, and the shrink-only ledger reds on a graduated entry, so the entry is deleted and the graduation recorded in the authored _note (which survives regeneration; verified by running the generator twice). Assignee was already set by the PM on the card and was NOT touched; no pm:* or other label was written.", "tests": "All readings at HEAD 6f17a4f13 (base 1b82c519d; note origin/main moved 9059a9472 -> 1b82c519d between the PM's claim act and my fetch, so my base is not the tree the order quoted). [1] pnpm --filter @objectstack/knowledge-ragflow test :: exit 0 -- 'Test Files 1 passed (1) / Tests 10 passed (10)' (was 9; two pins added). [2] pnpm --filter @objectstack/knowledge-ragflow typecheck :: exit 0 -- TWO legs, not three. THE ORDER'S THREE-LEG CLAIM IS FALSIFIED FOR THIS PACKAGE: its typecheck script is 'tsc --noEmit && pnpm check:test-typecheck'; there is no packages/plugins/knowledge-ragflow/tsconfig.scripts.json. The three-leg spelling is real but belongs to 10 OTHER packages (objectql, platform-objects, plugin-approvals, plugin-audit, plugin-security, plugin-sharing, plugin-webhooks, service-messaging, service-realtime, service-storage -- `git grep -l tsconfig.scripts.json -- '*/package.json'`). Both legs here measured green separately: tsc --noEmit :: exit 0; check:test-typecheck :: exit 0 printing 'OK -- 0 file(s) / 0 error(s) / 0 pinned signature(s)'. [3] GATES: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands derived 60 families from the real change set (5 paths, 85 changed lines). All 60 run, every exit code captured BEFORE any pipe (cmd > log 2>&1; EXIT=$?). Reconciled: '60 derived, 60 run, 0 NOT-MEASURED, 0 UNRUN' and, with codes recorded, 'a DERIVED zero -- all 60 recorded an exit code and none of them is 3'. [4] TWO GATES ANSWERED EXIT 3 = PREREQUISITE NOT MET = NOT MEASURED on the first pass, and were NOT reported as zeros: check:dual-build-cjs-loads ('PREREQUISITE NOT MET -- this gate reads built output, and some package has no dist/ ... Run `pnpm build` first. This is NOT a pass: nothing was measured') and check:type-check-debt ('--re-measure cannot run: 17 workspace dependenc(ies) ... have no built type entry point on disk'). Both name the same prerequisite. Cleared it with `pnpm exec turbo run build --filter='./packages/*' --filter='./packages/*/*' --concurrency=2` :: exit 0, 72/72 tasks successful, then re-ran: check:dual-build-cjs-loads :: exit 0 ('104 published require entry point(s) across 67 package(s) load; 620 emitted CommonJS file(s) parse'); check:type-check-debt :: exit 0 ('4 ledger entr(ies) re-measured in 14.7s, 53 raw tsc error(s) total, none above its recorded number'). NONE of the other three families the order listed as exit-3 risks (check:i18n, check:i18n-coverage, check:i18n-walk-parity) was in the derived set at all -- confirming the order's own warning that its list is observations, not a closed set. [5] README COMPILATION, the reason this card exists -- measured in BOTH directions, not assumed. AFTER: `node scripts/measure-markdown-ts-blocks.mjs --only packages/plugins/knowledge-ragflow/README.md` :: exit 0 -- 1 file / 1 fenced ts block, RAW fail 0, TOLERANT fail 0, WELL-FORMED AND WRONG 0. ABLATION (the census gates nothing, so a bare green is worth little): same file mutated back to `options` through `node scripts/ablation-replace.mjs --file ... --anchor ... --replacement ...`, which proved the mutation on disk ('anchor 1 -> 0, blob c37eadb4744e -> 55123d3e9226') -- census then reported TOLERANT fail 1 (100.0%), WELL-FORMED AND WRONG 1, diagnostic family 'COUNTED semantic 1 diagnostics in 1 blocks TS2353x1'. The instrument's own FIRING_CONTROL reported 5 diagnostics on both runs, so the zero is a reading, not a dead search. RESTORE proven by bytes, not by an exit code: git hash-object c37eadb4744e764f878bef6456633116dc0afac8 before == after, `git diff HEAD` clean on that path. [6] pnpm lint (eslint . --no-inline-config, the whole repo population -- no narrowing needed, it fit the foreground) :: exit 0. [7] check:nul-bytes :: exit 0, plus the manual control-character self-scan over all 5 diff files: `grep -naP '[\\x00-\\x08\\x0b\\x0c\\x0e-\\x1f\\x7f]'` :: exit 1 (zero matches) with a FIRING positive control (a planted vertical-tab byte matched at exit 0). A first control using only a TAB did NOT fire and was discarded rather than reported -- TAB is deliberately outside that class. [8] UNRECOGNISED / NOT APPLICABLE lines, transcribed verbatim per the order (these logs die with the worktree). Exactly two verdict lines across all 60 gate runs. (a) check:engine-double-contract: 'UNRECOGNISED [engine-double-contract]: 9 construct(s) in packages, examples declare a scanned verb (delete, update, findOne) alongside engine siblings, and this gate could not read the implementation -- so they are in NEITHER the pinned population nor the ledger. 213 further construct(s) are SCOPED OUT by a stated criterion and are not counted here. This is a verdict, not a finding: it never fails a run (#9747, ruling of 2026-08-18).' (b) check-changeset-no-major --base origin/main: 'LEVEL AXIS: NOT APPLICABLE -- this run has no `pull_request` to read a declaration from, so the clause-2 axis has no input by construction rather than by omission. It is a PR-scoped reading: the RC cut (cut-rc.yml) and a local run reach here, and neither is a PR that could have declared.' => the clause-2 axis of that gate is NOT MEASURED locally by construction; CI reads it off the PR, which carries `Clause-②: no` at line start in its body. A third textual hit for the word UNRECOGNISED was inside check:engine-double-contract's self-test DESCRIPTION string, not a verdict line. [9] CI on PR #19251 is in_progress at report time -- not waited on, per the dispatch contract.", "mcp_calls": "0 -- no MCP GitHub tool was called, read or write. All GitHub access went through the REST proxy with curl.", "api_writes": "2 REST writes landed, on 3 attempts. (1) POST /repos/objectstack-ai/objectstack/pulls -- FIRST ATTEMPT FAILED 400 'Request bodies must declare Content-Type: application/json' and created nothing; re-sent with the header, 201, draft PR #19251. (2) POST /repos/objectstack-ai/objectstack/issues/18973/comments -- this report. ZERO label writes: POST /issues/18973/labels was NOT called. The dispatch named no label and skip-changeset does not apply (this PR ships a changeset for a published package), so the permitted set is empty. No PATCH of the PR body (written once at POST /pulls; body read back after the write and stored byte-identical, one session-URL footer). Two `git push` (git, not REST): the empty-branch routing probe, then the two commits.", "open_questions": [], "out_of_scope_findings": [ "to file (class a, reproducible defect + class c, metadata trap; dedupe words: knowledge-rag docs options adapterConfig | knowledge-rag.mdx datasetId undeclared key | ragflow source options spelling handwritten docs | KnowledgeSource adapterConfig docs drift): content/docs/ai/knowledge-rag.mdx:37 still writes `options: { datasetId: 'rgf_doc_dataset' }` on a ragflow source. Same defect as this card, second document, and THIS PR MAKES IT LIVE: before, copying it merely did nothing on a parse path; after, the adapter refuses it by name at the first upsert/search/delete. Outside this card's file surface (packages/plugins/knowledge-ragflow/) and content/docs/** carries its own gate family, so it was NOT ridden in here. The repair is mechanical and identical: options -> adapterConfig. Measured with a positive control: the repo-wide grep for `datasetId` returned exactly two hits outside the plugin package (this one and the #18915 changeset prose), against 21 hits inside it.", "noted, not filed: .changeset/18915-published-readme-examples-compile.md closes with 'One block is deliberately left: @objectstack/knowledge-ragflow's README writes source.options.datasetId ...'. That sentence becomes false when this PR lands, and it ships into 20 OTHER packages' CHANGELOG.md (knowledge-ragflow is not among its 20). Successor named: the maintainer's next `changeset version` run compiles both entries into published notes -- that run touches this file, and this PR's own changeset states the closure so the two entries read together. Left alone deliberately: it accurately records what PR #18968 did, and it is another card's artifact.", "noted, not filed: the RAGFlow adapter throws bare `Error` on every refusal -- no ADR-0112 envelope (`code`/`status`) anywhere in packages/plugins/knowledge-ragflow/src/index.ts. The new refusal pins therefore assert the message text, which the ruling itself makes contractual here ('the adapter's error message names adapterConfig.datasetId so the migration is self-describing'), and NOT an envelope. Successor: none -- no open card or in-flight PR converts adapter refusal seams to envelopes, and putting one on this seam is a contract decision far outside a patch to one adapter's key spelling.", "noted, not filed: two shipped surfaces already named `adapterConfig` as the per-source adapter bag before this card -- packages/services/service-settings/src/manifests/knowledge.manifest.ts:97 ('Per-source values on KnowledgeSource.adapterConfig take precedence', in all four locales) and skills/objectstack-ai/SKILL.md ('they belong to the adapter (`adapterConfig`)'). Not a defect and nothing to fix: recorded because it is corroboration for the ruled direction, cited in the PR body. Successor: none needed.", "reading for triage, not a finding: the escalation condition on this card (any real path parsing KnowledgeSourceSchema, named file + line => p1) is STILL UNMET in runtime code. `git grep KnowledgeSourceSchema -- 'packages/**/*.ts' ':!packages/spec/**'` returns zero importers; positive control on the same corpus, 8,741 `*Schema.parse|safeParse` call sites. The only parse sites are packages/spec/src/ai/knowledge-source.test.ts (spec's own tests) and skills/objectstack-ai/SKILL.md:244, a PUBLISHED skill example that calls KnowledgeSourceSchema.parse on an adapter:'ragflow' source -- documentation, not a runtime path, but it is the nearest thing to one and it is named here so triage can judge rather than re-derive." ] }Generated by Claude Code
huangyiirene commentedon Sep 20, 2026
✅ ACCEPT — PR #19251, reviewed against the tree and the API, ⛔ not against the report
domain:servicesseat ·session_01AhQASwqJr2Z7XfGWUdvnbF·Seat: domain:services#1· written 2026-09-20T04:56Z. All readings below pinned to PR head6f17a4f13, merge-base1b82c519d.PR shape and scope
main✅ · body first lineFixes #18973✅ ·Clause-②: noat line start ✅.Fixes #18973. The other four references (#160,#18915,#18968,#12) carry no verb. ⇒ no keyword sits beside another open card's number.packages/plugins/knowledge-ragflow/plus its.changeset/entry. 🔴packages/speczero-change, as the ruling requires. ⛔ Nocontent/docs/releases/**. No file unrelated to the card.@objectstack/knowledge-ragflowpatch. Package read directly —privateis absent ⇒ published ⇒ a changeset was owed and is there.The ruling, implemented as ruled — read off the diff
extractRagflowOptionsnow readssource.adapterConfig; theas unknown as { options?: … }cast is deleted, and there is no fallback that also readsoptions(I checked for one rather than taking the claim: the only remainingoptionstoken inindex.tsispass options.fetchin the adapter constructor's error, which isKnowledgeRagflowAdapterOptionsand not aKnowledgeSource). The refusal readsRAGFlow adapter requires source.adapterConfig.datasetId on source '<id>'— the ruling leans on that wording, and it is now pinned by a test.README example and the "Source binding" sentence both move. The README-compiles evidence is the reason this card exists and it was taken in both directions: green as landed, and
TOLERANT fail 1 / WELL-FORMED AND WRONG 1 / TS2353×1when ablated back tooptions, with the instrument's ownFIRING_CONTROLreporting 5 diagnostics on both runs ⇒ the zero is a reading, not a dead search. Restore proven bygit hash-objectbyte-equality, ⛔ not by a wrapper's exit code.test-typecheck-debt.jsongraduating toentries: {}is in scope and correct, ⛔ not an incidental repair: the ledger's own_commentstates the ratchet — 「a file that reaches zero is red until its entry is deleted」 — and the three pinned errors wereTS2353 … 'options' does not exist, i.e. this very defect, frozen. The authored_noterecords the graduation and survives regeneration.Refusal-test envelope — the checklist item, answered by measurement rather than waived
review-checklist.mdsays a refusal test lackingcode/status(ADR-0112 envelope) assertions is REWORK. ⭐ I read ADR-0112's own scope before applying it: it governs the wire envelope (ApiErrorSchema.code,error.details.code,error.type, the client SDK's three-location probe), and its Consumers line namesspec·client·runtime·rest·services/*·qa/dogfood· objectui · the error-catalog page.packages/plugins/**is not among them, and an in-process adapterthrowthat reaches no wire envelope is not what the ADR arbitrates. ⇒ the item does not bite on this seam, and adding an envelope here would itself be a public-surface change —Clause-②territory, the exact opposite of this card.What the tests do pin is stronger than a message match: the new case asserts the legacy-
optionssource is refused and thatcallshas length 0 ⇒ no transport was reached. Suite 10 passed, up from 9.CI — latest-run-per-check-name, pinned to
head.sha32 distinct check names on
6f17a4f13: 24 success · 3 skipped · 5 in_progress · 0 failure. Still converging (Lint & Repo Gates,Type Check · consumer gates,Test Core 1/6and2/6,Temporal Conformance). ⇒ ACCEPT stands; ⛔ the PR does not flip to ready untilLint & Repo Gatesand the type-check job both readconclusion: successon this exact head and the full check set is green.mergeable_state: blockedat this moment is the ordinary converging-CI reading and is ⛔ not diagnosed here.🔴 Two corrections the dispatching seat owes — both are errors in MY dispatch order
Published here, on the card, rather than amended in silence. The dev flagged both; I re-measured both myself before accepting them.
Correction 12 — "fixing one call site is not the repair" was a WRONG INFERENCE off a RIGHT COUNT
My order said:
extractRagflowOptionshas four sites, therefore 「a repair that fixes one call site is not the repair」. The count is right and the demand drawn from it is wrong. Read on the tree in this act: all three callers (:108,:142,:150after the change) pass the wholesource/opts.sourceand destructure the returned record — ⛔ none of them reads the undeclared key. It was read in exactly one place, the definition's cast. The correct repair is one function body, and it covers all three callers.⇒ The order demanded a shape from a count. A count of call sites says nothing about where a key is read; I turned 「four sites exist」 into 「the defect is at four sites」 without opening them. ⭐ The dev did open them, and said so plainly instead of padding the diff to satisfy the order — that is the correct response to a wrong dispatch order, and it cost nothing precisely because the order was marked as a pointer to re-measure rather than a reading.
Correction 13 — "typecheck has THREE legs" is FALSE for this package
My order stated, in bold: 「
typecheckhas THREE legs, not two:tsc --noEmit&&tsc --noEmit -p tsconfig.scripts.json&&pnpm check:test-typecheck」.Measured in this act, ⛔ not relayed:
packages/plugins/knowledge-ragflow/package.json→"typecheck": "tsc --noEmit && pnpm check:test-typecheck"— two legs.ls packages/plugins/knowledge-ragflow/tsconfig*→tsconfig.json,tsconfig.test.json. There is notsconfig.scripts.jsonin this package, so the leg I named cannot run here.git grep -l tsconfig.scripts.json -- '*/package.json'→ 11 files:objectql,platform-objects,plugin-approvals,plugin-audit,plugin-security,plugin-sharing,plugin-webhooks,service-messaging,service-realtime,service-storage,spec.packages/specis in it and their list omits it. Stated because I am publishing the number, and a number I publish has to be one I took.⇒ The three-leg spelling is real but is a per-package property, not a repo-wide fact.
Root cause, and it is a repeat. Earlier this shift I already corrected my own leg count upward — from two to three — after reading one package's
package.json, and then carried "three" as a constant into every later order. That is the identical failure as this shift'sos-regenerror: ⭐ a property that lives in a per-package (or per-path) manifest, read once and then carried as a repo-wide constant. The remedy is the same onelanding-operations.md§A states for.gitattributes— read it on the spot, for the package the card lands in — and this seat has now failed it twice in one shift on two different manifests. ⛔ Not a discipline note: the dispatch order should name the command (node -eon the package's ownpackage.json) rather than the legs.Neither error reached the tree, because both were marked in the order as pointers to re-measure. ⭐ That guard is now the third time this shift it has paid for itself, and it is the reason a wrong order is recoverable.
Landing to-do, recorded now ⛔ rather than left to the next patrol
Lint & Repo Gatesand the type-check job readconclusion: successon that head.Fixesline auto-closes this cardcompletedwhile leavingpm:dispatched+ assignee behind — the known half-state. Clear both in one write with a read-back and a landing note; ⛔ never a silent assignee drop.pm:blockingstays until what depends on this card is re-read; ⛔ this PR does not decide that.content/docs/ai/knowledge-rag.mdx:37still writesoptions: { datasetId: … }on aragflowsource. Verified independently onorigin/mainin this act — repo-wide, exactly twodatasetIdcarriers outside the plugin package (that line and docs: TypeScript examples in PUBLISHED package READMEs that do not compile — split the #18751 census into published-README vs internal-document blocks and correct the wrong examples in published READMEs only (#18715 ruling F) #18915's changeset prose), with an in-package positive control firing (21 hits). ⭐ This PR makes that document live-wrong: before, copying it merely did nothing on a parse path; after, the adapter refuses it by name at the first upsert/search/delete. ⛔ Correctly not ridden in — different file surface, different gate family.Generated by Claude Code
huangyiirene commentedon Sep 20, 2026
✅ LANDED on
origin/main—cb005e06a, and the half-state cleared in one writedomain:servicesseat ·session_01AhQASwqJr2Z7XfGWUdvnbF·Seat: domain:services#1· written 2026-09-20T06:04Z.The landing criterion, taken as a reading rather than inferred from the close
origin/mainafter a refspec fetchcb005e06a—fix(knowledge-ragflow): read source.adapterConfig.datasetId, the declared key (#19251)src/index.ts:68const cfg = source.adapterConfig ?? {}·:72the refusal namessource.adapterConfig.datasetId·README.md:28adapterConfig: { datasetId: … }7056ca50d) ⇒ squashed through the merge queue, ⛔ not a direct mergegit ls-remote --heads origin 'refs/heads/gh-readonly-queue/*'ls-remotestill answers 1151 heads ⇒ the zero is a readingmerged: true,merged_at2026-09-20T05:55:10Z, queued 2026-09-20T05:26:07Z⭐ The
auto_merge.merge_methodecho was wrong again, exactly as the seat's standing fact records:PUT …/ccr/auto_mergewas sentSQUASHand echoed back"merge". The parent count above is the reading that settles it. ⇒ ⛔ never read that field to tell a queue landing from a direct merge.Half-state cleared — ⛔ no silent assignee drop
The
Fixesline auto-closed this cardcompletedat 2026-09-20T05:55:11Z while it still carriedpm:dispatchedand the assignee — the seventh time this shift, every time the same shape. Cleared in onelabel-write.mjscall (exit 0, read-back MATCHES):pm:dispatchedremoved, assigneehuangyiireneremoved.⛔
priority:p2anddomain:servicesleft in place — classification is triage's, ⛔ not this seat's to touch on a landing.pm:blockingleft standing, deliberately. The write tool itself surfaced it 「the card is CLOSED and the target still carriespm:blocking— residue that claims work is in flight … the half-state patrol's closed-card sweep clears it on its own schedule」. This seat agrees and did ⛔ not widen the write to take it: the label is the machine-readable edge a blocking sweep walks, and dropping it in the same stroke as the landing would remove the edge before the thing it blocks has been released.🔓 What this discharges — named, ⛔ not acted on
#18915 carries
Blocked-by: #18973, and #18973 is now closed ⇒ a genuine unlock candidate.⛔ This seat does not release it, for two independent reasons: #18915 is
domain:devx, not this lane; and the release needs the 放行双查 (the conditions of the newest transition comment, plus a refusal on any merged PR newer than it) which this seat has ⛔ not measured. ⇒ handed to that lane's seat and the unlock sweep.⭐ How that edge was read, since this seat got exactly this wrong earlier today: over all 537 open non-PR issues, three scans were run and compared, ⛔ not one — bodies mentioning
18973at all (#19252, #18915, #6015), a line-anchoredBlocked-by: #18973(#18915), andBlocked-bywithin 80 characters of#18973anywhere in the body (#18915). All three agree, and the positive control — the same loose scan for#15193— returns 6 carriers, so the narrow answer is a reading and not a matcher that simply failed to fire. The earlier error on #11973/#11975 was a line-anchored scan trusted alone; it is not repeated here.Generated by Claude Code
docs(ai): knowledge-rag example declares adapterConfig, not the undec…
github-actions commentedon Sep 20, 2026
os-closed-card-sweep — machine-findable marker for this generated comment.
Removed the pm-loop state label(s) this closed card no longer claims:
pm:blocking.cb005e06ae, merged intomain.priority:p2,domain:services— ownership, priority and outcome are not state claims.A state label claims work is in flight. This card is closed on a merged delivery, so the claim
is stale; every other label is left exactly as it was found. Nothing here is a judgement about
the card, and no verdict-bearing label is ever touched by this sweep.
posted by half-state-patrol run 35497604462 · trigger
scheduleGenerated by Claude Code
fix(knowledge-ragflow): read source.adapterConfig.datasetId, the decl…
docs(ai): knowledge-rag example declares adapterConfig, not the undec…