Skip to content

Commit d6ee25e

Browse files
committed
docs(ui-import): steps 1-2 run on the cutover tree as it now stands (objectstack#25711, WIP)
Measured on cutover head c04b36d: one objectui changeset name collides with a root one (react-pages-default-off.md), so a colliding name moves under a `ui-` prefix; ui/.objectstack-pin is already gone, so the deletions take --ignore-unmatch. Removing the claims test's markdown-test-inputs row leaves ui/.github/pull_request_template.md with no reader and reds the totality test; the nested template never renders (GitHub reads the root one), so step 2 deletes it. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149BHSXfCdQywGaLdpRAtWe
1 parent 9a776c6 commit d6ee25e

1 file changed

Lines changed: 22 additions & 5 deletions

File tree

‎scripts/ui-import/README.md‎

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,18 @@ From the monorepo root, on the tree the subtree PR produced:
6464

6565
```sh
6666
# 1. Pending objectui changesets join the root ones (changesets reads one directory).
67+
# A name the root already uses (react-pages-default-off.md on the cutover tree)
68+
# keeps its objectui text under a `ui-` prefix.
6769
for f in ui/.changeset/*.md; do
68-
[ "$(basename "$f")" = README.md ] || git mv "$f" .changeset/
70+
b=$(basename "$f"); [ "$b" = README.md ] && continue
71+
if [ -e ".changeset/$b" ]; then git mv "$f" ".changeset/ui-$b"; else git mv "$f" .changeset/; fi
6972
done
7073

71-
# 2. The deletions.
72-
git rm -r -q -- \
74+
# 2. The deletions. `--ignore-unmatch`: the cutover tree already dropped
75+
# ui/.objectstack-pin. The nested pull_request_template.md never renders (GitHub
76+
# reads the root one) and its only markdown-test-inputs reader was the claims test.
77+
git rm -r -q --ignore-unmatch -- \
78+
ui/.github/pull_request_template.md \
7379
ui/.changeset/config.json \
7480
ui/.objectstack-sha ui/.objectstack-pin \
7581
ui/.github/workflows/changeset-release.yml ui/.github/workflows/spec-range-floors.yml \
@@ -119,13 +125,24 @@ Measured on 2026-10-25:
119125
`type-check:vitest-config`, `lint:root` exit 0, and root and objectui
120126
`check-changeset-fixed` both pass (112 public packages plus `object-ui` at that base).
121127
`changeset version` moved all 113 to 18.2.0 together, `object-ui` included;
122-
- on the cutover head `1c0d02eda4` (objectui frozen at `9e1fe03286`), with steps 1–3 and
128+
- on the cutover head `1c0d02eda4` (objectui frozen at `9e1fe03286`), with step 3 and
123129
the root half of 4a: `@object-ui/runner` is private there and in objectui's `ignore`
124130
(objectui#13506), so the root `fixed` group drops it and the root `ignore` takes it.
125131
Root and objectui `check-changeset-fixed` exit 0 (111 public packages plus `object-ui`),
126132
`check:lockstep-package-count` reads 111, and `changeset version` moves all 112 members
127133
to 18.2.0 together while `@object-ui/runner` stays at 18.1.0;
128-
- `vitest run scripts/__tests__`: 17 failed / 5,573 passed. Two of them are 15 s
134+
- on the cutover head `c04b36dcb9` with steps 1–3 and the root half of 4a, against the
135+
same head without them (both installed, neither built): `vitest run scripts/__tests__`
136+
clears the 12 the cutover leaves to 4a (`check-installed-spec-pin-claims` ×4,
137+
`quick-reference-current-release-4143` ×3, `sync-quick-reference-release` ×5) and the
138+
rest of the deleted pin class with them. It adds 12 that read objectui's nested
139+
`ui/.github/workflows/` (`ci-cd-pipeline-doc` ×9, `workflow-cache-save-bound` ×2,
140+
`check-pre-install-import-graph` ×1: they still name the two deleted workflows and
141+
`scripts/objectstack-pin.mjs`). 4b PR 2 (objectstack#25712) deletes those workflows with
142+
the tests that read them. `markdown-test-inputs`, `check-changeset-fixed` and
143+
`check-unused-dependencies` pass. The `optimizeDeps` case fails identically on both
144+
sides, because there is no spec build, and only moved to `console-optimize-deps.test.ts`;
145+
- earlier, on `9e37acd126`: `vitest run scripts/__tests__`: 17 failed / 5,573 passed. Two of them are 15 s
129146
timeouts under load (`check-vi-mock-inherit`, `dollar-dialect-alias-census`), which
130147
pass alone (125/125). Two failed the same way on the earlier merged tree without the
131148
patch: `check-lockfile-integrity`, and `quick-reference-commands-4149` on the root

0 commit comments

Comments
 (0)