Skip to content

Commit 9a776c6

Browse files
committed
fix(release): keep the now-private @object-ui/runner out of the fixed group (objectstack#25711, WIP)
objectui#13506 made @object-ui/runner private and moved it into objectui's changeset ignore list before the freeze at 9e1fe03. Measured on the cutover head 1c0d02e with this branch merged and the ui-side patch applied, root check-changeset-fixed reported it as stale. The root fixed group drops it and the root ignore list takes it, mirroring objectui. The lockstep count moves 112 -> 111 in the two places that state it. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149BHSXfCdQywGaLdpRAtWe
1 parent 5e616fc commit 9a776c6

4 files changed

Lines changed: 12 additions & 7 deletions

File tree

‎.changeset/config.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@
117117
"@object-ui/providers",
118118
"@object-ui/react",
119119
"@object-ui/react-runtime",
120-
"@object-ui/runner",
121120
"@object-ui/sdui-parser",
122121
"@object-ui/types",
123122
"object-ui"
@@ -127,6 +126,6 @@
127126
"access": "public",
128127
"baseBranch": "main",
129128
"updateInternalDependencies": "patch",
130-
"ignore": ["@object-ui/example-*", "@object-ui/site", "@object-ui/test-support"],
129+
"ignore": ["@object-ui/example-*", "@object-ui/site", "@object-ui/runner", "@object-ui/test-support"],
131130
"privatePackages": { "version": true, "tag": false }
132131
}

‎content/docs/protocol/backward-compatibility.mdx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Read the **Breaking?** column, not the version number: in the 17.x minors every
116116
1. **RFC (Request for Comments)** — Breaking changes are proposed as GitHub issues with the `protocol:breaking` label.
117117
2. **Deprecation** — The old behavior is deprecated in a MINOR release (see timeline above).
118118
3. **Migration Guide** — A detailed migration guide is published before the removal lands, in the release notes for the version that carries it.
119-
4. **Release** — In the 17.x minors the breaking change shipped in the next **MINOR** version, carrying a changeset entry marked `**BREAKING**`, and `scripts/check-changeset-no-major.mjs` failed a pull request that declared a `major` bump, because under lockstep one `major` would promote all 112 published packages. During the v18 prerelease it shipped in the next `18.0.0-next.N`, because the guard stood aside in pre mode and a pull request could declare a major bump. Changesets has exited pre mode, so the guard fails a `major` bump again. See [how a breaking stage lands on the v18 line](/docs/releases/v18#how-a-breaking-stage-lands-on-this-line).
119+
4. **Release** — In the 17.x minors the breaking change shipped in the next **MINOR** version, carrying a changeset entry marked `**BREAKING**`, and `scripts/check-changeset-no-major.mjs` failed a pull request that declared a `major` bump, because under lockstep one `major` would promote all 111 published packages. During the v18 prerelease it shipped in the next `18.0.0-next.N`, because the guard stood aside in pre mode and a pull request could declare a major bump. Changesets has exited pre mode, so the guard fails a `major` bump again. See [how a breaking stage lands on the v18 line](/docs/releases/v18#how-a-breaking-stage-lands-on-this-line).
120120

121121
---
122122

@@ -196,7 +196,7 @@ The `@objectstack/spec` package provides additional stability guarantees:
196196

197197
### Which surfaces this covers
198198

199-
**All of them.** It was not scoped to an experimental corner or a pre-release channel: all **112** packages published from this repository belong to a single Changesets `fixed` group, so they share one version number and one policy. No published surface was exempt.
199+
**All of them.** It was not scoped to an experimental corner or a pre-release channel: all **111** packages published from this repository belong to a single Changesets `fixed` group, so they share one version number and one policy. No published surface was exempt.
200200

201201
The convention was enforced rather than informal — `scripts/check-changeset-no-major.mjs` failed a pull request that introduced a `major` bump, because under lockstep a single `major` on one package would promote the entire stack. During the v18 prerelease Changesets was in pre mode with the tag `next` and the guard stood aside, so a pull request on the v18 line could declare a major bump. Changesets has exited pre mode, and the guard fails a `major` bump again.
202202

‎scripts/publish-smoke-pack.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
* a future exclusion cannot re-open the hole silently.
3434
*
3535
* Source of truth: the workspace itself. The Changesets `fixed` group in
36-
* .changeset/config.json enumerates the same 112 names, but it is a DERIVED
36+
* .changeset/config.json enumerates the same 111 names, but it is a DERIVED
3737
* declaration validated against the workspace by scripts/check-changeset-fixed.mjs
3838
* (which reddens both when a public package is missing from the group and
3939
* when a group name no longer exists), and it also holds the private members

‎scripts/ui-import/README.md‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,14 @@ Measured on 2026-10-25:
117117
- on `9e37acd126` with steps 1–3 and the root half of 4a, after `pnpm install
118118
--frozen-lockfile` and `pnpm run build`: `type-check:scripts`,
119119
`type-check:vitest-config`, `lint:root` exit 0, and root and objectui
120-
`check-changeset-fixed` both pass (112 public packages plus `object-ui`).
121-
`changeset version` moves all 113 to 18.2.0 together, `object-ui` included;
120+
`check-changeset-fixed` both pass (112 public packages plus `object-ui` at that base).
121+
`changeset version` moved all 113 to 18.2.0 together, `object-ui` included;
122+
- on the cutover head `1c0d02eda4` (objectui frozen at `9e1fe03286`), with steps 1–3 and
123+
the root half of 4a: `@object-ui/runner` is private there and in objectui's `ignore`
124+
(objectui#13506), so the root `fixed` group drops it and the root `ignore` takes it.
125+
Root and objectui `check-changeset-fixed` exit 0 (111 public packages plus `object-ui`),
126+
`check:lockstep-package-count` reads 111, and `changeset version` moves all 112 members
127+
to 18.2.0 together while `@object-ui/runner` stays at 18.1.0;
122128
- `vitest run scripts/__tests__`: 17 failed / 5,573 passed. Two of them are 15 s
123129
timeouts under load (`check-vi-mock-inherit`, `dollar-dialect-alias-census`), which
124130
pass alone (125/125). Two failed the same way on the earlier merged tree without the

0 commit comments

Comments
 (0)