Skip to content

Commit 1adf504

Browse files
committed
ci(spec-shape-gate): register the retired visibility key's test-project diagnostic too
objectui's react type-check chains its test project after the source project, so the scheduled run's red at SchemaRenderer.tsx:1945 kept the test project from ever compiling. Compiled locally (objectui main f78efdd1e3 against the spec built from 570f01d), that project reds once more on the same retirement: SchemaRenderer.expressions.test.tsx:171 TS2322, a string authored into the page component's tombstoned visibility. Register it under the same entry so the gate does not red on it once the source project goes green ahead of the test. Claude-Session: https://claude.ai/code/session_01HjR8RUwTPQ3TgbfKihmxp9 Co-authored-by: Claude <noreply@anthropic.com>
1 parent d2aef71 commit 1adf504

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎scripts/ci/spec-shape-retirements.json‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"$comment": "Intentional spec retirements the Spec Shape Gate reads as `known` instead of red. One entry per retirement, written by the accepting seat when the downstream (objectui) card is filed, deleted when that card closes. Every entry carries exactly: retired, objectstack_pr, objectstack_commit (40-hex merge commit), downstream_card (owner/repo#N), registered_at (YYYY-MM-DD), matches (non-empty; each pattern names a repo-relative objectui `file` -- `*` within a segment, `**` across -- plus at least one of `code` (TS<digits>) or `message` (substring)). A file alone is refused. The reader, its grammar and its refusals: scripts/ci/spec-shape-gate.mjs (THE REGISTRY).",
33
"retirements": [
44
{
5-
"retired": "the page component's `visibility` and the view form's `visibleOn` (field and section) retired as keys -- retiredKey() tombstones naming `visibleWhen` (F4 of #23543, executed by PR #23836) -- the downstream still passes the page component's `visibility` to an expression argument, now typed as the tombstone",
5+
"retired": "the page component's `visibility` and the view form's `visibleOn` (field and section), retired as keys -- retiredKey() tombstones naming `visibleWhen` (F4 of #23543) -- objectui still passes the page component's `visibility` to an expression argument, and its expressions test (compiled only by the package's chained test project) still authors that key",
66
"objectstack_pr": 23836,
77
"objectstack_commit": "105902f10ae8124a5e965cb24f7b30681fd9fae2",
88
"downstream_card": "objectstack-ai/objectui#12654",
@@ -12,6 +12,11 @@
1212
"file": "packages/react/src/SchemaRenderer.tsx",
1313
"code": "TS2345",
1414
"message": "Argument of type '{ '[REMOVED] Key retired: run `os validate` for its migration.': never; }' is not assignable to parameter of type 'string | boolean | { dialect?: string | undefined; source?: string | undefined; } | undefined'."
15+
},
16+
{
17+
"file": "packages/react/src/__tests__/SchemaRenderer.expressions.test.tsx",
18+
"code": "TS2322",
19+
"message": "Type 'string' is not assignable to type '{ '[REMOVED] Key retired: run `os validate` for its migration.': never; }'."
1520
}
1621
]
1722
}

0 commit comments

Comments
 (0)