Skip to content

Commit d2aef71

Browse files
committed
ci(spec-shape-gate): register the retirement of the page component's visibility and the view form's visibleOn
The first scheduled Spec Shape Gate run on a main carrying the retirement red on objectui packages/react/src/SchemaRenderer.tsx:1945:45 TS2345: the page component's visibility, now a retiredKey() tombstone, is still passed to an expression argument. Register that diagnostic, by file, code and its full message, against the downstream card objectstack-ai/objectui#12654 so the hourly run reads it as known instead of red. Claude-Session: https://claude.ai/code/session_01HjR8RUwTPQ3TgbfKihmxp9 Co-authored-by: Claude <noreply@anthropic.com>
1 parent 570f01d commit d2aef71

1 file changed

Lines changed: 16 additions & 1 deletion

File tree

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,19 @@
11
{
22
"$comment": "Intentional spec retirements the Spec Shape Gate reads as `known` instead of red. One entry per retirement, written by the accepting seat when the downstream (objectui) card is filed, deleted when that card closes. Every entry carries exactly: retired, objectstack_pr, objectstack_commit (40-hex merge commit), downstream_card (owner/repo#N), registered_at (YYYY-MM-DD), matches (non-empty; each pattern names a repo-relative objectui `file` -- `*` within a segment, `**` across -- plus at least one of `code` (TS<digits>) or `message` (substring)). A file alone is refused. The reader, its grammar and its refusals: scripts/ci/spec-shape-gate.mjs (THE REGISTRY).",
3-
"retirements": []
3+
"retirements": [
4+
{
5+
"retired": "the page component's `visibility` and the view form's `visibleOn` (field and section) retired as keys -- retiredKey() tombstones naming `visibleWhen` (F4 of #23543, executed by PR #23836) -- the downstream still passes the page component's `visibility` to an expression argument, now typed as the tombstone",
6+
"objectstack_pr": 23836,
7+
"objectstack_commit": "105902f10ae8124a5e965cb24f7b30681fd9fae2",
8+
"downstream_card": "objectstack-ai/objectui#12654",
9+
"registered_at": "2026-10-16",
10+
"matches": [
11+
{
12+
"file": "packages/react/src/SchemaRenderer.tsx",
13+
"code": "TS2345",
14+
"message": "Argument of type '{ '[REMOVED] Key retired: run `os validate` for its migration.': never; }' is not assignable to parameter of type 'string | boolean | { dialect?: string | undefined; source?: string | undefined; } | undefined'."
15+
}
16+
]
17+
}
18+
]
419
}

0 commit comments

Comments
 (0)