Repository navigation
Commit 01a7ce4
committed
fix(spec): the repaired describe named a third face and an unreachable arm — both removed
Round 4 leads, each verified first-hand before a line moved. Both halves of
lead 1 reproduce; the repair shipped in round 1 was wrong in its own way.
1. `ListViewSchema` REFUSES a flat `limit`. Measured on this tree with four
lit controls: the minimal view document parses; + `pagination.pageSize: 50`
parses; + per-kind `kanban.limit: 50` parses; + flat `limit: 50` is
REFUSED with unrecognized_keys: ["limit"], the same verdict a bogus key
gets. Only three `limit` members exist on any view document and all three
are rowLimitKey(...) per-kind blocks; no retiredKey() tombstone for a flat
one. So `savedViewLimit`'s fallback to `view.limit` names a THIRD face --
a saved-view RECORD from the adapter's listViews() -- and stating it on the
author face with no qualifier is the same face-merge this card has failed
on three times. Dropped from the describe, recorded in the docblock.
2. The displaced-and-reported arm is unreachable from inside the accept set.
isUsableRowLimit is `typeof v === 'number' && Number.isInteger(v) && v > 0`
-- the same set this key declares as z.number().int().positive(). Measured
per value: 1/25/100/5000 accepted and usable; 0/-1/2.5/'100'/null refused
by both; unset accepted and not usable. So across the whole accept set
"set but not usable" is EMPTY and the guard is exactly "only when unset"
-- the wording round 1 retired as too narrow. Restored, with the reason.
The prose pin that guarded the retired sentence is replaced by the structural
fact underneath it: the schema's accept set and isUsableRowLimit coincide, so
the sentence is derivable rather than pinned, and either side widening reds it.
Lead 3: the property-access control is now published as its EXPRESSION plus
every hit -- 13 lines across 6 files -- with the filter that yields 8 stated
beside it (3 comments, 2 inside a quoted source-text pin; one hit set, three
readings). The spread predicate now also names what it EXCLUDES:
app-shell timelineViewOptions:206 and galleryViewOptions:342, options-bag
builders feeding ListView's nested forward.
Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx1 parent ff3d631 commit 01a7ce4
4 files changed
Lines changed: 88 additions & 32 deletions
File tree
- content/docs/references/ui
- packages/spec/src/ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
617 | 617 | | |
618 | 618 | | |
619 | 619 | | |
620 | | - | |
| 620 | + | |
621 | 621 | | |
622 | 622 | | |
623 | 623 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3857 | 3857 | | |
3858 | 3858 | | |
3859 | 3859 | | |
3860 | | - | |
3861 | | - | |
3862 | | - | |
3863 | | - | |
3864 | | - | |
3865 | | - | |
3866 | | - | |
3867 | | - | |
3868 | | - | |
3869 | | - | |
3870 | | - | |
3871 | | - | |
| 3860 | + | |
| 3861 | + | |
| 3862 | + | |
| 3863 | + | |
| 3864 | + | |
| 3865 | + | |
| 3866 | + | |
| 3867 | + | |
| 3868 | + | |
| 3869 | + | |
| 3870 | + | |
| 3871 | + | |
| 3872 | + | |
| 3873 | + | |
| 3874 | + | |
| 3875 | + | |
| 3876 | + | |
| 3877 | + | |
| 3878 | + | |
| 3879 | + | |
| 3880 | + | |
| 3881 | + | |
| 3882 | + | |
| 3883 | + | |
| 3884 | + | |
| 3885 | + | |
| 3886 | + | |
| 3887 | + | |
| 3888 | + | |
| 3889 | + | |
| 3890 | + | |
| 3891 | + | |
3872 | 3892 | | |
3873 | 3893 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3092 | 3092 | | |
3093 | 3093 | | |
3094 | 3094 | | |
3095 | | - | |
3096 | | - | |
3097 | | - | |
| 3095 | + | |
| 3096 | + | |
| 3097 | + | |
3098 | 3098 | | |
3099 | 3099 | | |
3100 | 3100 | | |
3101 | 3101 | | |
3102 | | - | |
3103 | | - | |
3104 | | - | |
3105 | | - | |
3106 | | - | |
3107 | | - | |
3108 | | - | |
3109 | | - | |
3110 | | - | |
3111 | | - | |
3112 | | - | |
| 3102 | + | |
| 3103 | + | |
| 3104 | + | |
| 3105 | + | |
| 3106 | + | |
| 3107 | + | |
| 3108 | + | |
| 3109 | + | |
| 3110 | + | |
| 3111 | + | |
| 3112 | + | |
| 3113 | + | |
| 3114 | + | |
| 3115 | + | |
| 3116 | + | |
| 3117 | + | |
| 3118 | + | |
| 3119 | + | |
| 3120 | + | |
| 3121 | + | |
| 3122 | + | |
| 3123 | + | |
| 3124 | + | |
| 3125 | + | |
| 3126 | + | |
| 3127 | + | |
3113 | 3128 | | |
3114 | 3129 | | |
3115 | 3130 | | |
| |||
3146 | 3161 | | |
3147 | 3162 | | |
3148 | 3163 | | |
3149 | | - | |
| 3164 | + | |
3150 | 3165 | | |
3151 | 3166 | | |
3152 | 3167 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1234 | 1234 | | |
1235 | 1235 | | |
1236 | 1236 | | |
1237 | | - | |
1238 | | - | |
1239 | | - | |
1240 | | - | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
1241 | 1255 | | |
1242 | 1256 | | |
1243 | 1257 | | |
| |||
1246 | 1260 | | |
1247 | 1261 | | |
1248 | 1262 | | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
1249 | 1270 | | |
1250 | 1271 | | |
1251 | 1272 | | |
| |||
0 commit comments