Repository navigation
Commit ff3d631
committed
fix(spec): name the FACE before every statement, and take the changeset to patch
At-tier FAIL, grounds 1-3. Grounds 1 and 2 were one error: the previous round
fixed a face-swap by swapping the other way. A view-face fact had sat on the
element-face key; the rewrite put an element-face key under a view-face fact.
Re-measured first-hand at pin 87af769:
- ELEMENT FACE, a node's own nested timeline.limit: read on NO route.
ObjectTimeline binds timelineConfig = schema.timeline (:262) and reads
exactly eight members off it -- startDateField, dateField, titleField,
endDateField, groupByField, colorField, metaFields (:520, behind an
`as any` cast, which is why a timelineConfig?.x sweep under-counts) and
scale. No spread of a node's own timeline block exists anywhere (0 hits;
lit control = the view-block spreads, which fire). The gate mapping is
limit: 'limit' (plugin-timeline/src/index.tsx:333) -- flat.
- VIEW FACE, a ListViewSchema document's timeline.limit: that is the
route-dependent one. ObjectView.tsx:1725 flattens it onto the node's flat
limit (and that node then carries no timeline block at all);
ListView.tsx:3084 keeps it nested and unread.
So every sentence now names its face first, in both docblocks, the published
describe, the test comment and the changeset -- the distinction is stated
rather than navigated, because three rounds have failed on it.
Also flagged, not fixed: a third route neither the card nor the first two
reviews described -- a hand-authored object-timeline node reaching
ObjectTimeline through SchemaRenderer with no adapter. Its nested
timeline.limit is unread there too, and that is the route an author face is
written for.
The second instrument is now recorded by its PREDICATE (a spread whose target
is the object literal an adapter returns as the node) rather than by its
count, so the reading can be re-taken without re-deriving the rule.
Changeset level to patch per the coordinator's correction: the gate's two
remedies are not interchangeable and this is the second one -- the level was
right and the declaration was wrong. The "Why minor" paragraph is dropped.
Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx1 parent 99fd9f9 commit ff3d631
5 files changed
Lines changed: 127 additions & 75 deletions
File tree
- .changeset
- content/docs/references/ui
- packages/spec/src/ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | 12 | | |
20 | 13 | | |
21 | 14 | | |
| |||
29 | 22 | | |
30 | 23 | | |
31 | 24 | | |
32 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
803 | 803 | | |
804 | 804 | | |
805 | 805 | | |
806 | | - | |
| 806 | + | |
807 | 807 | | |
808 | 808 | | |
809 | 809 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3833 | 3833 | | |
3834 | 3834 | | |
3835 | 3835 | | |
3836 | | - | |
3837 | | - | |
3838 | | - | |
3839 | | - | |
3840 | | - | |
3841 | | - | |
| 3836 | + | |
| 3837 | + | |
| 3838 | + | |
| 3839 | + | |
| 3840 | + | |
| 3841 | + | |
| 3842 | + | |
3842 | 3843 | | |
3843 | 3844 | | |
3844 | 3845 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3113 | 3113 | | |
3114 | 3114 | | |
3115 | 3115 | | |
3116 | | - | |
3117 | | - | |
| 3116 | + | |
| 3117 | + | |
| 3118 | + | |
| 3119 | + | |
| 3120 | + | |
| 3121 | + | |
3118 | 3122 | | |
3119 | 3123 | | |
3120 | 3124 | | |
| |||
3983 | 3987 | | |
3984 | 3988 | | |
3985 | 3989 | | |
3986 | | - | |
3987 | | - | |
3988 | | - | |
3989 | | - | |
| 3990 | + | |
| 3991 | + | |
| 3992 | + | |
| 3993 | + | |
3990 | 3994 | | |
3991 | 3995 | | |
3992 | 3996 | | |
| |||
4016 | 4020 | | |
4017 | 4021 | | |
4018 | 4022 | | |
4019 | | - | |
4020 | | - | |
4021 | | - | |
4022 | | - | |
4023 | | - | |
4024 | | - | |
4025 | | - | |
4026 | | - | |
4027 | | - | |
4028 | | - | |
4029 | | - | |
4030 | | - | |
| 4023 | + | |
| 4024 | + | |
| 4025 | + | |
| 4026 | + | |
| 4027 | + | |
| 4028 | + | |
| 4029 | + | |
| 4030 | + | |
| 4031 | + | |
| 4032 | + | |
| 4033 | + | |
| 4034 | + | |
| 4035 | + | |
| 4036 | + | |
| 4037 | + | |
| 4038 | + | |
| 4039 | + | |
| 4040 | + | |
| 4041 | + | |
| 4042 | + | |
| 4043 | + | |
| 4044 | + | |
| 4045 | + | |
| 4046 | + | |
| 4047 | + | |
| 4048 | + | |
| 4049 | + | |
| 4050 | + | |
| 4051 | + | |
| 4052 | + | |
| 4053 | + | |
| 4054 | + | |
| 4055 | + | |
| 4056 | + | |
| 4057 | + | |
4031 | 4058 | | |
4032 | 4059 | | |
4033 | 4060 | | |
| |||
4051 | 4078 | | |
4052 | 4079 | | |
4053 | 4080 | | |
4054 | | - | |
| 4081 | + | |
4055 | 4082 | | |
4056 | 4083 | | |
4057 | 4084 | | |
| |||
0 commit comments