Repository navigation
feat: give each of the twelve positions a one-sentence description (#2249) - #2280
Merged
objectstack-fleet[bot] merged 1 commit intoOct 25, 2026
Merged
Conversation
…2249) Every position in src/sales/sharing/positions.ts now carries a business `description`, served with the position metadata so Setup -> Positions can say what each one is for. English only: the platform translation bundle has no namespace for positions, and the locale packs translate no position label. test/position-descriptions.test.ts pins that every served position has a one-sentence description that the platform schema keeps. Fixes #2249 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014xanhPEmGTMTfVH4UokwJT
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Author
席位核对ACCEPT (partial) · Contract review of hotcrm#2249 against its claim (
The card goes back to Landing authority: the maintainer's standing word in the seat thread, 「后续你按照pm-dispatch 规则审核通过的issue都可以落地」 (2026-10-23T13:14Z). Landing: Generated by Claude Code |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs objectstack-ai/objectstack#2249 (partial: the card stays open; the list column and translation wait on the platform)
What changed
src/sales/sharing/positions.ts: each of the 12 positions carries a one-sentence businessdescription(what the position is for: who approves what, which pool it receives work from, which territory it edits). It names the business job, not the rule wiring. The header records why, and that the descriptions are English only.test/position-descriptions.test.ts: pins that every position the composed app serves has a non-empty, one-sentence description, thatPositionSchemakeeps it, and that no two are the same. Ablation: deleting theeu_sales_teamdescription turns it red (1 failed, 13 passed)..changeset/2249-position-descriptions.md(patch).Translation: the locale packs translate no position label, and
TranslationDatain@objectstack/spec18.1.0 has nopositionsnamespace (onlyobjects,picklists,apps,messages,globalActions,dashboards,datasets,pages,flows,metadataForms,settingsCommon,settings). So the descriptions follow the labels and stay English. The card's "translated in en, zh-CN, es-ES and ja-JP" cannot be met in this repo. It needs a platform namespace first (AGENTS.md section 2).Measurement (on the pinned
@objectstack/*18.1.0)objectstack dev, signed in as the dev admin and calledGET /api/v1/meta/position?include=grants. All 12 HotCRM positions come back with theirdescription, beside_holderCountand_grantedPermissionSets.dist/objectstack.jsoncarries 12 of 12.@objectstack/console18.1.0,dist/assets/src-*.js). Thepositionregistration declareslistColumnsName, Label, Holders and Permission sets, and nodescription. Thepermissionregistration next to it does listdescription. The platform half (objectstack#25333) added holders and sets only. So the card's done-when "Setup list shows the descriptions" waits on a console change (a Description column on the position list). That is out of scope for HotCRM, and this PR files nothing. The detail page was not measured.Verify
Each stage run on its own:
validate0,typecheck0,lint0,hygiene0,hygiene:tokens0,build0,test --maxWorkers=2: 220 files, 4332 passed, 1 skipped. After the full run I made comment-only edits. Then I re-ran validate, typecheck, lint, hygiene, build and the new test, and all were green.Out-of-scope findings
🤖 Generated with Claude Code
https://claude.ai/code/session_014xanhPEmGTMTfVH4UokwJT