[objectstack-fleet]

Part of #2060 (item 7)
Clause-②: no

Item 7 of the browser-pass list card (findings A-04, A-21, B-11, C-08, A-20, plus the web-to-case Priority folded in by 6183901714). #2060 remains open for its other items.

Three create forms refused a save the server would have completed: the field was required, so the console demanded a value that a hook or a declared default fills in on insert. This PR makes each declaration say who supplies the value. A default the field can state for itself is now declared on the field, and required stays. A value only a hook can compute keeps the hook as its producer and drops required, while storage.notNull keeps the column whole (ADR-0113's engine-populated column).

This is a takeover of the claim in 6268036396. The previous dev's commit a95e2e18 is kept after a hunk-by-hunk review. Their measurements are repeated on this head, which is origin/main b6cadbd5 (18.0.0-next.5, #2182, #2183) merged in. Two hunks fall outside the claim's bar and are declared below.

Item 7, sub-item by sub-item

All measurements are on 18.0.0-next.5. The console and REST readings come from a dev server booted from this branch's artifact, built at ffba6024 (eed2961f adds only the changeset), on a fresh database staffed by pnpm demo:staff.

• Lead Owner (A-04). Verdict: already repaired on main, no change here. A sales rep cannot save a new lead without picking themselves as owner: the Create Lead form marks owner_id required, which blocks the insert-time stamp that already makes the creator the owner #2097 landed it (PR fix(lead): stop requiring an owner pick on the New Lead form #2099, 4f389428, the lead.view.ts comment above 'owner_id'). Confirmed: the New Lead form shows Lead Owner with no required mark. A rep saved only name, company and email: POST /api/v1/data/crm_lead answered 201, and the stored owner_id equals created_by, which is the rep's own user id.
• Sales Price, crm_opportunity_line_item.unit_price (A-21). Verdict: fixed here. required is dropped and storage.notNull is kept. opportunity_line_item_price_fill stays the producer, because a cross-record default has no declared form.
  • Before (cc0608c, next.3): "Please check the highlighted fields: Sales Price", and no POST.
  • Now: the form shows Sales Price with no mark. Saving with only the product gives "Opportunity Line Item created successfully". The POST sent {quantity:1, discount:0, crm_opportunity, crm_product} and got 201. Read back: unit_price 22000 = list_price 22000.
  • A REST insert without a price is still 201 at list price.
  • Clearing the price on edit is still refused (PATCH … {unit_price:null} gets 400 VALIDATION_FAILED), but the text now reads "unit_price is required". That is finding P2 below.
• Expiration Date, crm_quote.expiration_date (B-11). Verdict: fixed here. The field gains defaultValue: cel\addDays(record.quote_date, 30)`, and required` stays.
  • Now: the form shows Expiration Date with no mark and "Set automatically when saved.", the same as Quote Date. A rep saved name and account: 201, read back quote_date 2026-10-20 and expiration_date 2026-11-19.
  • Clearing it on update still gets 400 "Expiration Date is required and cannot be cleared".
  • The import dry-run preview, which runs no hook, now answers 200 with ok 1. Before, it answered "Expiration Date is required".
• Period End and Snapshot Date, crm_forecast (C-08). Verdict: fixed here. period_end drops required, and the hook stays its producer, because period_start may itself be derived after defaults run. snapshot_date gains defaultValue: cel\today()`, and required` stays.
  • Now: the form shows no mark on either field, and Snapshot Date says "Set automatically when saved.". Saving with Period Start 2026-10-01 and a quota gives 201, read back period_end 2026-10-31, label Oct 2026, snapshot_date 2026-10-20.
  • Clearing snapshot_date still gets 400 "…cannot be cleared". Clearing period_end re-derives it: 200, 2026-12-31.
  • C-08's third bullet is not fixed here. That bullet is a mid-period start refused with a message about Period End. It is now reachable from the form, so it is reported as finding H2 below.
• Opportunity Stage default (A-20). Verdict: not a defect on this pin, no change. stage declares prospecting with default: true on the option. The engine applies that flag since objectstack#7246 (resolveOptionDefault), and the console's create form seeds it since objectui#11914.
  • Measured: the New Opportunity form opens with Stage = "Prospecting", and a REST insert without stage gets 201 with prospecting.
  • A-20 was measured on 17.7.0, before either change.
  • The finding's suggested defaultValue: 'prospecting' would declare the same default a second time, so it is not added.
• Web-to-case Priority (fold-in 6183901714). Verdict: platform, finding P1 below, no app change. The declaration is already correct: crm_case.priority is required with low marked default: true, and web_to_case puts no form-level required on it.
  • Measured: an anonymous POST /api/v1/forms/support/submit without a priority gets 201, and the stored row has priority: low.
  • /_console/f/support shows Priority* set to "Select an option", and Submit shows "Required: Priority" with no request sent.
  • The console's record form pre-selects option defaults, as Stage shows, but the form-view page does not. That gap is the platform's to fix, and the app does not work around it.

What changed

• opportunity_line_item.object.ts: unit_price drops required, with a comment.
• quote.object.ts: expiration_date gets its declared default. quote_date is declared above it, and the engine applies defaults in declaration order. A test pins that order. fix(quotes): an accepted quote no longer makes its contact, or the account above it, undeletable #2183's crm_contact requiredWhen came in untouched.
• forecast.object.ts: period_end drops required. snapshot_date gets its declared default.
• quote.hook.ts and forecast.hook.ts: the two stamps the declarations replaced are removed. This is declared deviation D1.
• opportunity_detail.page.ts: comment only. This is declared deviation D2.
• Docs, in en, zh-Hans and zh-Hant:
  • administration/automation: it said the quote's expiration default lived in a hook, and now says which date logic is declared on the field.
  • sales/quotes: gains the 30-day default (declared deviation D3).
  • sales/forecasting: says a blank snapshot date is today (declared deviation D3).
• Tests:
  • new test/form-required-server-defaults.test.ts covers the declarations, every create door including the hookless dry-run, explicit values kept, and update protection.
  • opportunity-line-item-add-picker.test.ts: the ablation now expects the NOT NULL column's refusal.
  • forecast-period-boundary.test.ts: comment only.
• One changeset.

Declared deviations from the claim

• D1, hook edits. The claim allowed a hook edit "only if the measurement shows the default cannot be reached otherwise". The measurement shows the default can be reached without the edit, so this hunk does not meet that bar as written. It is kept, and declared here:
  • The predecessor's variant with the hooks untouched behaved the same as the edited head on every probe (REST, import, PATCH and console, recorded in their scratch output).
  • On this head, a two-leg run inserted 7 shapes (date omitted, null and '' for each default, plus a forecast with no start). The results were byte-identical with the base stamps restored and with them removed. The engine applies field defaults before beforeInsert and treats null and '' as unsupplied, so the stamps can never fire.
  • Keeping them would leave a second definition of each value that disagrees with the declaration (new Date() in UTC against the platform's today()), under hook headers that would still call the hook the producer.
  • Reverting is mechanical if the seat prefers: restore the two branches, and the declared defaults still win.
• D2, opportunity_detail.page.ts. The claim allowed page edits "only where the required mark lives". The mark does not live in this page. The hunk changes two comment blocks and nothing else; the page's metadata bytes are unchanged. Those comments said unit_price is required and that the ablation refuses with "Sales Price is required", and both statements become false with this change.
• D3, docs beyond pages that already said it. sales/quotes (one bullet) and sales/forecasting (one clause) did not state these defaults before. They now do, in all three locales. administration/automation is the page in the claim's surface that did state one.

Verification on eed2961f

Every heavy step ran through os-verify-lock.sh, with the VERDICT command-exit read rather than a bare $?.

• pnpm validate, typecheck, lint, lint:i18n-gate, hygiene, hygiene:tokens and build: each exit 0.
• hygiene:tokens for src/revenue: business semantics ~17,997 (ceiling ~24,000), interaction ~2,165 (~4,500), authored total ~21,282 (~28,500).
• pnpm test as vitest run --shard=k/3 --maxWorkers=2:
  • shard 1/3: 67 files, 1112 tests passed;
  • shard 2/3: 66 files, 1244 passed and 1 skipped;
  • shard 3/3: 66 files, 1590 passed;
  • 199 files, which is every test/**/*.test.ts in the tree.
• main has since moved to b94cf856 (fix(seed): every seeded escalated case carries an authored escalated_date, so an edit no longer re-escalates CASE-00007 #2184, service seed and two tests). git merge-tree against this head is clean and no file overlaps, so it is not merged in.

Ablations, one per changed behaviour, on eed2961f. Each went through ablation-replace.mjs, which checked that the anchor hit once and the blob moved, then restored with blob == HEAD and an empty git diff HEAD.

	mutation	result
A1	delete expiration_date's defaultValue	6 failed / 12 passed: the declaration pin, three dated-quote cases, the dry-run door, the update case
A2	put required: true back on unit_price	3 failed / 23 passed: the declaration pin, the column-refusal case, the add-picker ablation
A3	delete snapshot_date's defaultValue	5 failed / 13 passed
A4	put required: true back on period_end	2 failed / 16 passed: the declaration pin, and the dry-run preview, which reports Period End missing again

Acceptance notes

• Snapshot date's calendar. "Today" for snapshot_date is now the platform's today(), the same function behind quote_date's existing default. Before, the hook used new Date() in UTC. Both read the same date on a UTC box (measured 2026-10-20). They can differ only when a write carries a non-UTC timezone.
• Import with automations off. On 18.0.0-next.5, a signed-in user's import with runAutomations: false is refused with 403, which is new in the pin and not caused by this PR. So the changeset names the dry-run preview as the import door that changed for a user. The source comments that mention a hookless import describe the engine's own path, which the system principal still uses.
• Feature inventory. docs/feature-inventory.md rows QUO-003 and FCT-002 still name the hooks as producers of the two defaults. The behaviour they describe is still true. That file belongs to item 16, the family the seat folds such rows into, and it is outside this claim's surface.

Findings for the seat

None of these was filed by this run; the seat files them.

• P1, platform (objectui). The form-view page ignores the option marked default: true.
  • class: a · reach: anonymous /_console/f/support: leaving Priority unpicked shows "Required: Priority" and sends nothing, while POST /api/v1/forms/support/submit without it gets 201 with low.
  • Seam: spec:SelectOption.default → runtime:ObjectQL.resolveOptionDefault (honoured) | renderer:apps/console/src/components/FormPage.tsx readPrefill. At objectui 61ed5ada, that function seeds only a literal field defaultValue, while plugin-form/src/schemaDefaults.ts (objectui#11914) reads both.
  • Dedupe words: readPrefill, FormPage, default: true, Required: Priority, public form.
• P2, platform (objectstack). A NOT NULL refusal names the field key, not its label.
  • class: a · reach: on this branch, PATCH /api/v1/data/crm_opportunity_line_item/ID {unit_price:null} gets 400 VALIDATION_FAILED "unit_price is required", and the console's inline error says the same. The field's label is "Sales Price".
  • Seam: spec:storage.notNull (ADR-0113 engine-populated column) → runtime:@objectstack/types data-error translator, not-null branch. It builds ${field} is required, and its hint tells the author to declare required, which is the declaration that blocks the create form. That hint is noted as a boundary, not a separate class.
  • Dedupe words: NOT NULL, is required, storage.notNull, engine-populated, label.
• H1, hotcrm, the same family as A-21. crm_quote_line_item.unit_price is required while the shared createLineItemPriceFill fills it on insert.
  • class: a · reach: console New Quote Line Item, with a quote and a product picked: "Please check the highlighted fields: Sales Price", and no POST. POST /api/v1/data/crm_quote_line_item without a price gets 201 with unit_price 75000 = list.
  • _line-item-price-fill.ts's own header warns against fixing one line object and skipping the other. It is not changed here because it is outside the claim's file surface, which this takeover cannot amend. The fix is A-21's change, word for word.
  • Proposed as a sub-item of Browser pass #2058 — HotCRM-side defects (18 items: accepted quote still takes lines, half-converted leads, agents losing their cases, unreachable Sales Home, …) — list card, split per item at dispatch #2060 item 7.
  • Dedupe words: crm_quote_line_item, unit_price, Sales Price, price fill.
• H2, hotcrm, the rest of C-08. A mid-period Period Start is refused with a message about Period End the user never typed.
  • class: a · reach: console New Forecast, Period Month, Period Start 2026-10-15, Period End blank. The toast reads "Period Start must be the first day of the period … ; Period End must be the last day of the period …", and the POST carried no period_end and got 400.
  • The hook derives an end from the bad start, then period_end_matches_calendar_period judges the derived end. Before this PR the form stopped on the required Period End first, so this PR makes the message reachable from the form.
  • Fixing it needs either the hook to stop deriving from an off-boundary start, or the end rule to stand down while the start rule fires. Both are outside the claim's surface.
  • Proposed as a sub-item of Browser pass #2058 — HotCRM-side defects (18 items: accepted quote still takes lines, half-converted leads, agents losing their cases, unreachable Sales Home, …) — list card, split per item at dispatch #2060 item 7.
  • Dedupe words: period_end_matches_calendar_period, Period End must be the last day, mid-quarter, crm_forecast.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
hotcrm	Ignored		Oct 20, 2026 1:36am UTC

[objectstack-fleet]

席位核对

ACCEPT (#2060 item 7) · PR #2185 at eed2961f7 · repo:hotcrm seat 2 · os-support-ai · session session_01KqkTQNLcxVc588eZpJmp1r · 2026-10-20T01:33Z · report 6280807788 on hotcrm#2060 (a takeover dev; the first dev died at the account's weekly usage limit after pushing a95e2e18)

1. Shape:
   • Draft, base main. It opens with Part of #2060 (item 7) and Clause-②: no, and the body carries no closing keyword. Browser pass #2058 — HotCRM-side defects (18 items: accepted quote still takes lines, half-converted leads, agents losing their cases, unreachable Sales Home, …) — list card, split per item at dispatch #2060 stays open for its other items.
   • 19 files, +347 / −68: three object files, two hooks, one page (comments only), nine doc pages, three tests and the changeset. check-governed-merges --pr: no governed path, 415 lines, under the human-merge threshold.
   • 0 model-identifier lines. main b6cadbd5 is an ancestor of the head.
2. The diff, read:
   • unit_price drops required and keeps storage: { notNull: true }. opportunity_line_item_price_fill stays its producer. That is ADR-0113's engine-populated column.
   • expiration_date gains defaultValue: cel\addDays(record.quote_date, 30)`and keepsrequired. quote_date` is declared above it, and a case pins that order.
   • period_end drops required, and the hook stays its producer. snapshot_date gains defaultValue: cel\today()`and keepsrequired`.
   • A-04 is already repaired by fix(lead): stop requiring an owner pick on the New Lead form #2099. A-20 is not a defect on this pin (objectstack#7246 and objectui#11914). Both verdicts carry a measurement and no hunk.
3. Declared deviations, the seat's calls:
   • D1 (hook stamps removed): kept. The dev measured 7 insert shapes byte-identical with the stamps restored and removed. The engine fills field defaults before beforeInsert, so the stamps could never fire. Leaving them would keep a second producer that disagrees with the declaration (new Date() in UTC against today()). One value, one producer.
   • D2 (opportunity_detail.page.ts, comments only): kept. Both comments it rewrites became false with this change, and the page's metadata is untouched.
   • D3 (two doc pages state the new defaults): kept. These are one bullet and one clause, in all three locales, and they state what the diff does.
4. Changeset and docs, read sentence by sentence:
   • The three form sentences match the three declarations.
   • "Clearing a line's Sales Price is still refused too, but the message now names the field unit_price": the dev measured it, and it is true. The seat filed the platform half as objectstack#24715.
   • The dry-run sentence names four fields. Expiration Date and Snapshot Date have their own cases. Period End is pinned by ablation A4. Sales Price has no case of its own; it follows from dropping required, because ObjectQL.validate reads no storage.notNull (objectstack origin/main 73d4cc739, packages/objectql/src: 0 non-test hits).
   • The three doc pages, in every locale, say what the declarations now do. No sentence claims more than the diff does.
5. Gates:
   • Every build-half step exits 0 on eed2961f. The three shards cover 199 files (1112, 1244 + 1 skipped, 1590 passed).
   • Ablations A1–A4, one per changed behaviour, each go red as predicted, and each restore is proven blob-equal.
   • CI on eed2961f7 at this review: all 10 checks success, including Quality Checks, Build and Test (22.x) and Playwright. mergeable_state is clean.
6. Findings, dispositions:
   • P1 (the public form-view page ignores an option's default: true) is already objectui#13049, closed as fixed after 18.0.0-next.5 shipped. It is not filed. The web-to-case Priority half of item 7 waits on a published release that carries it.
   • P2 (the NOT NULL refusal names the column key) is filed as objectstack#24715.
   • H1 (crm_quote_line_item.unit_price is required while the shared price fill fills it) and H2 (C-08's mid-period start gets a Period End message) are folded into Browser pass #2058 — HotCRM-side defects (18 items: accepted quote still takes lines, half-converted leads, agents losing their cases, unreachable Sales Home, …) — list card, split per item at dispatch #2060 as items 7b and 7c.
   • Acceptance note: the docs/feature-inventory.md rows QUO-003 and FCT-002 still name the hooks as producers. They join item 16.

Landing: main has moved to b94cf856 (#2184). This seat brings it in through the relay. Once every check on the new head is green, it flips the PR ready and arms auto-merge. After the merge, #2060 goes back to pm:queue for its remaining items.

---

Generated by Claude Code