fix(revenue)!: remove crm_quote_line_item.tax_rate — a quote line's total is its subtotal

[objectstack-fleet]

Fixes #2069

What and why

This executes ruling B on the card (comment 6142078386, the maintainer's 「hotcrm 三个决裁都同意」): the quote's typed Tax is the only tax model.

• crm_quote_line_item.tax_rate is removed. It is a published field, so this is a minor release by the 3.1.0 precedent (1486ec0c, which removed crm_product.tax_rate). The removal is named in this title and in the changeset.
• A line's total_price is now the same expression as its subtotal: * (1 + record.tax_rate / 100) is gone. The line totals add up to the quote's Subtotal.
• quote_total_rollup never read the rate and is unchanged. The header still reads subtotal − discount + tax + shipping.
• Editing a quote's own Tax, Discount % or Shipping does not update its total until some line item is touched (the docs promise the totals update automatically) #2083 is not addressed here. The header still does not recompute when the quote's own Tax, Discount % or Shipping changes; that card covers it.

Every reader of the field

git grep -n tax_rate over the whole tree at base 0f84c9c found the following. Views, pages, field groups, hooks, flows, datasets, reports, mappings, assets/import-templates/ and e2e/ have none.

Reader	Change
src/revenue/objects/quote_line_item.object.ts	The field and the multiplier are removed. Three comments are corrected: the group note, the related-list note and the formula note. "eleven fields" becomes "ten".
src/revenue/objects/opportunity_line_item.object.ts	The twin's comment "its eleven fields" becomes "ten".
src/revenue/data/revenue.seed.ts	The comment about leaving tax_rate at 0 is removed.
src/sales/translations/{en,es-ES,ja-JP,zh-CN}/objects.commerce.ts	The 4 locale rows are removed.
content/docs/sales/quotes ×3 locales	The line-items panel paragraph now says a line carries no tax.
content/docs/revenue/products ×3 locales	The tax paragraph drops the line's Tax Rate %.
content/docs/whats-new ×3 locales	See the deviations below.
test/line-item-conventions.test.ts, test/undeclared-key-probe.test.ts	Re-pointed, see below.

CHANGELOG.md keeps its history. After this PR, git grep -n tax_rate -- src returns 0 hits, and the built artifact carries 0 "tax_rate" (base: 5).

Acceptance 2: one pin, red before and green after

The new test in test/hooks-runtime.test.ts (quote_total_rollup) uses QTE-0007's shape: a quote at 10% discount, an untaxed line of 2 × 5,000, and a line of 1 × 1,000 at 10% line discount. The rep then sets a 5% rate on the second line. It asserts that the line totals equal the header subtotal (10,900), that the total is 9,810, and that the rate write is refused as ['INVALID_FIELD', 400].

Red on the unfixed tree (HEAD 0f84c9c7, only the test file modified), under the shared lock:

FAIL  test/hooks-runtime.test.ts > quote_total_rollup > adds up on QTE-0007's shape: ...
AssertionError: expected { lines: 10945, subtotal: 10900, …(1) } to deeply equal { lines: 10900, subtotal: 10900, …(1) }
-   "lines": 10900,
+   "lines": 10945,
    "subtotal": 10900,
    "total": 9810,
os-verify-lock: VERDICT command-exit 1

It is green after the fix, inside the full pnpm test run below.

Re-pointed tests

• line-item-conventions: "quote line total still applies tax on top" becomes "quote line total is its subtotal". Both formulas evaluate to 360 on 4 × 100 at 10%.
• undeclared-key-probe: control D needed a key that is declared somewhere and undeclared on crm_opportunity_line_item. It moves from the quote line's tax_rate to crm_quote.tax: it is the same key, with the same value 10, and the stored value is read back. The R81 report suggested crm_quote (the lookup) instead. I did not use it because a lookup's value must be a real quote id, which breaks the same-key-same-value control and makes it depend on reference semantics. All 3 drivers pass.

What an existing install that filled a line rate sees (measured)

1. I built base 0f84c9c7 and booted it on a scratch SQLite file.
2. Over REST, I wrote QTE-0007's shape with line B at tax_rate: 5. The base reproduces the card: line B total 945, lines 10,945, header subtotal 10,900, total 9,810, tax null.
3. I stopped it and booted this branch's build (9b4516d7) on the same file.

Reading after the upgrade	Value
Boot log	[schema-drift] crm_quote_line_item.tax_rate: column exists in the database but not in metadata (orphaned) — "os migrate apply --allow-destructive" to drop it.
Line B over REST	total_price 900, and the response has no tax_rate key. Line A is 10,000.
Header	Unchanged: subtotal 10,900, discount_amount 1,090, total_price 9,810.
PATCH line B {tax_rate: 5}	400 {"error":"Unknown field 'tax_rate' on object 'crm_quote_line_item'","code":"INVALID_FIELD"}
os migrate plan	Destructive: ✗ crm_quote_line_item.tax_rate [drop_column]. It is the only destructive change.
os migrate unmapped-columns --object crm_quote_line_item --json	columns: [{column: tax_rate, actual: float}], 22 rows; line B reads tax_rate: 5, every other row reads 0.
Console DOM probe on that quote	The Related tab shows line Totals 900 and 10000 (sum 10,900), equal to the header Subtotal 10,900.00. Total Price is 9,810.00.

The changeset carries this: the line's total changes (945 → 900), the quote total does not, and the stored rates stay readable until os migrate apply --allow-destructive drops the column.

Browser check on a fresh DB

I ran pnpm dev on port 4001 against a fresh database and signed in as admin@objectos.ai. Then I wrote QTE-0007's shape over REST:

• The rated line insert answered 400 INVALID_FIELD, so I wrote line B without the rate.
• DOM probe (Chromium /opt/pw-browsers/chromium): {"rows":2,"sumLineTotal":10900,"sumLineSubtotal":10900,"headerSubtotal":10900,"headerTotal":9810,"agree":true}.
• The line record page renders Sales Price and Total, and has no Tax Rate.

Gates

All gates ran on fe3f05ee, under the shared lock, with each exit captured before any pipe:

Command	Verdict	Exit
pnpm validate	✓ Validation passed, Data: 18 Objects 357 Fields	0
pnpm typecheck	tsc --noEmit	0
pnpm lint	18 suggestions, the same pre-existing set and none from this change	0
pnpm lint:i18n-gate	✓ i18n lint gate: 0 i18n/missing-* issues	0
pnpm hygiene	✓ source hygiene clean	0
pnpm hygiene:tokens	✓ source token ratchet clean	0
pnpm build	artifact built	0
pnpm test	Test Files 179 passed (179), Tests 3691 passed, 1 skipped (3692); VERDICT command-exit 0	0

hygiene:tokens, src/revenue:

• Authored total goes from ~18,986 to ~18,939: −47 against a ceiling of ~19,000, with headroom rising from 14 to 61.
• Business semantics goes from ~15,846 to ~15,799.

Deviations and judgment calls

• docs/STATUS.md was not in the claimed file surface. Its validator transcript goes from 358 to 357 Fields, because test/docs-declared-versions.test.ts pins it against the registered stack. The 3.1.0 precedent did the same, and the build transcript confirms 357.
• whats-new. No feature PR writes a release section; the release PR writes the next release's whats-new section from the changesets, as 3.1.0's was written from 1486ec0c's. The ruling's "whats-new" item is the 3.1.0 entry that says tax "is actually computed" on "the quote line item's own rate". That entry keeps its dated text and gains a forward note in all three locales: a later release retires the line rate too.
• The probe's control key is crm_quote.tax, not the crm_quote lookup R81 suggested. The reason is given above.

Acceptance notes (not changed here)

• The line-items panel now shows Subtotal and Total as equal columns. R81 named this as a cosmetic follow-up inside option B, and the ruling took B with it stated, so relatedListColumns is unchanged.
• The panel's formula columns render unformatted (10000 beside 5,000.00 for Sales Price). This predates the change and is visible in both base and head.
• docs/feature-inventory.md QUO-007 still says 行级税率公式 (line-level tax-rate formula). This PR makes that false, but branding: replace the app icon with the flat "H" mark and align primaryColor to its orange (#EA580C) — one asset that every surface renders (maintainer ruling 2026-10-12) #2066's claim holds that file, so it is untouched here. It is reported to the seat.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
hotcrm	Ignored		Oct 13, 2026 10:36am UTC