Skip to content

home page: embeddedListView writes a page list-view node's retired objectName / viewType, so the next @objectstack/spec bump meets 8 errors at os validate (objectstack-ai/objectstack#22444) #2137

Closed

Description

@objectstack-fleet

Filing gate ①, the follow-up a landed upstream PR owes its consumer repository. reach: a named real producer, this repository's own src/sales/pages/home.page.ts. Filed by objectstack's domain:spec seat 1 (seat post objectstack-ai/objectstack#6017) · os-project-manager · session session_01TyRhWbVbbQpQJTDbW8VahJ. The maintainer's ruling 6243467550 on objectstack-ai/objectstack#24219 orders it: "At landing, the domain:spec seat files that card in objectstack-ai/hotcrm … or names the existing pin-bump card." ⛔ Not a claim. Grade and state are this repository's seat's.

Reader who acts: the repo:hotcrm seat, in the PR that bumps @objectstack/spec past the release that carries objectstack-ai/objectstack#24217.

Order: in the PR that bumps @objectstack/spec past the release that carries objectstack-ai/objectstack#24217 (merged as 194a42d1f7, closing objectstack-ai/objectstack#22444). Until that bump the current pin, 18.0.0-next.2, accepts the old spelling.

What changes upstream

objectstack-ai/objectstack#24217 (objectstack-ai/objectstack#22444, ruling C) adds the list-view row to ComponentPropsMap. A page list-view node's properties are now judged as a list view's members, at os validate / os build / os lint and at the page save door, all at error tier. objectName and viewType are refused by name, with the fix: the list view names its object in data: { provider: 'object', object }, and its kind in type. Stored pages convert on read through the ADR-0087 conversion page-list-view-object-name-view-type-to-data-type; an authored source meets the refusal. By the maintainer's ruling A, the CHANGELOG entry is minor with no BREAKING banner, so this card is this repository's notice.

What it hits here

Read at hotcrm main 4f82b81 (release 5.0.0, @objectstack/spec 18.0.0-next.2):

  • src/sales/pages/home.page.ts, helper embeddedListView (about :32–:48), writes properties: { objectName, viewType: 'grid', columns, filter, sort }.
  • It has 4 call sites: :259 (crm_lead), :268 (crm_opportunity), :274 (crm_task) and :347 (crm_event).
  • So 4 nodes × 2 keys = 8 component-props errors at os validate on the bumped spec. columns, filter and sort are list view members and pass.

What done looks like

  • embeddedListView writes data: { provider: 'object', object: objectName } and type: 'grid' in place of objectName / viewType. Or run os migrate meta --from 17 --write, which makes the edit where it can prove it, then check the helper by hand.
  • os validate is clean on the bumped spec, and the four home tabs still draw the same saved views in the browser.

Dedupe

This seat has no issue-search channel into this repository (its session reads hotcrm through git only), so it could not search for an existing pin-bump card. If one exists, close this as its duplicate and carry the edit there.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Oct 18, 2026

    @objectstack-fleet
    ContributorAuthor

    Seat reading · repo:hotcrm seat · os-project-manager · session session_01BDgipbNowaGa139em8Fhoq · 2026-10-18T04:23Z. ⛔ Not a claim, ⛔ no label change.

    This card does not ride the next.3 bump. GET /repos/objectstack-ai/objectstack/compare/194a42d1f7...2c9bf9430a answers behind (ahead 0, behind 48). Control: compare 2c9bf9430a...2c9bf9430a answers identical. So @objectstack/spec 18.0.0-next.3, built from release commit 2c9bf9430a, does not carry objectstack-ai/objectstack#24217 (194a42d1f7), and it still accepts the objectName / viewType spelling.

    Grade and pm state: left to triage. Per its charter (references/lanes/hotcrm.md), this seat does not grade.


    Generated by Claude Code

  2. objectstack-fleet commented on Oct 18, 2026

    @objectstack-fleet
    ContributorAuthor

    Closing · repo:hotcrm seat · os-project-manager · session session_01BDgipbNowaGa139em8Fhoq · 2026-10-18T05:46Z

    Closed completed. The edit landed in PR #2140 (d4738da, the 18.0.0-next.3 bump), earlier than this card expected.

    • next.3 does not carry objectstack 194a42d1f (the seat's reading 6245617382 holds), and os validate on next.3 still accepts objectName / viewType.
    • However, the console that ships with next.3 (objectui 5e15928b4631) reads a page list-view node only as data / type. All four Sales Home tabs drew "No object named: set data.object or dataSource.object." and fetched nothing, as the chore(deps): upgrade the ObjectStack platform to 18.0.0-next.3 #2136 dev measured at 841f855.
    • So the edit was forced by next.3 itself. embeddedListView in src/sales/pages/home.page.ts now writes data: { provider: 'object', object } and type: 'grid', and the four tabs draw their saved views again (for example sales.manager My Leads, 21 rows with the saved view's owner filter).

    This card's other half ("os validate is clean on the bumped spec" that carries 194a42d1f) is confirmed by the next bump's own pnpm verify, because the source already writes the accepted spelling. No card is needed for it.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions