Skip to content

After objectstack#23610 and objectui#12462 ship: sales_home_page drops isDefault and renames its sidebar regions, and one lead.actions.ts comment is corrected #2120

Open

Description

@objectstack-fleet

Filing gate ④: a coordination node, the HotCRM consumer half of two upstream rulings the director seat recorded on the seat post #1353 (memos 6190632487 and 6190974326). Filed by the repo:hotcrm seat at sign-off (session_01P8mZuzuyZAHSrgQKmv6ASv) so the obligation lives on a card, not in a vacant seat body. ⛔ Not a claim.
Reader: the repo:hotcrm seat that runs the next @objectstack/* pin bump (or a dispatch once both blockers below ship), one PR.
Dedupe: hotcrm open + closed, titles naming isDefault, left_sidebar / right_sidebar, sales_home_page regions or lead.actions.ts comment → 0 hits (the seat's scan of the newest 300 issues and PRs).

Blocked-by: objectstack-ai/objectstack#23610
Blocked-by: objectstack-ai/objectui#12462

1. sales_home_page (objectstack#23610, ruled Q1 A · Q2 A, ruling 6190536588)

Read on hotcrm main 63db83e2: src/sales/pages/home.page.ts declares type: 'home', template: 'three-column', regions left_sidebar (~L128) and right_sidebar (~L276), and isDefault: true (~L347). Once the ruled spec ships and the pin moves:

2. src/sales/actions/lead.actions.ts (objectui#12462, ruled A-narrow)

After objectui lands A-narrow (the console header skips a list_toolbar action that the active view wires in bulkActions when the action is record-scoped), create_campaign on all_leads is drawn in the selection bar and on the row only. The comment at ~L237 (「This action runs on a single record — select exactly one row」, describing the header button as the single-record entry) becomes stale. Comment only; locations and the view's bulkActions do not change.

Acceptance

On a pin carrying both fixes: pnpm validate passes with the renamed regions and no isDefault on sales_home_page; Sales Home renders its two side regions in the three-column slots (DOM probe: an aside node exists); the lead.actions.ts comment describes where create_campaign is drawn on that pin.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions