zh-CN: the Leads list shows all 9 column headers in English (and the Opportunities list its Account column), because lead.view.ts / opportunity.view.ts hard-code column label:s that no translation key can reach #2094

Activity

1. objectstack-fleet

   added

   bugSomething isn't workingSomething isn't working

   pm:queueReady for the PM dispatch loopReady for the PM dispatch loop

   i18n

   priority:p2Medium: important, M3Medium: important, M3

   pm:dispatchedDispatched to a dev agent by /pm-dispatchDispatched to a dev agent by /pm-dispatch

   and removed

   pm:queueReady for the PM dispatch loopReady for the PM dispatch loop

   on Oct 13, 2026
2. objectstack-fleet

   assigned

   sunhaolin

   on Oct 14, 2026
3. objectstack-fleet commented on Oct 14, 2026

   

   objectstack-fleetbot

   on Oct 14, 2026

   ContributorAuthor

   More actions

   Claim: PM loop round R85
   Session: session_01P8mZuzuyZAHSrgQKmv6ASv
   Account: sunhaolin (the seat's linked user as GET /user answers it; always the card's assignee)
   Branch: claude/issue-2094-zh-cn-list-column-labels
   Worktree: hotcrm-issue-2094
   Domain: repo:hotcrm (single-lane repo, no domain:* taxonomy)
   Seat: repo:hotcrm#1
   File surface: src/sales/views/lead.view.ts (the All Leads columns block only, ~L141–200); src/sales/views/opportunity.view.ts (the two crm_account Account columns, ~L34 and ~L138); a field label in src/sales/objects/lead.object.ts / opportunity.object.ts and its four locale-pack entries only if a column's wording moves to its field; tests under test/ that pin these column labels; one .changeset/2094-*.md. A per-column label that is genuinely needed is a platform gap (no per-column translation key): file upstream and this card WAITS (AGENTS.md §2) (stop on breach; explain in the report)
   Container & model: M (the judgment is per column: does the label only repeat the field's, or carry wording the field label lacks), mode:subagent, model: default (dispatch-gates --tier --repo objectstack-ai/hotcrm src/sales/views/lead.view.ts: "no path-derived mandate: the surface hits none of the 3 declared glob(s)"; the tier stays the PM's per-card call)
   Clause-②: no
   Responsibility: the app: lead.view.ts and opportunity.view.ts give columns their own English label:, which shadows the field label the locale packs translate | the platform path that already covers it: a column with no label: serves the field's translated label, as the other 11 lists do | every zh-CN user who opens Leads or Opportunities, today
   Thread-read: none
   Serial constraints cleared: src/sales/views/lead.view.ts is shared with #2097, claimed in this round. Fold-or-serial: not folded (gate ① fails: a column label shadowing translation and a create-form required are different defect shapes). Parallel by region: this card owns the list columns block (~L141–200), #2097 owns the create form's owner_id entry (~L293–296); the later lander merges main (parallel discipline ②③). #2095 (claimed this round) edits formula declarations in src/*/objects/*.object.ts; if this card moves a wording to lead.object.ts, the region is a field label, not a formula. Last change on both view files: 81f8644 (#2050), not today. Open PRs in this lane: dependabot #2063 and #2064 only (package.json / lockfile). src/sales token headroom: ~57,901 authored (clean git archive of 2f3d898d); this card removes tokens.

   ---

   Generated by Claude Code
4. objectstack-fleet commented on Oct 14, 2026

   

   objectstack-fleetbot

   on Oct 14, 2026

   ContributorAuthor

   More actions

   os-dev-report

   {
     "issue": 2094,
     "status": "done",
     "branch": "claude/issue-2094-zh-cn-list-column-labels",
     "pr": "https://github.com/objectstack-ai/hotcrm/pull/2098",
     "session": "session_01P8mZuzuyZAHSrgQKmv6ASv (subagent = the seat session)",
     "premise_still_valid": true,
     "summary": "This PR removes all 11 column-level `label:` overrides in the app: the 9 on All Leads in lead.view.ts, and the crm_account `Account` column on both Opportunities grids in opportunity.view.ts. An enumeration over the four views barrels finds 11 before and 0 after. Each header is now the field label, which all four locale packs translate. Measured as sales.manager with a DOM probe: every zh-CN header on All Leads, Open Deals and All Opportunities is Chinese, and es-ES and ja-JP are fully translated too. Five en headers are unchanged (Company, Email, Status, Need Type, Account). The other five now equal their field labels: Name → Full Name, Score → Lead Score, Source → Lead Source, Est. Amount → Estimated Amount, Owner → Lead Owner. No column needed a wording its field label cannot carry: the grid widens Estimated Amount from 130 to 144 px, and no header text is clipped in en-US, es-ES or zh-CN. So no field label moved, and no platform gap blocks this card. H1, H2 and H3 all held as stated.",
     "tests": "All gates ran on head a16ea2ae, with OS_VERIFY_LOCK_SLOT=hotcrm-2094, and each exit code was captured before any pipe. pnpm validate exit 0: '✓ Validation passed (5400ms)', 'os-verify-lock: VERDICT command-exit 0'. pnpm typecheck exit 0. pnpm lint exit 0: '18 suggestion(s)', 'VERDICT command-exit 0'. pnpm lint:i18n-gate exit 0: '✓ i18n lint gate: 0 `i18n/missing-*` issues (18 total lint issue(s) reported, unaffected by this gate)'. pnpm hygiene exit 0: '✓ source hygiene clean'. pnpm hygiene:tokens exit 0: '✓ source token ratchet clean'. pnpm build exit 0: '✓ Build complete (3063ms)', 'VERDICT command-exit 0'. pnpm test exit 0: 'Test Files 179 passed (179)', 'Tests 3659 passed | 1 skipped (3660)', 'VERDICT command-exit 0 · held the lock 522s'. Console probe: Playwright with /opt/pw-browsers/chromium against my own dev server on port 4101 (fresh DB, then pnpm demo:staff), signed in as sales.manager@objectos.ai, reading each header's textContent. BEFORE (2f3d898d), zh-CN All Leads read 'Name · Company · Email · Status · Score · Source · Need Type · Est. Amount · Owner', and Open Deals and All Opportunities read '商机名称 · Account · 阶段 …'. AFTER (bd4f2204), zh-CN All Leads reads '全名 · 公司 · 邮箱 · 状态 · 线索评分 · 线索来源 · 需求类型 · 预计金额 · 线索负责人', and both Opportunities grids read '商机名称 · 所属客户 · 阶段 …'. en-US All Leads reads 'Full Name · Company · Email · Status · Lead Score · Lead Source · Need Type · Estimated Amount · Lead Owner'. es-ES and ja-JP are fully translated, with Account as Cuenta and 取引先. Truncation probe: on every header's deepest text element, scrollWidth == clientWidth (text-overflow ellipsis, overflow hidden) in en-US, es-ES and zh-CN. Inline-map experiment (one-off, never committed): I set the estimated_amount column label to { en: 'MAPEN Est', 'zh-CN': 'MAPZH 预计' }. The python write asserted an anchor count of 1, and grep -c MAPZH on disk returned 1. The build exited 0, and grep -c MAPZH dist/objectstack.json returned 1. The header still read 预计金额 in zh-CN and Estimated Amount in en. A trap restore ran `git checkout HEAD -- src/sales/views/lead.view.ts`. The proof: git hash-object equals HEAD's blob 2493440a36c5, `git diff HEAD` is empty, and grep -c MAPZH returns 0. I rebuilt before running the gates above.",
     "gates": {
       "head": "a16ea2ae",
       "validate": "✓ Validation passed · VERDICT command-exit 0",
       "typecheck": "exit 0",
       "lint": "18 suggestion(s) · VERDICT command-exit 0",
       "lint:i18n-gate": "✓ i18n lint gate: 0 i18n/missing-* issues",
       "hygiene": "✓ source hygiene clean",
       "hygiene:tokens": "✓ source token ratchet clean",
       "build": "✓ Build complete · VERDICT command-exit 0",
       "test": "Test Files 179 passed (179) · Tests 3659 passed | 1 skipped (3660) · VERDICT command-exit 0",
       "e2e": "not run locally (declared to CI)",
       "ci": "in_progress at report time (not awaited)"
     },
     "line_budget": {
       "additions": 17,
       "deletions": 15,
       "hygiene_tokens_before": "2f3d898d: src/sales interaction layer ~28,377; authored total ~102,599; business semantics ~57,878",
       "hygiene_tokens_after": "a16ea2ae: src/sales interaction layer ~28,311 (-66); authored total ~102,532 (-67); business semantics ~57,878 (unchanged). Other packages unchanged."
     },
     "files_changed": [
       ".changeset/2094-zh-cn-list-column-labels.md (+5)",
       "src/sales/views/lead.view.ts (+7 -10; All Leads columns block only: 9 label lines removed, column comment rewritten)",
       "src/sales/views/opportunity.view.ts (+2 -2; the two crm_account Account columns)",
       "content/docs/sales/leads.mdx (+1 -1; *Score* column → *Lead Score* column)",
       "content/docs/sales/leads.zh-Hans.mdx (+1 -1; *评分*那一列 → *线索评分*那一列)",
       "content/docs/sales/leads.zh-Hant.mdx (+1 -1; *評分*那一欄 → *線索評分*那一欄)"
     ],
     "deviations": [
       "File surface widened past the claim's File surface line to content/docs/sales/leads.mdx and its zh-Hans and zh-Hant pages. The en sentence 'the same field the list views show in the *Score* column' became false when the override went: no list shows a Score column any more. The two Chinese pages say the same thing and were updated to match. zh-Hans now uses the zh-CN pack wording 线索评分, which is what the console shows. zh-Hant uses the same wording in Traditional characters, 線索評分, which that page already writes for the field in the same sentence. No other doc sentence was made false.",
       "The two commits (bd4f2204, a16ea2ae) carry a model-named trailer, 'Co-Authored-By: Claude Opus 5.5'. I copied it from the harness attribution reminder. The agent definition's rule is model-free trailers, and that rule should have won. History is not rewritten, per the same rule, and the squash merge folds the message.",
       "A one-off inline-locale-map experiment temporarily changed src/sales/views/lead.view.ts in the worktree. It was never committed. Proof of the restore is in tests.",
       "I read the card, its comments, the PR (for readback) and #2072's os-dev-report (for the report format) as single-card REST GETs (gh api). These were reads only.",
       "I stopped each dev server this run started by killing its own process group (pgid 4565, 6298 and 8773). I did not use pkill or kill by name. The worktree, its node_modules and its local DB are removed.",
       "Merged origin/main before opening the PR: nothing to merge. main was still 2f3d898d at the PR and at this report, and #2097 had not landed. If #2097 lands first, its region (the create form's owner_id, ~L293) does not overlap this diff (the columns block, L134-198)."
     ],
     "mcp_calls": "0",
     "api_writes": "3 REST writes, sent as 2 fleet-write relay strokes (POST /repos/objectstack-ai/objectstack/dispatches): POST /repos/objectstack-ai/hotcrm/pulls (draft #2098), POST /repos/objectstack-ai/hotcrm/issues/2098/assignees (sunhaolin), and POST /repos/objectstack-ai/hotcrm/issues/2094/comments (this os-dev-report). Also 3 git pushes (the empty-branch probe and 2 commits), which are not REST writes. Zero label writes.",
     "open_questions": [],
     "out_of_scope_findings": [
       "class: b (also c) · reach: public door, the console list header. I authored a list column label as an inline locale map { en: 'MAPEN Est', 'zh-CN': 'MAPZH 预计' }; it built clean and reached dist/objectstack.json (grep 1). The All Leads header ignored it and showed the field label instead (预计金额 in zh-CN, Estimated Amount in en). · Seam: spec:I18nLabelSchema form 2 (inline locale map) as ListColumnSchema.label → renderer:objectui plugin-grid ObjectGrid.tsx resolveColumnLabel (L514 on objectui main b9814b3), which returns undefined for any non-string label. · The contract being broken: the installed spec 18.0.0-next.0 dist/ui/index.d.ts documents form 2 as 'picked at render time … so the map is a delivered capability'. On a grid column header it is silently discarded. The plain-string form has no translation slot either (_views.VIEW takes only label/description/emptyState/bulkActions, on 18.0.0-next.0 and on objectstack main b5b1bf72). So an author has no working way to translate a column wording that differs from its field label. This card did not need one, so it is not blocked. · dedupe words: inline locale map column label, resolveColumnLabel I18nLabel, ObjectGrid header pickLocalized, ListColumn label translation",
       "carrier: 承接者:无 · noted, not filed: the en pack's crm_lead.fields.status.label is 'Status' while lead.object.ts says 'Lead Status'. The console serves 'Status'. This was already true before the PR, and is in the PR's Acceptance notes.",
       "carrier: 承接者:无 · noted, not filed: content/docs/sales/pipeline-management.mdx L49 says All Opportunities 'carries an *Owner* column'. That column never had an override, and its en header reads 'Opportunity Owner'. This was already true before the PR, and is in the PR's Acceptance notes.",
       "carrier: 承接者:无 · noted, not filed: os lint's i18n coverage is silent on a plain-string column label: that no translation key can reach. lint:i18n-gate read 0 on main with all 11 overrides present. A rule for it would be a new gate (default no), so it is in the PR's Acceptance notes only."
     ]
   }

   ---

   Generated by Claude Code
5. objectstack-fleet commented on Oct 14, 2026

   

   objectstack-fleetbot

   on Oct 14, 2026

   ContributorAuthor

   More actions

   Review of PR #2098 (head a16ea2ae) against the os-dev report on this card (R85, seat repo:hotcrm, session_01P8mZuzuyZAHSrgQKmv6ASv): ACCEPT.

   • Form: draft, base main; body opens Fixes #2094 and Clause-②: no; no other closing keyword in the body. Not a governed path (no AGENTS.md, CLAUDE.md or .claude/**); 32 changed lines.
   • Scope, read file by file on the PR: src/sales/views/lead.view.ts (9 column label: lines removed, the columns comment rewritten), opportunity.view.ts (the two crm_account Account overrides), .changeset/2094-zh-cn-list-column-labels.md (hotcrm: patch), and one sentence each in content/docs/sales/leads.mdx / .zh-Hans.mdx / .zh-Hant.mdx. The doc edit is outside the claim's file surface and owed: the sentence "the list views show in the Score column" turned false when the header became Lead Score. Checked sentence by sentence: en Score → Lead Score; zh-Hans 评分 → 线索评分 (the zh-CN pack's wording, which the console now shows); zh-Hant 評分 → 線索評分 (the same wording the sentence already uses for the field). No content/docs/releases/ change.
   • Readings: the local gate union is on a16ea2ae = the PR head: validate, typecheck, lint, lint:i18n-gate, hygiene, hygiene:tokens (src/sales authored ~102,532, −67), build, test (179 files, 3,659 passed). The console probe is before/after header text in zh-CN, en-US, es-ES and ja-JP, with a truncation probe. CI on the head is all green except Build and Test (22.x), still in_progress at this review; landing waits for it.
   • Deviations, reviewed: (1) both commits carry a model-named Co-Authored-By: trailer copied from the harness reminder, against the os-dev rule that trailers are model-free. History is not rewritten, per the same rule. This repo squashes with COMMIT_MESSAGES, so the trailer reaches main (where 41 earlier commits already carry the same string). (2) A one-off inline locale-map experiment was restored, with the blob hash and an empty git diff HEAD as proof.
   • Out of scope:
     • filed plugin-grid: a list column's inline locale-map label (spec I18nLabel) is silently dropped — resolveColumnLabel keeps only a plain string, so the header falls back to the field label objectui#12358: a column's inline locale-map label is declared by the spec and dropped by ObjectGrid's resolveColumnLabel (ObjectGrid.tsx:514 on objectui 065a1cf, verified). It does not block this card.
     • The status-label / Owner-column doc notes stay in the PR's Acceptance notes, with no carrier.

   ---

   Generated by Claude Code
6. objectstack-fleet

   closed this as completedin #2098on Oct 14, 2026
7. objectstack-fleet

   removed

   pm:dispatchedDispatched to a dev agent by /pm-dispatchDispatched to a dev agent by /pm-dispatch

   on Oct 14, 2026