Editing a quote's own Tax, Discount % or Shipping does not update its total until some line item is touched (the docs promise the totals update automatically)

Filing gate ①: a product defect with reach measured (class a; also b: it contradicts shipped docs). Filed by the repo:hotcrm seat (session_01WnMDsLSaUQUD41WaWnADcF) from the os-dev report on #2069. ⛔ Not a claim.

What happens (REST door, `objectstack dev` at hotcrm `b8f5421`, 17.7.0)

PATCH /api/v1/data/crm_quote/QTE-0005 {tax: 7000} → 200, then GET total_price 86400 (expected 87000).
PATCH {discount: 10} → 200, then GET discount_amount 0, total_price 86400 (expected 8000 / 79000).
Only an unrelated line PATCH brings the header to 8000 / 79000.

The in-process engine agrees: a rep's quote update of tax 0 → 80 leaves total_price 1000.

Why

quote_total_rollup fires on crm_quote_line_item writes only (src/revenue/objects/quote_line_item.hook.ts ~53–54). No crm_quote hook recomputes discount_amount or total_price: quote_workflow in quote.hook.ts covers expiration, the freeze and the approval gate only.

Shipped promise: content/docs/sales/quotes.mdx:49, "Anything you change in the line items, discount, tax or shipping fields, the totals update automatically".

Inferred, not measured: quote_accepted_contract_draft reads total_price (quote.hook.ts ~380), so a quote accepted right after a discount or tax edit drafts its contract at the stale total.

Acceptance

A user's change to a quote's tax, discount or shipping_handling recomputes discount_amount and total_price on the same write (an unsettled quote only; the freeze stands).
A test pins each of the three edits, plus a settled-quote control.

For the dispatch

Serial: src/revenue/**, after A quote's total ignores line-item tax: lines total 10,945 while the quote shows 9,810 (the rollup sums pre-tax subtotals and never fills crm_quote.tax) #2069's ruling lands. The dev's pricing: this step alone is +97 tokens (authored total 18,986 → 19,083, over the ~19,000 ceiling by ~83); with A quote's total ignores line-item tax: lines total 10,945 while the quote shows 9,810 (the rollup sums pre-tax subtotals and never fills crm_quote.tax) #2069 option B landed first (−47) it is +50 net (over by ~36). Either way it needs an equal shrink elsewhere in src/revenue, or a ceiling ruling.
Surface: an additive beforeUpdate step on quote_workflow in quote.hook.ts. ⛔ It does not touch the freeze (PR fix(revenue): an accepted or expired quote's line items are frozen with it (#2060 item 1) #2076).

Duplicate check

All 1,911 hotcrm issues and PRs to #2074 (/issues?state=all, page walk) matched case-insensitively: quote total stale 0, discount_amount not recomputed 0, quote tax edit 0, quote header recompute 0, quote discount edit 0, totals update automatically 0. Controls: discount_amount 19 hits, quote_total_rollup 17 hits, none on point.

Generated by Claude Code

Claim: PM loop round R87
Session: session_01P8mZuzuyZAHSrgQKmv6ASv
Account: sunhaolin (the seat's linked user as GET /user answers it; always the card's assignee)
Branch: claude/issue-2083-quote-header-recompute
Worktree: hotcrm-issue-2083
Domain: repo:hotcrm (single-lane repo, no domain:* taxonomy)
Seat: repo:hotcrm#1
File surface: src/revenue/objects/quote.hook.ts (an additive step on quote_workflow that recomputes discount_amount and total_price when a user edits tax, discount or shipping_handling on an unsettled quote; ⛔ the freeze from PR #2076 is not touched), and src/revenue/objects/quote_line_item.hook.ts only to share the existing header formula rather than copy it; the tests under test/; content/docs/sales/quotes.mdx (+ zh-Hans / zh-Hant) only if a sentence becomes false; one .changeset/2083-*.md (stop on breach; explain in the report)
Container & model: M, mode:subagent, model: default (dispatch-gates --tier --repo objectstack-ai/hotcrm: "no path-derived mandate")
Clause-②: no
Responsibility: the app: no crm_quote hook recomputes the header when a header pricing input changes (quote_total_rollup fires on line writes only) | none: the platform runs the hooks it is given | every rep or manager who edits a quote's tax, discount or shipping, and the contract drafted from that quote's stale total
Thread-read: none
Serial constraints cleared: #2069 (the predecessor on src/revenue/**) landed as 77de62d4. #2077 waits behind this card on src/revenue/**. #2000 (this round) writes quote.object.ts / contract.object.ts, disjoint files; the later lander re-reads the src/revenue token ratchet (ceilings RULED ×1.5, 6143114246) on the merged tree.

Generated by Claude Code

os-dev-report

{
  "issue": 2083,
  "status": "done",
  "branch": "claude/issue-2083-quote-header-recompute",
  "pr": "https://github.com/objectstack-ai/hotcrm/pull/2109",
  "session": "session_01P8mZuzuyZAHSrgQKmv6ASv (subagent; the parent's id)",
  "premise_still_valid": true,
  "summary": "quote_workflow (src/revenue/objects/quote.hook.ts) gains one additive beforeUpdate step. When an update to an unsettled quote carries subtotal, discount, tax or shipping_handling, the step derives discount_amount = subtotal × discount% and total_price = subtotal − discount_amount + tax + shipping_handling into that same write. It runs for any writer. It skips a quote that was accepted or expired before the write, a quote with no subtotal, and the predicate path (D3). quote_total_rollup (quote_line_item.hook.ts) now writes only subtotal, and its write passes through the same step, so the header formula lives once. The PM's 'one function, two callers' (H2) cannot be built: hook bodies run body-only in QuickJS with no module scope, and lint refuses hook-body/not-lowerable. So the measured route is one formula with two triggers. The freeze is untouched: the step sits after it and skips settled quotes. On base 4de5343e, through REST on its own server, all three header edits left the totals stale. On the branch they re-derive in the same write, and an acceptance right after a discount edit drafts its contract at the re-derived total. A Console edit-dialog save of Discount % shows the new Total Price. No docs edit was needed: quotes.mdx:49 is now true.",
  "hypotheses": {
    "H1": "CONFIRMED on 18.0.0-next.1 (base 4de5343e, REST PATCH on own server :4183, QTE-0005). {tax: 7000}: total 86400, formula 87000. {discount: 10}: discount_amount 0, total 86400, formula 8000/79000. {shipping_handling: 500}: total 86400, formula 79500. On the branch: 87000, then 8000/79000, then 79500.",
    "H2": "DISPROVED as a shape: no function can be shared between two hook handlers (body-only QuickJS sandbox; _line-item-price-fill.ts header; os lint --strict hook-body/not-lowerable). Taken instead: the formula exists once, in quote_workflow; the rollup writes subtotal only and its write reaches the step.",
    "H3": "CONFIRMED: an accepted QTE-0002 {tax: 1} and an expired QTE-0001 {discount: 1} both answer 409 RECORD_LOCKED with the same message on base and on the branch, and neither row moves. Pinned by a settled control: the rep is refused with ['RECORD_LOCKED', 409], and a system write on the accepted quote re-derives nothing. Ablation B (settled guard dropped) turns exactly that control red, 86400 to 87000.",
    "H4": "CONFIRMED: the derive runs in beforeUpdate on the same write, and the rollup writes no derived figure, so nothing can double-apply. REST on the branch: a line quantity +1 on QTE-0004 gives subtotal 1,225,000 = the line sum, discount_amount 183,750, total 1,122,850. The rollup's existing 705 and 9,810 cases stay green, and turn red under ablation A.",
    "H5": "MEASURED, the card's inference holds. Base: QTE-0003 discount 5 to 10, then accepted, drafted contract CTR-0005 at contract_value 99,970 (formula 95,220). Branch: 95,220. Pinned by a test (78,400 on the QTE-0005 shape).",
    "H6": "A declarative route exists in principle: spec 18.0.0-next.1 has Field.formula (crm_quote.display_title; the line's subtotal/total_price) and Field.summary. NOT taken, per the card. Unmeasured costs: a formula is not a stored column; a lowered hook body cannot read one, and quote_accepted_contract_draft reads total_price; quote.view.ts sums total_price (summary: 'sum', summarizeField); quote_generation writes it at create."
  },
  "tests": "New describe in test/hooks-runtime.test.ts: 3 edits (it.each), a settled control, and a contract at the re-derived total. Targeted run: `pnpm exec vitest run --maxWorkers=2 --reporter=verbose test/hooks-runtime.test.ts -t quote_` gave 8 passed, 16 skipped, VERDICT command-exit 0. Ablations, from source (the suites import objectstack.config, so no dist), through objectstack scripts/ablation-replace.mjs (anchor x1 to x0, blob changed, restore blob == HEAD da644e5c1401, git diff HEAD empty), on hooks-runtime and hooks-runtime-sales with -t quote_. A: the derive disabled ('&& false') gave 12 failed, 24 passed. Red: the 3 edits, the contract case, the rollup's 705 and 9,810 cases, and the 6 acceptQuote CPQ cases. The settled control stayed green. B: the settled guard dropped gave 1 failed, 35 passed: only the settled control (total_price 86400 to 87000). Full suite on final head 7255b5ac: `pnpm test` gave 'Test Files 179 passed (179)' and 'Tests 3663 passed | 1 skipped (3664)', VERDICT command-exit 0. An earlier full run on 2efb525f was also 179/179 and 3663 passed. One locked run of the gate runner exited 2 on a shell syntax error in my own runner script (held the lock 0s). That run measured nothing, and the run was repeated.",
  "gates": "Local, hotcrm's pnpm verify chain, all on final head 7255b5ac with a clean tree (exit codes captured before any pipe; validate/typecheck/lint/build/test under os-verify-lock with slot hotcrm-2083, VERDICT command-exit 0). pnpm validate: exit 0, '✓ Validation passed'. pnpm typecheck: exit 0, tsc --noEmit with no diagnostics. pnpm lint (os lint --strict): exit 0, '18 suggestion(s)', no errors, so the hook still lowers. pnpm lint:i18n-gate: exit 0, '✓ i18n lint gate: 0 i18n/missing-* issues'. pnpm hygiene: exit 0, '✓ source hygiene clean'. pnpm hygiene:tokens: exit 0, '✓ source token ratchet clean'; src/revenue authored total ~18,934 to ~19,058 (ceiling ~28,500), business semantics ~15,794 to ~15,918 (ceiling ~24,000), interaction ~2,165 unchanged. pnpm build: exit 0, '✓ Build complete', 'all 44 callables are body-only', 8 author-time warnings (8 on base). pnpm test: exit 0, 179/179 files, 3663 passed, 1 skipped. dispatch-gates.mjs answers objectstack only, so --ran reconciliation does not apply; the list was hand-derived per the order. CI on PR #2109 head 7255b5ac at report time: 'Vercel Preview Comments' success, 'Label Pull Request' success; 'Playwright', 'link-check', 'Build and Test (22.x)', 'Quality Checks', 'Check Changeset' and 'Analyze Code (javascript)' in_progress.",
  "line_budget": "108 changed lines (88 added, 20 deleted) against a budget of about 200: quote.hook.ts +34/−1, quote_line_item.hook.ts +11/−19, test/hooks-runtime.test.ts +36/−0, .changeset/2083-quote-header-recompute.md +7/−0",
  "files_changed": [
    "src/revenue/objects/quote.hook.ts",
    "src/revenue/objects/quote_line_item.hook.ts",
    "test/hooks-runtime.test.ts",
    ".changeset/2083-quote-header-recompute.md"
  ],
  "deviations": [
    "Commit 2efb525f ends with a Co-Authored-By trailer that names the model. I copied it from the session's attribution reminder; the standing rule is the model-free pair. The second commit 7255b5ac uses the model-free pair. Branch history is not rewritten (no force-push).",
    "Suggested route H2 ('one function, two callers') was replaced by 'one formula, two triggers', because the sandbox forbids sharing a function between hook bodies. All edits stayed inside the claim's File surface."
  ],
  "mcp_calls": "0",
  "api_writes": "2: (1) pr_create through node scripts/pm/fleet-write/dispatch.mjs, i.e. POST /repos/objectstack-ai/objectstack/dispatches, which the relay executes as POST /repos/objectstack-ai/hotcrm/pulls (draft, assignees [sunhaolin]) and which produced PR #2109; read-back 7880 bytes sent, 7880 stored, identical. (2) this os-dev-report comment, POST /repos/objectstack-ai/hotcrm/issues/2083/comments through post-stamped.mjs. Zero label writes: the labels ci/cd, metadata and backend on the PR come from the repo's labeler. git push x3 to the branch (not REST). The local PATCHes against my own server on :4183 are not GitHub writes.",
  "open_questions": [],
  "out_of_scope_findings": [
    "class: b · reach: PATCH /api/v1/data/crm_quote/QTE-0004 {total_price: 1} → 200, stored 1 against the formula's 1,101,600 (own server, branch head 7255b5ac). The next pricing edit {tax: 81601} silently replaced it with 1,101,601. On base, nothing reads a user's total_price edit, so a hand-typed total survives until the next line write. The Console edit dialog's 'Totals' tab renders discount_amount and total_price as inputs (DOM: input names discount_amount and total_price). · evidence: contract text content/docs/sales/quotes.mdx 'The system does the math for you: … Total Price = Subtotal − Discount + Tax + Shipping & Handling'. Seam: spec:crm_quote.total_price,crm_quote.discount_amount (not readonly) → renderer: Console record edit dialog, Totals tab | runtime: REST PATCH stores the typed figure. quote.object.ts:179-193 justifies leaving them non-readonly by the rollup's ctx.api write, which after #2083 carries only subtotal. In-place change refused: quote.object.ts is held by #2000 this round. · dedupe words: quote total_price readonly, hand-typed total overwritten, discount_amount editable, quote Totals tab, derived quote totals editable",
    "carrier: none · noted, not filed. Four comments still credit the whole header formula to quote_total_rollup: quote.object.ts:179-193, quote_line_item.object.ts:184-188, revenue.seed.ts:142-150, _thresholds.ts:58. The formula they state is unchanged; since #2083 the rollup writes subtotal and quote_workflow derives the pair. quote.object.ts:358 still names the freeze quote_pricing_guard. Recorded in the PR's Acceptance notes.",
    "carrier: none · noted, not filed. quote_generation (quote-generation.flow.ts:176-177) still computes discount_amount/total_price in CEL at create. That is an insert path, which the beforeUpdate step does not cover. Recorded in the PR's Acceptance notes."
  ],
  "cleanup": "Dev servers I started (PGIDs 5487, 14432, 21356) were killed by process group and the port answers 000. node_modules was removed and the worktree /home/user/hotcrm-issue-2083 was removed with git worktree remove (no --force). No background job of mine is still running."
}

Generated by Claude Code

ACCEPT → PR #2109 comment 6181529893 · 2026-10-15T00:28Z

落地 · 2026-10-15T00:30Z

读数	探针	结果
队列分支	`git ls-remote origin 'refs/heads/gh-readonly-queue/*'`	空（已出队；timeline：2026-10-15T00:29Z 入队 → merged）
`origin/main`	`git merge-base --is-ancestor 9e064b3d origin/main`	是；`origin/main` = `9e064b3d` `fix(quote): a quote's own discount, tax or shipping edit re-derives its totals (#2109)`，父提交 `4de5343e`

状态变更：Fixes #2083 已代关（completed）；摘 pm:dispatched、unassign，收口。src/revenue/** 串行队的下一位 #2077 随即可派；跟进卡 #2110（总价/折扣金额可手填）排在 #2000 之后。

Navigation Menu

Repository navigation

Editing a quote's own Tax, Discount % or Shipping does not update its total until some line item is touched (the docs promise the totals update automatically) #2083

What happens (REST door, `objectstack dev` at hotcrm `b8f5421`, 17.7.0)

Why

Acceptance

For the dispatch

Duplicate check

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Editing a quote's own Tax, Discount % or Shipping does not update its total until some line item is touched (the docs promise the totals update automatically) #2083

Description

What happens (REST door, objectstack dev at hotcrm b8f5421, 17.7.0)

Why

Acceptance

For the dispatch

Duplicate check

Activity

objectstack-fleet commented on Oct 14, 2026

objectstack-fleet commented on Oct 15, 2026

objectstack-fleet commented on Oct 15, 2026

objectstack-fleet commented on Oct 15, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

What happens (REST door, `objectstack dev` at hotcrm `b8f5421`, 17.7.0)