feat: open access to any authenticated user, remove ZPA students page#57
Merged
Conversation
glabs-web no longer has a login allowlist — the auth proxy (hm.edu) is the sole access boundary, so the "Kein Zutritt" gate in hooks.server.ts checked a rule that no longer exists. Drop the gate; keep only the auth-context setup that forwards X-Remote-User to the backend. Remove the ZPA-enriched students page (courses/[name]/students) and its link. The backend no longer exposes courseStudents / CourseStudent; schema.graphql and the codegen output are pulled fresh to match. The roster editor (setCourseStudents) is untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Passt die GUI an das offene Zugangsmodell von glabs-web an: keine Allowlist mehr, der Auth-Proxy (
hm.edu) ist die einzige Zugangsgrenze.hooks.server.ts: Der „Kein Zutritt"-Riegel prüfte gegen die Backend-Allowlist, die es nicht mehr gibt (toter Code, ließ ohnehin immer durch). Entfernt; es bleibt nur das Setzen des Auth-Kontexts (X-Remote-User-Weitergabe).courses/[name]/students/) samt Button gelöscht. Das Backend liefertcourseStudents/CourseStudentnicht mehr;schema.graphql+ Codegen frisch gezogen. Die Roster-Bearbeitung (setCourseStudents) bleibt unberührt.Kompatibilität
Kein Breaking-Change-Marker. Muss zusammen mit obcode/glabs#132 gemergt/deployt werden (koordinierte Schema-Änderung).
Checks
pnpm check·pnpm lint·pnpm test(20 passed) ·pnpm build— alle grün.🤖 Generated with Claude Code