Repository navigation
[ROS2RobotImporter] Add warning banner for registries and articulations - #1099
Merged
nick-l-o3de merged 1 commit intoSep 23, 2026
Merged
Conversation
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
byrcolin
added
the
sig/simulation
nick-l-o3de
approved these changes
Sep 23, 2026
This was referenced Oct 12, 2026
jhanca-robotecai
added a commit
that referenced
this pull request
Oct 12, 2026
* Ability to get inertial property from AddToArticulationConfig (#1088) Signed-off-by: welber-zhang <welber.zhang@huawei.com> (cherry picked from commit bc9eb68) * Added possibility to set history policy (#1098) Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai> (cherry picked from commit d7b3858) * [MachineLearning] Update ScriptCanvas after engine changes (#1101) * [MachineLearning] Update ScriptCanvas after engine changes Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * [MachineLearning] Fix build Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> (cherry picked from commit ee2ff33) * [Tests] redo spawning test (w/o AssetProcessor) (#1100) Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> (cherry picked from commit f23e7ae) * [ROS2RobotImporter] Add warning banner for registries and articulations (#1099) Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> (cherry picked from commit 2518837) --------- Signed-off-by: welber-zhang <welber.zhang@huawei.com> Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Co-authored-by: 张东 <welber.zhang@huawei.com> Co-authored-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creating a project from O3DE template results in different registry settings compared to creating a project from robotic O3DE templates. Some assets might be correct or incorrect due to the fixed coordinate system, see o3de/o3de#18686 for details.
I wasted nearly two hours rebuilding assets and different versions of engines to find out why I cannot import the same robot in different project anymore. In this PR I added a warning for robot importer, so it get very easy to spot when working on the project with configuration that might influence
.daeand.stlreadouts typical for URDF/SDF robots.Additionally, I adjusted warning about >64 articulations to follow the same style.
Screenshots below:
How was this PR tested?
Imported robots with and without registry flag.