feat: sync list filters with url params - #859
Draft
capfroggy wants to merge 1 commit into
Draft
Conversation
|
😅 Ups... the issue does not have any reward yet! |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related Ticket(s)
Key Changes
useUrlFiltershook in@o2s/uifor namespaced query param serialization/parsing.{ns}_pageas a 1-based page value, and{ns}_viewfor non-default view modes.ticket-list,order-list,invoice-list,product-list, andnotification-listto use URL-backed filters.router.replace(..., { scroll: false })to avoid browser history pollution.Side effects:
How to test
npm ci.npm run lint.npm run test.Local checks I could run in this environment:
git diff --checkprettier@3.8.1 --checkwith the repo's main formatting options and--no-configbecause local workspace deps were unavailabletsxsmoke test importingparseUrlFilters,parseUrlViewMode, andserializeUrlFiltersdirectlyI could not run the full monorepo
npm run lint/npm run testlocally because this checkout environment does not havenpm,node_modules, or the internal@o2s/*config packages installed.Media (Loom or gif)