Preserve qualified merge reconstruction through admission transport - #33
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An external admission command can receive a merge-preservation receipt and qualify an authored-in-merge change for ordered reconstruction. SVRF currently wraps its
reland:REFUSED:MERGE_LOSSline as an ordinary check failure, so the train holds it instead of reconstructing the same final tree.Preserve this qualified external result through Admission and the existing RELAND decision. Built-in history loss, bare/unqualified loss, mixed diagnostic failures, and
reland=Falsecontinue to hold. The external admission owner remains responsible for checking preservation before emitting the qualified line.Committed RED df67d33 precedes the minimal rule change. The unchanged new tests exercise the actual command-to-Admission-to-rules route and its negative cases. Full
make test: 366 tests passed on Python 3.12.14, including the demo and denylist. The first full run exposed this container PID 1 retaining a killed sleep child as a zombie; the unchanged suite passes under a Linux child-subreaper wrapper. Both observations are retained locally. CI owns the other Python versions, proofs, and container smoke.