Repository navigation
feat(compose)+chore(oss): mistune markdown render + private-ref scrub - #23
Merged
Merged
Conversation
Two changes bundled for one OSS-readiness pass. == Compose: real markdown rendering == The T33 compose_record used a naive paragraph-only converter that rendered markdown lists as one <p> blob and tables as raw `|---|` text. Swap in mistune>=3.0 with GFM table + strikethrough + task_lists + autolink plugins and escape=False so the chart-embed snippets compose splices in for <ClaimChart> tags pass through intact. Net surface change: lists, tables, blockquotes, inline code, links, headings (h1-h6), and ordered/unordered lists now render correctly in narrative.html output. All 835 tests still pass — claim/chart ref binding behaviour is unchanged. Version bump 0.1.6 -> 0.1.7 to flag the new mistune dep to consumers. == OSS scrub: private refs == Replace internal hostnames + business + sibling-repo names across 18 files in src/, eval/, .html-kit/, SPEC.md, and tests/ so the public repo carries no inferences about the author's internal infra: growth_insights -> consumer-repo nairomarket -> your-business naimarket -> your-business kuze -> consumer-repo kg_rust -> consumer-repo kg_rust_embed_first -> consumer-repo-2 lan.ds.ke -> internal.example.com infisical.lan.ds.ke -> infisical.internal.example.com laminar-grpc.lan.ds.ke -> laminar-grpc.internal.example.com `LMNR_PROJECT_API_KEY_INSIGHT_KIT` env name retained — it documents the "use a dedicated key per consumer" convention, not a leak. Git history left intact (rewriting destroys SHAs other repos may pin). .eval/ added to .gitignore — local demo artefacts (shopify_meta_attr compose output) don't belong in tree. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes bundled for one OSS-readiness pass:
1. `compose_record` now uses mistune for markdown rendering
The T33 composer's old `_markdown_to_html_paragraphs` rendered lists as one `
` blob and markdown tables as raw `|---|` text. Swap in `mistune>=3.0` with the GFM table + strikethrough + task_lists + autolink plugins and `escape=False` so the chart-embed snippets pass through intact.
2. Private-ref scrub across 18 files
Replace internal hostnames + business + sibling-repo names so the public repo carries no inferences about author's internal infra:
`LMNR_PROJECT_API_KEY_INSIGHT_KIT` env name retained — documents the "dedicated key per consumer" convention, not a leak.
Git history left intact (rewrite destroys SHAs that downstream consumers pin).
`.eval/` added to `.gitignore` — local demo artefacts no longer leak into tree.
Test plan
🤖 Generated with Claude Code